From: Andrea Arcangeli <andrea@suse.de>
To: Jens Axboe <axboe@suse.de>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org,
"ZINKEVICIUS,MATT (HP-Loveland,ex1)" <matt_zinkevicius@hp.com>
Subject: Re: patch: highmem zero-bounce
Date: Wed, 27 Jun 2001 11:41:55 +0200 [thread overview]
Message-ID: <20010627114155.A31910@athlon.random> (raw)
In-Reply-To: <20010626182215.C14460@suse.de>; from axboe@suse.de on Tue, Jun 26, 2001 at 06:22:15PM +0200
On Tue, Jun 26, 2001 at 06:22:15PM +0200, Jens Axboe wrote:
> Hi,
>
> I updated the patches to 2.4.6-pre5, and removed the zone-dma32
> addition. This means that machines with > 4GB of RAM will need to go all
good, we can relax the ZONE_NORMAL later, that's a separate problem with
skipping the bounces.
I can see one mm corruption race condition in the patch, you missed
nested irq in the for kmap_irq_bh (PIO). You must _always_
__cli/__save_flags before accessing the KMAP_IRQ_BH slot, in case the
remapping is required (so _only_ when the page is in the highmem zone).
Otherwise memory corruption will happen when the race triggers (for
example two ide disks in PIO mode doing I/O at the same time connected
to different irq sources).
Andrea
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/
next prev parent reply other threads:[~2001-06-27 9:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-26 16:22 Jens Axboe
2001-06-27 9:41 ` Andrea Arcangeli [this message]
2001-06-27 16:27 ` Jens Axboe
2001-06-27 16:49 ` Jens Axboe
2001-06-27 17:06 ` Andrea Arcangeli
2001-06-27 17:12 ` Jens Axboe
2001-07-06 13:41 ` Andrea Arcangeli
2001-07-06 13:45 ` Jens Axboe
2001-07-06 13:58 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010627114155.A31910@athlon.random \
--to=andrea@suse.de \
--cc=axboe@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=matt_zinkevicius@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox