From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Tue, 5 Jun 2001 23:14:54 +0100 From: "Stephen C. Tweedie" Subject: Re: [PATCH] reapswap for 2.4.5-ac10 Message-ID: <20010605231454.P26756@redhat.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: ; from marcelo@conectiva.com.br on Tue, Jun 05, 2001 at 04:48:46PM -0300 Sender: owner-linux-mm@kvack.org Return-Path: To: Marcelo Tosatti Cc: Alan Cox , =?iso-8859-1?Q?Andr=E9_Dahlqvist?= , linux-mm@kvack.org List-ID: Hi, On Tue, Jun 05, 2001 at 04:48:46PM -0300, Marcelo Tosatti wrote: > I'm resending the reapswap patch for inclusion into -ac series. Isn't it broken in this state? Checking page_count, page->buffers and PageSwapCache without the appropriate locks is dangerous. I think you need the page lock at the very least before making this test. --Stephen -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux-mm.org/