From: "Velizar Bodurski" <velizar81@yahoo.com>
To: linux-mm@kvack.org
Cc: torvalds@transmeta.com
Subject: [PATCH] thinko in filemap.c
Date: Fri, 6 Apr 2001 19:47:48 +0300 [thread overview]
Message-ID: <20010406194748.A561@koil.lint> (raw)
There is a small thinko in the way remove_page_from_inode_queue()
and __remove_inode_page() are working together. A patch follows
which should separate the work for the different functions.
Right now remove_page_from_inode_queue() after doing its job
is doing page->mapping = NULL;
This function is called by __remove_inode_page with no locks held
which also is doing page->mapping = NULL, this is needles. So with
this patch i'm removing the second NULLifying of the page's mapping.
Any comments are welcome. There is one question with this patch
and that is shouldn't it be the reverse way, I may have gotten
it the wrong way :).
This is against 2.4.3
----
diff -u mm/filemap.c.orig mm/filemap.c
--- mm/filemap.c.orig Fri Apr 6 19:33:41 2001
+++ mm/filemap.c Fri Apr 6 19:38:51 2001
@@ -108,7 +108,6 @@
if (PageDirty(page)) BUG();
remove_page_from_inode_queue(page);
remove_page_from_hash_queue(page);
- page->mapping = NULL;
}
void remove_inode_page(struct page *page)
_________________________________________________________
Do You Yahoo!?
Get your free @yahoo.com address at http://mail.yahoo.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
reply other threads:[~2001-04-06 16:47 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20010406194748.A561@koil.lint \
--to=velizar81@yahoo.com \
--cc=linux-mm@kvack.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox