From: "Theodore Y. Ts'o" <tytso@MIT.EDU>
To: "David S. Miller" <davem@redhat.com>
Cc: davej@suse.de, torvalds@transmeta.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: BUG FIX?: mm->rss is modified in some places without holding the page_table_lock
Date: Fri, 3 Nov 2000 09:56:15 -0500 [thread overview]
Message-ID: <200011031456.JAA21492@tsx-prime.MIT.EDU> (raw)
In-Reply-To: David S. Miller's message of Fri, 3 Nov 2000 03:33:37 -0800, <200011031133.DAA10265@pizda.ninka.net>
Given that we don't have a 64-bit atomic_t type, what do people
think of Davej's patch? (attached, below)
Broken, in 9 out of 10 places where he adds page_table_lock
acquisitions, this lock is already held --> instant deadlock.
This report is complicated by the fact that people were forgetting
that vmlist_*_{lock,unlock}(mm) was actually just spin_{lock,unlock}
on mm->page_table_lock. I fixed that already by removing the dumb
vmlist locking macros which were causing all of this confusion.
Are you saying that the original bug report may not actually be a
problem? Is ms->rss actually protected in _all_ of the right places, but
people got confused because of the syntactic sugar?
- Ted
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-11-03 14:56 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-10-13 0:20 Updated Linux 2.4 Status/TODO List (from the ALS show) davej
2000-10-13 0:29 ` David S. Miller
2000-10-13 5:02 ` Linus Torvalds
2000-10-13 11:45 ` Alan Cox
2000-10-13 21:17 ` Richard Henderson
2000-10-13 21:19 ` Jakub Jelinek
2000-10-13 21:25 ` Linus Torvalds
2000-10-13 22:56 ` Richard Henderson
2000-10-13 22:47 ` Alan Cox
2000-10-13 22:57 ` Richard Henderson
2000-10-14 0:20 ` David S. Miller
2000-10-14 12:36 ` Roman Zippel
2000-10-13 21:29 ` David S. Miller
2000-10-13 4:34 ` Andrey Savochkin
2000-10-13 4:25 ` David S. Miller
2000-10-13 4:50 ` Andrey Savochkin
2000-10-13 5:05 ` Linus Torvalds
2000-10-13 18:11 ` Rasmus Andersen
2000-10-13 18:19 ` Kanoj Sarcar
2000-11-03 11:39 ` BUG FIX?: mm->rss is modified in some places without holding the page_table_lock tytso
2000-11-03 11:33 ` David S. Miller
2000-11-03 14:56 ` Theodore Y. Ts'o [this message]
2000-11-03 14:51 ` David S. Miller
2000-11-04 23:37 ` Rasmus Andersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200011031456.JAA21492@tsx-prime.MIT.EDU \
--to=tytso@mit.edu \
--cc=davej@suse.de \
--cc=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox