linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: ehrhardt@mathematik.uni-ulm.de
To: Rik van Riel <riel@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org,
	Linus Torvalds <torvalds@transmeta.com>
Subject: Re: [PATCH] fix for VM  test9-pre7
Date: Mon, 2 Oct 2000 14:05:59 +0200	[thread overview]
Message-ID: <20001002120559.13349.qmail@theseus.mathematik.uni-ulm.de> (raw)
In-Reply-To: <Pine.LNX.4.21.0010020038090.30717-100000@duckman.distro.conectiva>; from riel@conectiva.com.br on Mon, Oct 02, 2000 at 12:42:47AM -0300

Hi,

On Mon, Oct 02, 2000 at 12:42:47AM -0300, Rik van Riel wrote:
> --- linux-2.4.0-test9-pre7/fs/buffer.c.orig	Sat Sep 30 18:09:18 2000
> +++ linux-2.4.0-test9-pre7/fs/buffer.c	Mon Oct  2 00:19:41 2000
> @@ -706,7 +706,9 @@
>  static void refill_freelist(int size)
>  {
>  	if (!grow_buffers(size)) {
> -		try_to_free_pages(GFP_BUFFER);
> +		wakeup_bdflush(1);
> +		current->policy |= SCHED_YIELD;
> +		schedule();
>  	}
>  }

This part looks strange! wakeup_bdflush will sleep if the parameter
is not zero, i.e. we'll schedule twice. I doubt that this the intended
behaviour?

    regards    Christian

-- 
THAT'S ALL FOLKS!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

  parent reply	other threads:[~2000-10-02 12:05 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-10-02  3:42 Rik van Riel
2000-10-02  8:18 ` Roger Larsson
2000-10-02 10:00   ` Ignore my: " Roger Larsson
2000-10-02 15:48     ` Rik van Riel
2000-10-02 15:45   ` Rik van Riel
2000-10-02 12:05 ` ehrhardt [this message]
2000-10-02 15:49   ` Rik van Riel
2000-10-02 12:27 ` Tom Leete
2000-10-02 15:51   ` Rik van Riel
2000-10-02 21:20     ` Tom Leete
2000-10-02 16:46 ` Christoph Rohland
2000-10-02 17:17   ` Rik van Riel
2000-10-04  7:45     ` Christoph Rohland

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20001002120559.13349.qmail@theseus.mathematik.uni-ulm.de \
    --to=ehrhardt@mathematik.uni-ulm.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=riel@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox