From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 25 Sep 2000 16:29:21 +0200 From: Andrea Arcangeli Subject: Re: [patch] vmfixes-2.4.0-test9-B2 Message-ID: <20000925162921.M22882@athlon.random> References: <20000925155650.F22882@athlon.random> <20000925161358.J22882@athlon.random> <20000925160838.R26339@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20000925160838.R26339@suse.de>; from axboe@suse.de on Mon, Sep 25, 2000 at 04:08:38PM +0200 Sender: owner-linux-mm@kvack.org Return-Path: To: Jens Axboe Cc: Ingo Molnar , Linus Torvalds , Rik van Riel , Roger Larsson , MM mailing list , linux-kernel@vger.kernel.org List-ID: On Mon, Sep 25, 2000 at 04:08:38PM +0200, Jens Axboe wrote: > The sg problem was different. When sg queues a request, it invokes the > request_fn to handle it. But if the queue is currently plugged, the > scsi_request_fn will not do anything. That will explain it, yes. In the same way for correctness also those should be converted from request_fn to generic_unplug_device, right? (this will also avoid to recall spurious request_fn because the device is still in the tq_disk queue even when the I/O generated by the below request_fn completed) if (major >= COMPAQ_SMART2_MAJOR+0 && major <= COMPAQ_SMART2_MAJOR+7) (q->request_fn)(q); if (major >= DAC960_MAJOR+0 && major <= DAC960_MAJOR+7) (q->request_fn)(q); Andrea -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/