From mboxrd@z Thu Jan 1 00:00:00 1970 Date: Mon, 25 Sep 2000 11:51:39 -0600 From: yodaiken@fsmlabs.com Subject: Re: the new VMt Message-ID: <20000925115139.A14999@hq.fsmlabs.com> References: <20000925164249.G2615@redhat.com> <20000925105247.A13935@hq.fsmlabs.com> <20000925191829.A14612@pcep-jamie.cern.ch> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20000925191829.A14612@pcep-jamie.cern.ch>; from Jamie Lokier on Mon, Sep 25, 2000 at 07:18:29PM +0200 Sender: owner-linux-mm@kvack.org Return-Path: To: Jamie Lokier Cc: yodaiken@fsmlabs.com, "Stephen C. Tweedie" , Alan Cox , mingo@elte.hu, Andrea Arcangeli , Marcelo Tosatti , Linus Torvalds , Rik van Riel , Roger Larsson , MM mailing list , linux-kernel@vger.kernel.org List-ID: On Mon, Sep 25, 2000 at 07:18:29PM +0200, Jamie Lokier wrote: > yodaiken@fsmlabs.com wrote: > > walk = out; > > while(nfds > 0) { > > poll_table *tmp = (poll_table *) __get_free_page(GFP_KERNEL); > > if (!tmp) { > > Shouldn't this be GFP_USER? (Which would also conveniently fix the > problem Victor's pointing out...) It should probably be GFP_ATOMIC, if I understand the mm right. The algorithm for requesting a collection of reources and freeing all of them on failure is simple, fast, and robust. -- --------------------------------------------------------- Victor Yodaiken Finite State Machine Labs: The RTLinux Company. www.fsmlabs.com www.rtlinux.com -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@kvack.org. For more info on Linux MM, see: http://www.linux.eu.org/Linux-MM/