linux-mm.kvack.org archive mirror
 help / color / mirror / Atom feed
From: "David S. Miller" <davem@redhat.com>
To: quintela@fi.udc.es
Cc: riel@conectiva.com.br, linux-mm@kvack.org,
	linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH *] VM patch for 2.4.0-test8
Date: Thu, 14 Sep 2000 01:18:56 -0700	[thread overview]
Message-ID: <200009140818.BAA21978@pizda.ninka.net> (raw)
In-Reply-To: <yttg0n3lcyr.fsf@serpe.mitica> (quintela@fi.udc.es)

   I can only see one place where we add a page to the page cache and
   we don't increase its page count, and it is in grow_buffers().
   Could somebody explain me _why_ we don't need to do a
   page_cache_get(page) in that function?

It's being added only to the LRU lists, not the page cache hashes. It
is a buffer-cache page not a page-cache page (ie. page->mapping ==
NULL).

The alloc_page() returns the page with a single reference, which thus
represents the refence to the page held by the buffer heads
grow_buffers attaches to it.

Later,
David S. Miller
davem@redhat.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/

  reply	other threads:[~2000-09-14  8:18 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2000-09-14  4:30 Rik van Riel
2000-09-14  5:25 ` David S. Miller
2000-09-14  6:11   ` Juan J. Quintela
2000-09-14  8:18     ` David S. Miller [this message]
2000-09-14 16:53   ` Rik van Riel
2000-09-14 17:49     ` Rik van Riel
2000-09-15 17:28     ` Martin Josefsson
2000-09-15 19:37       ` Jamie Lokier
2000-09-15 21:07         ` David Ford
2000-09-15 22:04         ` Rik van Riel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200009140818.BAA21978@pizda.ninka.net \
    --to=davem@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=quintela@fi.udc.es \
    --cc=riel@conectiva.com.br \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox