From: "David S. Miller" <davem@redhat.com>
To: riel@conectiva.com.br
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH *] VM patch for 2.4.0-test8
Date: Wed, 13 Sep 2000 22:25:14 -0700 [thread overview]
Message-ID: <200009140525.WAA21446@pizda.ninka.net> (raw)
In-Reply-To: <Pine.LNX.4.21.0009140119560.1075-100000@duckman.distro.conectiva> (message from Rik van Riel on Thu, 14 Sep 2000 01:30:26 -0300 (BRST))
In page_launder() about halfway down there is this sequence of tests
on LRU pages:
if (!clearedbuf) {
...
} else if (!page->mapping) {
...
} else if (page_count(page) > 1) {
} else /* page->mapping && page_count(page) == 1 */ {
...
}
Above this sequence we've done a page_cache_get. For the final case
in the tests above (page->mapping != NULL && page_count(page) == 1)
have you checked if this ever happens or is even possible?
If the page is a page cache page (ie. page->mapping != NULL) it
should hold a reference. Adding in our reference, the count should
always thus be > 1.
What did I miss?
Later,
David S. Miller
davem@redhat.com
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-09-14 5:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-09-14 4:30 Rik van Riel
2000-09-14 5:25 ` David S. Miller [this message]
2000-09-14 6:11 ` Juan J. Quintela
2000-09-14 8:18 ` David S. Miller
2000-09-14 16:53 ` Rik van Riel
2000-09-14 17:49 ` Rik van Riel
2000-09-15 17:28 ` Martin Josefsson
2000-09-15 19:37 ` Jamie Lokier
2000-09-15 21:07 ` David Ford
2000-09-15 22:04 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200009140525.WAA21446@pizda.ninka.net \
--to=davem@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=riel@conectiva.com.br \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox