filemap_sync over-eager at flushing?

filemap_sync over-eager at flushing?

[Russell King]

Hi,

I've been looking at the TLB/Cache code in 2.4.0-test7 (prompted by
Dave Millers description in test8-pre1), and have come across something
odd:

filemap_sync() calls flush_{cache,tlb}_range().  In between, it
eventually calls filemap_sync_pte(), which uses flush_{cache,tlb}_page().
But hang on, we've already done flush_cache_range(), and are going to do
flush_tlb_range() in filemap_sync(), so isn't the flush_{cache,tlb}_page
rather unnecessary?
   _____
  |_____| ------------------------------------------------- ---+---+-
  |   |         Russell King        rmk@arm.linux.org.uk      --- ---
  | | | | http://www.arm.linux.org.uk/personal/aboutme.html   /  /  |
  | +-+-+                                                     --- -+-
  /   |               THE developer of ARM Linux              |+| /|\
 /  | | |                                                     ---  |
    +-+-+ -------------------------------------------------  /\\\  |
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/