From: Neil Schemenauer <nascheme@enme.ucalgary.ca>
To: Kanoj Sarcar <kanoj@google.engr.sgi.com>
Cc: linux-mm@kvack.org
Subject: Re: shrink_mmap bug in 2.2?
Date: Thu, 15 Jun 2000 13:12:41 -0600 [thread overview]
Message-ID: <20000615131241.D9717@acs.ucalgary.ca> (raw)
In-Reply-To: <200006150116.SAA41023@google.engr.sgi.com>; from kanoj@google.engr.sgi.com on Wed, Jun 14, 2000 at 06:16:10PM -0700
On Wed, Jun 14, 2000 at 06:16:10PM -0700, Kanoj Sarcar wrote:
> Aren't you misreading the logic here? It is
>
> referenced && swap_count(page->offset) != 1)
> ^^^^
[...]
> So delete_from_swap_cache will only ever be called on a page
> with swap_count(page->offset) == 1.
If the page is not referenced it will be removed regardless of
the swap_count. My question is "does swap_count have to equal
one before calling delete_from_swap_cache"? If it does then I
think the code is wrong.
I wouldn't consider this code old as it is in the current stable
kernel (2.2.16).
Neil
--
145 = 1! + 4! + 5!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
next prev parent reply other threads:[~2000-06-15 19:12 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-06-15 0:50 Neil Schemenauer
2000-06-15 1:16 ` Kanoj Sarcar
2000-06-15 8:58 ` volodya
2000-06-15 16:56 ` Kanoj Sarcar
2000-06-15 19:12 ` Neil Schemenauer [this message]
2000-06-16 10:05 ` Stephen C. Tweedie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20000615131241.D9717@acs.ucalgary.ca \
--to=nascheme@enme.ucalgary.ca \
--cc=kanoj@google.engr.sgi.com \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox