Re: shrink_mmap bug in 2.2?

[kanoj@google.engr.sgi.com (Kanoj Sarcar)]

> 
> This code looks strange to me (possibly because I don't
> understand it):
> 
>     /*
>      * Is it a page swap page? If so, we want to
>      * drop it if it is no longer used, even if it
>      * were to be marked referenced..
>      */
>     if (PageSwapCache(page)) {
>             if (referenced && swap_count(page->offset) != 1)
>                     continue;
>             delete_from_swap_cache(page);
>             return 1;
>     }       

Aren't you misreading the logic here? It is

	referenced && swap_count(page->offset) != 1)
	          ^^^^
and not

	referenced || swap_count(page->offset) != 1)
                 ^^^^^

So delete_from_swap_cache will only ever be called on a page
with swap_count(page->offset) == 1.

Kanoj

> 
> Can pages be deleted from the swap cache if swap_count is not
> one?  If not, then I think this code is wrong.  It should be:
> 
>     if (PageSwapCache(page)) {
>             if (swap_count(page->offset) != 1)
>                     continue;
>             delete_from_swap_cache(page);
>             return 1;
>     }       
>  
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/