From: "Stephen C. Tweedie" <sct@redhat.com>
To: I Lee Hetherington <ilh@sls.lcs.mit.edu>
Cc: Russell King <rmk@arm.linux.org.uk>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
sully@omega.barnet.ac.uk, Bryan Paxton <evil7@bellsouth.net>,
linux-kernel@vger.rutgers.edu, Stephen Tweedie <sct@redhat.com>,
linux-mm@kvack.org
Subject: Re: -ac13 buffer.c MAJOR bug
Date: Sun, 11 Jun 2000 20:23:47 +0100 [thread overview]
Message-ID: <20000611202347.E5506@redhat.com> (raw)
In-Reply-To: <3943BFA0.445B747C@sls.lcs.mit.edu>; from ilh@sls.lcs.mit.edu on Sun, Jun 11, 2000 at 12:34:40PM -0400
[-- Attachment #1: Type: text/plain, Size: 650 bytes --]
Hi,
On Sun, Jun 11, 2000 at 12:34:40PM -0400, I Lee Hetherington wrote:
> I am not seeing this BUG in ac12. It is solid for me. It would seem to
> be an ac13 feature.
It is. The fix is below.
The problem is that with async write-behind, buffers on the per-inode
dirty list can be cleaned and I/O can complete before the vm scanner
identifies the clean buffer and refiles it (which will remove if from
the inode list). So, we can end up with clean buffers on the per-inode
dirty list. It is quite legal to recycle these buffers, and
try_to_free_buffers() already owns the necessary spinlocks to do so
by the time it gets this far.
--Stephen
[-- Attachment #2: osync-2.4.0-test1-ac13.diff1 --]
[-- Type: text/plain, Size: 337 bytes --]
--- linux-2.4.0-test1-ac13/fs/buffer.c.~1~ Sun Jun 11 19:50:22 2000
+++ linux-2.4.0-test1-ac13/fs/buffer.c Sun Jun 11 19:54:57 2000
@@ -2438,9 +2438,7 @@
* queues or on the free list..
*/
if (p->b_dev != B_FREE) {
- // @@@
- if (p->b_inode)
- BUG();
+ remove_inode_queue(p);
__remove_from_queues(p);
}
else
parent reply other threads:[~2000-06-11 19:23 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <3943BFA0.445B747C@sls.lcs.mit.edu>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20000611202347.E5506@redhat.com \
--to=sct@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=evil7@bellsouth.net \
--cc=ilh@sls.lcs.mit.edu \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=rmk@arm.linux.org.uk \
--cc=sully@omega.barnet.ac.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox