From: "Theodore Y. Ts'o" <tytso@MIT.EDU>
To: Ivan Kokshaysky <ink@jurassic.park.msu.ru>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Rik van Riel <riel@nl.linux.org>, Linux MM <linux-mm@kvack.org>,
Linux Kernel <linux-kernel@vger.rutgers.edu>
Subject: Re: 2.2.15pre4 VM fix
Date: Fri, 28 Jan 2000 12:26:50 -0500 [thread overview]
Message-ID: <200001281726.MAA12528@tsx-prime.MIT.EDU> (raw)
In-Reply-To: Ivan Kokshaysky's message of Fri, 28 Jan 2000 19:48:27 +0300, <20000128194827.A23800@jurassic.park.msu.ru>
On Fri, Jan 28, 2000 at 02:40:30PM +0000, Alan Cox wrote:
> > n_tty_open() has been caught with your patch.
> > Thanks!
>
> Do you know which drivers (serial,tty) you were using it. n_tty_open itself
> seems ok, but the caller may be guilty
It happened when ppp connection was terminated (remote end hangup).
Serial driver is Comtrol Rocketport. The problem is repeatable
(3 times last 20 hours), so I can investigate further to see who
is the caller.
I think it's a flase positive. It's happeninig because tty_do_hangup()
is calling ldisc.open --- which means n_tty_open() inside an interrupt
context. n_tty_open() makes a check to see whether it is being called
inside an interrupt, and uses GFP_ATOMIC to avoid blocking inside the
interrupt.
static int n_tty_open(struct tty_struct *tty)
{
....
get_zeroed_page(in_interrupt() ? GFP_ATOMIC : GFP_KERNEL);
...
}
This should be OK, I think.
- Ted
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux.eu.org/Linux-MM/
prev parent reply other threads:[~2000-01-28 17:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2000-01-26 0:20 Rik van Riel
2000-01-28 12:09 ` Ivan Kokshaysky
2000-01-28 14:40 ` Alan Cox
2000-01-28 16:29 ` Theodore Y. Ts'o
2000-01-28 16:48 ` Ivan Kokshaysky
2000-01-28 17:26 ` Theodore Y. Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200001281726.MAA12528@tsx-prime.MIT.EDU \
--to=tytso@mit.edu \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=ink@jurassic.park.msu.ru \
--cc=linux-kernel@vger.rutgers.edu \
--cc=linux-mm@kvack.org \
--cc=riel@nl.linux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox