From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 626EFC83F17 for ; Fri, 18 Jul 2025 09:31:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7FA48D0007; Fri, 18 Jul 2025 05:31:13 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D304E8D0001; Fri, 18 Jul 2025 05:31:13 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C1F1B8D0007; Fri, 18 Jul 2025 05:31:13 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id AA0368D0001 for ; Fri, 18 Jul 2025 05:31:13 -0400 (EDT) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 45D401603D7 for ; Fri, 18 Jul 2025 09:31:13 +0000 (UTC) X-FDA: 83676866826.10.626BE18 Received: from mail-ej1-f47.google.com (mail-ej1-f47.google.com [209.85.218.47]) by imf20.hostedemail.com (Postfix) with ESMTP id 448171C000C for ; Fri, 18 Jul 2025 09:31:11 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=W9Bqpfmi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1752831071; a=rsa-sha256; cv=none; b=0bZSQhHMj5zVKRwdussEt6nqV6sTLKeIFUVLbCIy6WtPZ9FXS0ym/iZ5CXsUw1+tU3VZ5E wOzIlJBxSFobQFF4J0oSzY6wULRGa3Mcn8nYgBB9qr++Z1Hv2X5Cz0vhOj5KDQnOc/GzHk 9rNK/LmMf/iF1ol6QkNCp/FgkrnNUsA= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=W9Bqpfmi; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf20.hostedemail.com: domain of asml.silence@gmail.com designates 209.85.218.47 as permitted sender) smtp.mailfrom=asml.silence@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1752831071; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=XjU6nrqfbiw0u0TIKCSt6roZUluHkikf0/decEoYNJE=; b=cyRxFRDeW3SmtmiaYneJulIIuVOoNsdSjs2edgDBOM7NwPgjPAe8DFHcwoO3ol7/e0+OlZ 5r4hSfH7xJMqnA6Vg92xKD5e5UH4yvGeJH4wpypLR0LvbPTeVNEpxCNoHFULTKIbjINj7B bDXuaZxE5ccHFTkTs/RfTBV2f/FZb58= Received: by mail-ej1-f47.google.com with SMTP id a640c23a62f3a-ae0dffaa8b2so373332066b.0 for ; Fri, 18 Jul 2025 02:31:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1752831070; x=1753435870; darn=kvack.org; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id:from:to :cc:subject:date:message-id:reply-to; bh=XjU6nrqfbiw0u0TIKCSt6roZUluHkikf0/decEoYNJE=; b=W9BqpfmiEOwD1DCtiwiJpA60DNsmp126L1TXtL5wlVM9Seo0APnXJzMGS8TALeNwiB 0FmpjwtT6QeVOrt6hi1YBay6pQg/aC3LiqePkGPLlMxdIJCIsG9Pil3XoMa5z5DlAepE QgONn0OSfPjcyKKGI1MUa9S8qD0De8Essj0M1DGsuy8C0R7ylg0FpOIkGCU6ylOiwEyv aef3+M788Z3bVGvLk6jlzNXWDJqP4i7pthqXXD/QVTFuxW2+ve6k3nlsdtw72viJ7gdJ NgOE4xKjUwI7wQhociZ8zdOHs62/6ROCsyRKFhw4e7zT0rY/iuUUf7CR3fDDFJPJz0Qs FHbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1752831070; x=1753435870; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=XjU6nrqfbiw0u0TIKCSt6roZUluHkikf0/decEoYNJE=; b=JF9uvyr2FlID5xFGvLCXMxrafAeIbR9qZlOJmmV2bc+yiJJji3QiilkmsEXFVHPBhe Hq/oG1IDbyZfh6SnOqmRyryccjoMN0g4A9cAqwIBzgXSF/fuHB07rvye1NVqrzr50DWf JEJQqnKBHh/kmeESFxxG2OI7a/EQ0wF7opVVGJnBOPwnwbYOo6RI4q0yZDuNTbcMT8h1 80UmC4qBvM1pht74aKxJvlMu6e5heKRaRF/NKS6HP2b02aJCszyByKJCOEMMJzT4exAw ex+DrjxuzhSQlc53zBl0kNaW2GG/acrx99qANotE8Dh4GidXXA1G+UaJ3SxKxtDpmCk6 M4iQ== X-Forwarded-Encrypted: i=1; AJvYcCUWdtWltrmECW1JEnpgnrAIpoWSUupC0ZlsbXaTdypmHbTKq+I4S24h7LttRHVYZcj2atBwc/Yubw==@kvack.org X-Gm-Message-State: AOJu0YyLTlrX7ANqTbZ/PyjDWNIK28G9Oq0ttc8K2m5bcws1VEaRTIP2 HsCZV5oIHflb5pc+B/I5JuaXVOn2MqndF5pOaQ+mQ80uFCVStfJfl/wK X-Gm-Gg: ASbGncuTT+RXinylVlHkClnfOhR1SiUs8vSRArRBAsZMbyfCVC5s3WeCI8a22+rncpN UFVsN5xM37n2I13pufpERzKi6RxJsvAa4ZqQFJNpkxep0ndXKBK2hDq6XSaKuCXD/YKk2rmjuDv hfeRxWp3S9xdcKY4zM+NchTb0O58NI10tie36t1aVwQN2j84UWSin7OhM7DxDbHuMcBlVYgVPp4 OB/lq8whREfAQfYiTuCpTLYzZl4wDXNjdVl48j2WjsngJxKe55Q5W4fnEukhB+adtHUPXay7buh TtHO5cJHgKe5b4Xm7kHYuyVvoq1Vz90j/zdonya7veUZH6StIuv5g4dsVIeI1rjEah7mULUzZyN /JpRePN9wJn5RVf1CaKB16MgXvh+ZGb1Ears= X-Google-Smtp-Source: AGHT+IFIqad+0hlUN3zY87QsZXaNiyLAJ+x0TZ9qnNxIHZCIsq6bsPaf5QF99Ci+hSan+dVtZ2on2A== X-Received: by 2002:a17:907:990c:b0:ae6:eff6:165c with SMTP id a640c23a62f3a-aec4fc41e91mr497084166b.48.1752831069432; Fri, 18 Jul 2025 02:31:09 -0700 (PDT) Received: from ?IPV6:2620:10d:c096:325::1ac? ([2620:10d:c092:600::1:6915]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aec6c7d46ffsm88380066b.42.2025.07.18.02.31.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Jul 2025 02:31:08 -0700 (PDT) Message-ID: <1fe747ea-56ce-4418-92cb-057d989e3732@gmail.com> Date: Fri, 18 Jul 2025 10:32:38 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [Intel-wired-lan] [PATCH net-next v11 12/12] libeth: xdp: access ->pp through netmem_desc instead of page From: Pavel Begunkov To: Byungchul Park , kernel test robot Cc: willy@infradead.org, netdev@vger.kernel.org, oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org, linux-mm@kvack.org, kernel_team@skhynix.com, almasrymina@google.com, ilias.apalodimas@linaro.org, harry.yoo@oracle.com, akpm@linux-foundation.org, andrew+netdev@lunn.ch, toke@redhat.com, david@redhat.com, Liam.Howlett@oracle.com, vbabka@suse.cz, rppt@kernel.org, surenb@google.com, mhocko@suse.com, linux-rdma@vger.kernel.org, bpf@vger.kernel.org, vishal.moola@gmail.com, hannes@cmpxchg.org, ziy@nvidia.com, jackmanb@google.com, wei.fang@nxp.com, shenwei.wang@nxp.com, xiaoning.wang@nxp.com, davem@davemloft.net, edumazet@google.com, kuba@kernel.org References: <20250717070052.6358-13-byungchul@sk.com> <202507180111.jygqJHzk-lkp@intel.com> <20250718004346.GA38833@system.software.com> <20250718011407.GB38833@system.software.com> <35592824-6749-4fa4-89d9-2de9caccc695@gmail.com> Content-Language: en-US In-Reply-To: <35592824-6749-4fa4-89d9-2de9caccc695@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Stat-Signature: woqnezncg7wymhrnq9arygt86hty8pn6 X-Rspam-User: X-Rspamd-Queue-Id: 448171C000C X-Rspamd-Server: rspam02 X-HE-Tag: 1752831071-542634 X-HE-Meta: U2FsdGVkX1+SXWwkOc5Sg+foRtlREFC7FK+IwxDYiU196F1iYdPcurx6q1rVv0N45WFQi+YHJL6OFQY1VkUPwpy6fiW8f4HNfehKX9Bv1g8NrXUuGU7qafHv/gGNvZdcXTK3PMfAjyzjqogVC46LrcIm6kx7Kl3+EiBQFl+rv58l9crpc5mlyqRRIextRky0hOuGHN6+kbJxm7jI2kGRB3kAU0vvSpcy7a1+/Icd+tfyr9kIfT3/Ch5ern7bo9FcrkHf5g4XE4NWKmbMF4QXJfvcTmNW5K1cJHOrAcYXyYqieR7wokt+pv2+cEsYvdYTpZgJgkXJhsXxIPKHVDWDp14ksURNdYcWTNbvYSvf57sd3T0iB5cr/LZJZ1qwyeu6Ap4+ZYedtoFY/4qSV/++W7DCXrTO72EqLte94iw2xkfimt9zGuoTs2XqNxGrR/aMFh9gevM8mULesEDtVdP96X8j0NgScqId/Sj4nzfJeKhH8rJNoNzh44vXK0+nRK/kNbzA9eQZKcbcjhVK9IsqdX09JZ8JHLoF8uQiLk8h2WUU0Hj7COFmJ7NKadRXIr7hZI/eq8OTvCUzS7j97Bb/p/BMxdZ+wsfW1Mj6P2ALgkQxMCfWV2FPvPfQxyM7O6gZBv0yYRMJzz6udK3Fqm+320WZV+hMNMM2ee+nzmAIqSrzRtTuZUbgauCtnWCFVD4qzsljBEbUii77VWLTZI/OWA7LmAULYwAUT9Ei34oYsJS1x6cuC3slMWIhcX5iHq37svzWMOgeVHkl2E4NcRhdnRVyx2Mq1cvffn9DYWJ2w/RX5hx6rJ80rKFru2x+OSzFZ0kmnqhmK4MSrlRlxuCAAAnG1YHyskYbVPGZBBYPVTcVX5BDH+l25RJ5Fv2X0RqVEwIAW+w4x9pXc9Af+gt3t0QkkEIraBPGAX7NMpMLtJ7pw7c+5lry8IGb0POhUm3JuW0b5Von8o2kPzs8q+t sSl+Lz90 enzl2XJjGOFf9S3B2r3hsxlVm9nU69MQvyYrV/5BY59qPAKpDuWtPoGnqamvVa/q1Y86QTAWyrfytKmsAX/4HTo4Wf7ER8lHf2rhBxPkH8yuQaPqnTExfhdSDyUd884RFsyWVHcLKIYCQ/BpaRasbiN2qh3XEwhH1uY9hnvCViIGyGP0iKjDTs1s7n9XAvbPVcOYSy1oWhlaDb0FGzYxn6JRGrxiK3Sum2LGQNgCd2oIh8vZNEqz2MLVZO9yLEnNIYEh67PGGSlDMWj6Xn7NTiYyihmTMqmg58MAn2ZWOhVboV6nBwHWUA6M0iclSLHTnb45UGPJtYqwBazKqZjCgDqmcmCbXl27tyUqhLTdHDFfoVCGCWpfjNTKXm5A7NXLO/3Fmrvngv6pV9eEWPD2vC1Iy2PJye3iDpRdpA5Ovz0X5dIJ6KiT90br9zOlaoKbYp7ARbzwE1ayyBdm/XmcsuRY3rsBFOBF4psE34LnDQDBKKDYKuA1hFdNN44vMmaulWOHX3BKwY8tqdtDdXE2JJ+62c8w7bOT16bWB34iQjjujpFoFyzbJQl57CI6CuGxhQoAIK4IVQzUCmaeMXw49YyTIeqi6aw0YTmtNoWcC9Q9GtXnJL/CkD35Zc3jZimyW1KqMooRw5YKzVr/WGzC6oQOdbp8i61yohrkb X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 7/18/25 10:18, Pavel Begunkov wrote: > On 7/18/25 02:14, Byungchul Park wrote: ...>>>>     include/linux/mm.h:4176:54: note: expected 'struct page *' but argument is of type 'const struct page *' >>>>      static inline bool page_pool_page_is_pp(struct page *page) >>>>                                              ~~~~~~~~~~~~~^~~~ >>> >>> Oh.  page_pool_page_is_pp() in the mainline code already has this issue >>> that the helper cannot take const struct page * as argument. > > Probably not, and probably for wrong reasons. netmem_ref is define > as an integer, compilers cast away such const unlike const pointers. Taking a look libeth, at least at the reported spot it does page->pp->p.offset, that should be fine. And your problem is caused by the is_pp check in pp_page_to_nmdesc(). -- Pavel Begunkov