From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7B24EB64DC for ; Mon, 10 Jul 2023 03:15:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 35EFB6B0072; Sun, 9 Jul 2023 23:15:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 30E806B0074; Sun, 9 Jul 2023 23:15:46 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1FC9A6B0075; Sun, 9 Jul 2023 23:15:46 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 115596B0072 for ; Sun, 9 Jul 2023 23:15:46 -0400 (EDT) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id B683E14026B for ; Mon, 10 Jul 2023 03:15:45 +0000 (UTC) X-FDA: 80994237450.14.6711DE8 Received: from out30-119.freemail.mail.aliyun.com (out30-119.freemail.mail.aliyun.com [115.124.30.119]) by imf03.hostedemail.com (Postfix) with ESMTP id 1604520009 for ; Mon, 10 Jul 2023 03:15:42 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1688958944; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ObEavepoZV8gcXaEudhqW3Uv8ToQDImJMeP2DQm2EO8=; b=VSJ3pmYvKKrbFNXvocFqj47QvaLy9C2Q3wMfLKCfCx9ZQCKheN0+YZfjJSP0jj1+l2ePHc PQ+11LzWmhIhPaOMjIUZW44/JKkDNR9CLu/u494rU//mXjq5UhuIE5O/60a5/aoUcr9WuZ czXq/f/isLmOjZnFvulAigVvZUvbHj4= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=none; spf=pass (imf03.hostedemail.com: domain of xueshuai@linux.alibaba.com designates 115.124.30.119 as permitted sender) smtp.mailfrom=xueshuai@linux.alibaba.com; dmarc=pass (policy=none) header.from=alibaba.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1688958944; a=rsa-sha256; cv=none; b=4VpdJcynItb0jggX8yaDP3+Jtct+Tf34Eamw+ZtYDvKnCk7eBFiRicg/ci1g3R83oXQVYn pOyj/tkJuNUKSTFmyrF9+bPl+Vz/temd+Sj20pJl6yQ07Tci/GRikwWYGHigFPrVne72RF ZL7Y3c1zEEiccRCB5iAV99RubgynP8Q= X-Alimail-AntiSpam:AC=PASS;BC=-1|-1;BR=01201311R551e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=ay29a033018046059;MF=xueshuai@linux.alibaba.com;NM=1;PH=DS;RN=24;SR=0;TI=SMTPD_---0VmxC.uy_1688958934; Received: from 30.240.113.134(mailfrom:xueshuai@linux.alibaba.com fp:SMTPD_---0VmxC.uy_1688958934) by smtp.aliyun-inc.com; Mon, 10 Jul 2023 11:15:37 +0800 Message-ID: <1fe4f86e-63ce-3702-4e08-4bc0e7bb391b@linux.alibaba.com> Date: Mon, 10 Jul 2023 11:15:31 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [RESEND PATCH v7 0/2] ACPI: APEI: handle synchronous exceptions with proper si_code From: Shuai Xue To: rafael@kernel.org, wangkefeng.wang@huawei.com, tanxiaofei@huawei.com, mawupeng1@huawei.com, tony.luck@intel.com, naoya.horiguchi@nec.com Cc: linux-acpi@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, justin.he@arm.com, akpm@linux-foundation.org, ardb@kernel.org, ashish.kalra@amd.com, baolin.wang@linux.alibaba.com, bp@alien8.de, cuibixuan@linux.alibaba.com, dave.hansen@linux.intel.com, james.morse@arm.com, jarkko@kernel.org, lenb@kernel.org, linmiaohe@huawei.com, lvying6@huawei.com, xiexiuqi@huawei.com, zhuo.song@linux.alibaba.com References: <20230606074238.97166-1-xueshuai@linux.alibaba.com> Content-Language: en-US In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 1604520009 X-Rspam-User: X-Stat-Signature: wc6z7yu54ypecr6yy18rpnm7jph1nw9o X-Rspamd-Server: rspam01 X-HE-Tag: 1688958942-996788 X-HE-Meta: U2FsdGVkX18YxMbhkYkNqJKVqaPSUOurBobnVW7RLTpHXZQ9L8o7oG0Y7KIAfgDjmAxYlD0a0Yv6G1GvyKyEmnon9qLG9RhRTVETYoYUQXivo4LTmsixMb4gWO/GISCEHlMfgueqkb4bJDeBkA0nXYUtAkNXe9GDldBNT9cYJ+ax6HMmhITjBdfIAkMMOPLna7D2U6y2fh14HiEIswC6ZLQqktdvY9x+XSURnIb9OT4XN/nxAFbmSQJFOJt6lMH4/bKhs7x2DLZSdFjfQs6IQmOidwq2uFHql1YL4KVSOe6pfvfjJzAZPoWleLwqGUXv8jzn3f9HLdnIGPSeyMD6QRxeJ0HmdvpPcn2+ou0MgVdcRmzmF7Gidy7qTagqPpb62Ltz7L+ipzlbVLE8oKHHkcDSOBRNV8QsJ/sqJLBcTdXS1YxpGjN4NbXWbtf+Uo0A9X4Qcw/zUMTlsb8KZQ+XN2KFYhh/EnP1ZqZ4I21bDsWJ322qMOTf3wbgbhOSvYMgrBrUMKTzvtvibTuxtr/b1YejKNq4rOogbijbLzt1qsv7lN79Arnea34SfeU/+SM4W8NtsLoLUmGsTQzGdf3N6qB4KCthJfjkbYwSZdVUB5Kmcr82D8Ck4bOBKeZqJLjm806e/IRT0+FwXh82Sexppcss9LrJLmjE/lpE09+1SyVPdNWocky9RxUp3VEhdvRsUC8+ohcK6p7BW56oCk6lGBZgHkG7BiqcjEvZgbekoIkMCCEk+zoRRVVHA7AHxixe8L7epbAn15oXunb9Qszn9ET8VX/KrGN9QBYemRc8nASDDFMvhWChkCe0ghU0R35b3yx1TCMVfBFKTSBqtuXj3rkuCfxANgwCoqVYaDL1V79ACv6Rc+mg5rdFjvASIH5IOMMOQIwOm4FSjGfphrIYLB4LCFXcp6DNPQKbVasyDQ+kuyvbZDJ7JoqdFWsjZ/Ese+Z3ETFPYhchR6jKSz5 zO5e9Xtk blgTGLnnDXpveVbcJ9eeqce70sNa/rs4K5B+pEr2VL1asaKR6LyY/J8xbQN6IbCVxi1P/rHp6gM4eL/PVGGb+Gmmrz0ipnFCvcRJk3uT0e+Cawy0Mz2mBKKjzvOngKGyw1EJOpSK49TeYMtyvCkxx4bO8Lz68X+QdxFm9wh3UkVn8kTozs97Bj4hDteO9rl4wS1l9I+oFvndjmHWvo+9T4nkR+A== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/6/16 15:15, Shuai Xue wrote: > > > On 2023/6/6 15:42, Shuai Xue wrote: >> changes since v6: >> - add more explicty error message suggested by Xiaofei >> - pick up reviewed-by tag from Xiaofei >> - pick up internal reviewed-by tag from Baolin >> >> changes since v5 by addressing comments from Kefeng: >> - document return value of memory_failure() >> - drop redundant comments in call site of memory_failure() >> - make ghes_do_proc void and handle abnormal case within it >> - pick up reviewed-by tag from Kefeng Wang >> >> changes since v4 by addressing comments from Xiaofei: >> - do a force kill only for abnormal sync errors >> >> changes since v3 by addressing comments from Xiaofei: >> - do a force kill for abnormal memory failure error such as invalid PA, >> unexpected severity, OOM, etc >> - pcik up tested-by tag from Ma Wupeng >> >> changes since v2 by addressing comments from Naoya: >> - rename mce_task_work to sync_task_work >> - drop ACPI_HEST_NOTIFY_MCE case in is_hest_sync_notify() >> - add steps to reproduce this problem in cover letter >> >> changes since v1: >> - synchronous events by notify type >> - Link: https://lore.kernel.org/lkml/20221206153354.92394-3-xueshuai@linux.alibaba.com/ >> >> >> Shuai Xue (2): >> ACPI: APEI: set memory failure flags as MF_ACTION_REQUIRED on >> synchronous events >> ACPI: APEI: handle synchronous exceptions in task work >> >> arch/x86/kernel/cpu/mce/core.c | 9 +-- >> drivers/acpi/apei/ghes.c | 113 ++++++++++++++++++++++----------- >> include/acpi/ghes.h | 3 - >> mm/memory-failure.c | 17 +---- >> 4 files changed, 79 insertions(+), 63 deletions(-) >> > > > Hi, Rafael, > > Gentle ping. > > Are you happy to queue this patch set or anything I can do to improve it? > As @Kefeng said, this issue is met in Alibaba and Huawei products, we hope it > could be fixed ASAP. Hi Rafael, Tony, and Naoya, Gentle ping. I am sorry to see that we have missed v6.3 and v6.4 merge window since three Reviewed-by tags and one Tested-by tag. Do we still need any designated APEI reviewers Reviewed-by? Could you give me your Reviewed-by @Tony, and @Naoya if you are happy with the change. Or Please could you Ack this change if you are happy with the proposal and the change? @Rafael > > Thank you. > > Best Regards, > Shuai