From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 585CCCD37B0 for ; Mon, 18 Sep 2023 12:53:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D809D8D0015; Mon, 18 Sep 2023 08:53:31 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D30AD8D0002; Mon, 18 Sep 2023 08:53:31 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF83A8D0015; Mon, 18 Sep 2023 08:53:31 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B0A668D0002 for ; Mon, 18 Sep 2023 08:53:31 -0400 (EDT) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 7FFC6A0333 for ; Mon, 18 Sep 2023 12:53:31 +0000 (UTC) X-FDA: 81249709422.02.5556FE8 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 41DC0140004 for ; Mon, 18 Sep 2023 12:53:29 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OuszJ0JF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1695041609; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=GCf8FMEWiy9a0XpvHieMO1Zjq0SrTxWmPqBgxKH5lAk=; b=HdvRUEs1zI3tyhtncRe8gmzXbxSE/UW/SItPMcy9BiBb4qQ0SFOLSYS/n4GdJ4bYTeTg4g NHnbDwBCrORQ+CDv+Nj6clKh60/n9ENja0DYq/qFYUaPAjX+FRX/CWMEiW3KTJzjhnKl24 MLaX6rp8E9v2ZXZtmYL0WFBF4mzfVoY= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=OuszJ0JF; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf26.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1695041609; a=rsa-sha256; cv=none; b=vDLAR6c/7dbDiELWyh54igM2jPeTJtwFU3R+KhwBuuFb3Ec01kOcv0CXxUu0zNESpG2M65 UsgFxC/gJn+51eWt23qb26E7z/qEpZHVkdwQFKJx+detjhw7IvtSMNSgtJncVzDZEpbnaA YpcpGpZmWhlBj9JMM/nIF6gj06eo2eA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1695041608; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=GCf8FMEWiy9a0XpvHieMO1Zjq0SrTxWmPqBgxKH5lAk=; b=OuszJ0JFlZiPNs8lvV19oPT5tGRCKcYdyI+nvmpIesFBIjrFFEZ4X4ArtsIUJOy55+76HQ BS8OC5k0UcOSr//UVTJs+oixgsTGinkN4nchGtSkaaxU4pvjmfP/OR4DY4BcxETY0wJZ9G TvAC8IUfMdS0h/dsSP9670rXV/NBSxo= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-360-wNT2s4isN2KDPW_8sC-jyw-1; Mon, 18 Sep 2023 08:53:26 -0400 X-MC-Unique: wNT2s4isN2KDPW_8sC-jyw-1 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-40469bcd1eeso30170625e9.2 for ; Mon, 18 Sep 2023 05:53:26 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1695041605; x=1695646405; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=GCf8FMEWiy9a0XpvHieMO1Zjq0SrTxWmPqBgxKH5lAk=; b=dtzBHFYrcoCGQV7+26aYTQSRyXs8OuwR7JCo7vB8vLvWvXkQjKp5jcrp96iVPrmpu1 U4yUGc19gzIIrqabBS9yRD6/C6jvf9iFre7cqwMS4We701XjmS0mFo2D+0NZu8e+etS5 ziB36tJc3wYURmlUehCG0VokMDPEYzCI0afP0BCt5B2OJ0ILBUwziUXJUSsUGJkL7s7P OtuXmHyj5YaRE5eJoqRF0MFOR9hm2EL3yZoIYIjlNJhwKxkidVuS1QgPBNdVpJfqUhd3 2Mo6AMCM53DcSFkQ2vJ4OsjU4MfecxKiG4iWa+vVYn1m0I5bxMC9YkR0FueqMTw42pqZ b3fA== X-Gm-Message-State: AOJu0Yz5OaIbQlBqoZ0NJ6Qt1pXXoOdr9DeHshRE9YYzDpXyGikD6PpB XNq0Ahj9jeuipjBZyib3lg+Rh2vW+Nd9pIRM0KoVcQkbZlrslZzn8oqMeFDDz9ml9xt+0p/pW0D mL8cGvHY4+is= X-Received: by 2002:a05:600c:8508:b0:405:a30:151e with SMTP id gw8-20020a05600c850800b004050a30151emr2355369wmb.12.1695041605211; Mon, 18 Sep 2023 05:53:25 -0700 (PDT) X-Google-Smtp-Source: AGHT+IHiQWe+uwQOYVM4McAUlbjVx8K08AH6m92XIdHqAW+ElXXJZAluGs5FS8UBxA6Y9OqdJzu5nw== X-Received: by 2002:a05:600c:8508:b0:405:a30:151e with SMTP id gw8-20020a05600c850800b004050a30151emr2355355wmb.12.1695041604825; Mon, 18 Sep 2023 05:53:24 -0700 (PDT) Received: from ?IPV6:2003:cb:c74b:3400:ec51:7a3a:274e:cbee? (p200300cbc74b3400ec517a3a274ecbee.dip0.t-ipconnect.de. [2003:cb:c74b:3400:ec51:7a3a:274e:cbee]) by smtp.gmail.com with ESMTPSA id g13-20020a7bc4cd000000b003fc02e8ea68sm15249285wmk.13.2023.09.18.05.53.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Sep 2023 05:53:23 -0700 (PDT) Message-ID: <1fe06726-85bf-7231-f33d-d73e8cfbaa4f@redhat.com> Date: Mon, 18 Sep 2023 14:53:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: [syzbot] [mm?] WARNING in page_add_anon_rmap To: Matthew Wilcox Cc: syzbot , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com References: <0000000000008bf71d06059a2276@google.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 41DC0140004 X-Stat-Signature: 6a86y1uoit1tmi1xx9wi1gbz3j3a8pp3 X-Rspam-User: X-HE-Tag: 1695041609-732538 X-HE-Meta: U2FsdGVkX18vaBPZBZecx7FnNdinbJQTyEwspMPanqKym94zfqMOyVjVRR9KRks716Q9Vt02gelpok2HdQihlFwF2cl3MlGa7NMgSoHwwyN3SQAsA2awRZNhHjN7PzHXkPGSBymrqxi/bU9KoxudM4MhelZ6VGlANFORbIEpLK2iJYsrHrv8Qc1Q0ncpGvLEeqEYW3phai/bA35rYGgNYCsPh7gCPmQU2tGKC9qPRhYEDTVgMlxwqpDeXJFsVee3WxEHiND5NuzGOOz8fU97KGxv1ZdZmZva8PSvByoPHY7L3mBmBwwFDGV4J3NIzOphwMVXjvPTLDXOg+tjUYREy1pPje1vEEsUONZCVgUTmHwSnGyM5ZqhuxJ0aykcmKvzx2zM5+60xLsOTaHXc05yAtB6Y4GFiYSsEfw/j4Dv7c01FpI4W/mUzD3Pl9wz3OvpEVHMGv0kmCQhyvgze9OljwxVkMixtkzBx0TADUNkL5PK+OPbrPfsZu9LZFQP9ULUQaeFKQ6O7i29heau8mYWa6LyA9iBqHqs6frbZP89cT6ZOJDITjdCAI3X3q4NjWC/zVf3wwE/qe1NhcW1qvJ6RJ0y0jkbQFnnCCBQ8MrGXuOSfRwVpSAsBFPzEV16QpoJMEMHuSUo2S11cAhoSLwAv90jaHcfaCFZpUs+O5vehDTlTvGYHWLlh3Rn+mG/EWzG43HieBla8jfOUKuY3tDjHlB+8gxi5bMnVDPvnXqfcgH240dJC+CM/uEILHzWgCn6Liq1supqpkJqSTykzYVmzgIHio9t+C4YbwJB6DfkYVzP0XvYxqlTGcvW62vB3efNIWsv68UMLXcDzDXymwENzYut+7Hx9Qy27otSLyVcw/7Q7zXrWcu+MVP9lzRtzt/PgZdmj4lZYYddQLe4Vj9KTZKzWtaG3w8g0vpQxLYEPdzJUmUpmpL3dYxcllTKpflWZ98mtwlGEfrv5TWtU+P uttBLeoS sXQoSvwIK6aN9Gf8bI3JB0zfmFkVeHd6QPZS1kYUSON18Ban9nbMvWgWpBC4TaiuAAgN/BSQq9RWj8fGoZ0nDJebWj5ZlmD/wLEWUllLv/B1y6ZFaHW9pek4ta5bXcLoOpC1VI8l96CjnJolbOvRDXqD78OhhcVPaLlJgjGhrb3B1LSBHgySjuJs/CpGUq1OnDti5hvDUxR1BfJtgzbw/4sbbMMG5qD8xa6uC9NETDr8ULJGA1J3V9CTr4I1AHoZAgDp+FzE4BaS+nHBHeSfCIluBrlw3FFIEROGw9EcF0Hl+m1v2h4XsUEm1NktmZNNCTYgW7DnVhu7pxvIRMQPV859hD+d3mXZBB9jFGEHCwADEtc4FgFehDeq+ZwGqQp2tz3aPE+lRbR/8LcysnUcsz1N0TMkpYjpwQKYNotUzDxPgmfV9X3x/Xol+xCiWaM8PSyxdpeH/NBymDPN9dEenfNK6v5Y94fJoks6dxNi/PactquocVdw3+3Ac7VPgE5escBRRstpoEwdgdBfhZEVTQjrX51Zj9N7HokyqznXNUPFmJLeCRxHf9i44o+LRVQwHiY/S X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 18.09.23 14:32, Matthew Wilcox wrote: > On Mon, Sep 18, 2023 at 12:00:24PM +0200, David Hildenbrand wrote: >>> If you want syzbot to run the reproducer, reply with: >>> #syz test: git://repo/address.git branch-or-commit-hash >>> If you attach or paste a git patch, syzbot will apply it before testing. > > If I understand correctly, you have to do it like this: > > #syz test > > diff --git a/mm/rmap.c b/mm/rmap.c > index 789a2beb8b3a..f13a2927163d 100644 > --- a/mm/rmap.c > +++ b/mm/rmap.c > @@ -1249,8 +1249,10 @@ void page_add_anon_rmap(struct page *page, struct vm_area_struct *vma, > } > if (flags & RMAP_EXCLUSIVE) > SetPageAnonExclusive(page); > - VM_WARN_ON_FOLIO(page_mapcount(page) > 1 && PageAnonExclusive(page), > - folio); > + /* While PTE-mapping a THP we have a PMD and a PTE mapping. */ > + VM_WARN_ON_FOLIO((atomic_read(&page->_mapcount) > 0 || > + (folio_test_large(folio) && folio_entire_mapcount(folio) > 1)) && > + PageAnonExclusive(page), folio); > mlock_vma_folio(folio, vma, compound); > } Looks like an empty line went missing in your attempt. Let's try again for fun (I reproduced and tested myself already ;) ). #syz test diff --git a/mm/rmap.c b/mm/rmap.c index 789a2beb8b3a..f13a2927163d 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1249,8 +1249,10 @@ void page_add_anon_rmap(struct page *page, struct vm_area_struct *vma, } if (flags & RMAP_EXCLUSIVE) SetPageAnonExclusive(page); - VM_WARN_ON_FOLIO(page_mapcount(page) > 1 && PageAnonExclusive(page), - folio); + /* While PTE-mapping a THP we have a PMD and a PTE mapping. */ + VM_WARN_ON_FOLIO((atomic_read(&page->_mapcount) > 0 || + (folio_test_large(folio) && folio_entire_mapcount(folio) > 1)) && + PageAnonExclusive(page), folio); mlock_vma_folio(folio, vma, compound); } -- 2.41.0 -- Cheers, David / dhildenb