From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4A3E3C433F5 for ; Wed, 10 Nov 2021 16:46:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DD0766124D for ; Wed, 10 Nov 2021 16:46:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DD0766124D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 2B9696B0071; Wed, 10 Nov 2021 11:46:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 268A56B0072; Wed, 10 Nov 2021 11:46:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 130BB6B0073; Wed, 10 Nov 2021 11:46:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0185.hostedemail.com [216.40.44.185]) by kanga.kvack.org (Postfix) with ESMTP id 056476B0071 for ; Wed, 10 Nov 2021 11:46:00 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id C0373818B834 for ; Wed, 10 Nov 2021 16:45:59 +0000 (UTC) X-FDA: 78793597638.07.925EB15 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by imf19.hostedemail.com (Postfix) with ESMTP id C1923B0000BD for ; Wed, 10 Nov 2021 16:45:50 +0000 (UTC) Received: by mail.kernel.org (Postfix) with ESMTPSA id 3043161248; Wed, 10 Nov 2021 16:45:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1636562758; bh=2rKwlyZ/ynAX3ujGshIRvU/bHH1kMmrQsdaEhK7qGGU=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=mo9CR/krq5MNRIVRB638Ym/lZMkpqiYdpC64Dwx9oQKcTiEWBo6iQ81j15GN6XOvZ FGvv2NsdcDHtHtJWfRdV8F+ReKl19MWjJKYlFvJmAsBcmqpsNu2W1Yx5YavvQpjseM 56MkZCSxcr8gRefguukzuS0D3harUSgTJcugLdEHgAo0fyPyeWTHklmmkZ1POa+d1l TmSb5BJCRcEYVlGR1uzSEu3YdDlohZ0x6b0dovukDugXM+YRE/1jo0CC6w4ODmiYlA pKHgQQPNN+KjnntlpcJ35qdu9Cz/Y+NestzaNwq6hRHpBmDNnbUBrql9jJMEO36T04 bB9usziDKB6Aw== Message-ID: <1fd2d97b-7c83-3a82-ada3-46ec5025c3b1@kernel.org> Date: Wed, 10 Nov 2021 18:45:53 +0200 MIME-Version: 1.0 Subject: Re: [RFC] psi: Add additional PSI counters for each type of memory pressure Content-Language: en-US To: Peter Zijlstra , Georgi Djakov Cc: hannes@cmpxchg.org, vincent.guittot@linaro.org, juri.lelli@redhat.com, mingo@redhat.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, mhocko@kernel.org, vdavydov.dev@gmail.com, tj@kernel.org, axboe@kernel.dk, cgroups@vger.kernel.org, linux-block@vger.kernel.org, akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <1636558597-248294-1-git-send-email-quic_c_gdjako@quicinc.com> <20211110161402.GB174703@worktop.programming.kicks-ass.net> From: Georgi Djakov In-Reply-To: <20211110161402.GB174703@worktop.programming.kicks-ass.net> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: C1923B0000BD X-Stat-Signature: zx94mez3sskrcu5pdrs4czyiyd3hgx3q Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="mo9CR/kr"; spf=pass (imf19.hostedemail.com: domain of djakov@kernel.org designates 198.145.29.99 as permitted sender) smtp.mailfrom=djakov@kernel.org; dmarc=pass (policy=none) header.from=kernel.org X-HE-Tag: 1636562750-967759 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 10.11.21 18:14, Peter Zijlstra wrote: > On Wed, Nov 10, 2021 at 07:36:37AM -0800, Georgi Djakov wrote: >> @@ -21,7 +19,18 @@ enum psi_task_count { >> * don't have to special case any state tracking for it. >> */ >> NR_ONCPU, >> - NR_PSI_TASK_COUNTS = 4, >> + NR_BLK_CGROUP_THROTTLE, >> + NR_BIO, >> + NR_COMPACTION, >> + NR_THRASHING, >> + NR_CGROUP_RECLAIM_HIGH, >> + NR_CGROUP_RECLAIM_HIGH_SLEEP, >> + NR_CGROUP_TRY_CHARGE, >> + NR_DIRECT_COMPACTION, >> + NR_DIRECT_RECLAIM, >> + NR_READ_SWAPPAGE, >> + NR_KSWAPD, >> + NR_PSI_TASK_COUNTS = 16, >> }; >> > >> @@ -51,9 +80,20 @@ enum psi_states { >> PSI_MEM_FULL, >> PSI_CPU_SOME, >> PSI_CPU_FULL, >> + PSI_BLK_CGROUP_THROTTLE, >> + PSI_BIO, >> + PSI_COMPACTION, >> + PSI_THRASHING, >> + PSI_CGROUP_RECLAIM_HIGH, >> + PSI_CGROUP_RECLAIM_HIGH_SLEEP, >> + PSI_CGROUP_TRY_CHARGE, >> + PSI_DIRECT_COMPACTION, >> + PSI_DIRECT_RECLAIM, >> + PSI_READ_SWAPPAGE, >> + PSI_KSWAPD, >> /* Only per-CPU, to weigh the CPU in the global average: */ >> PSI_NONIDLE, >> - NR_PSI_STATES = 7, >> + NR_PSI_STATES = 18, >> }; > > Have you considered what this does to psi_group_cpu's size and layout > and the impact thereof on performance? Thanks, i will definitely add some numbers in case there are no other major arguments against this RFC patch. BR, Georgi