From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A843C48285 for ; Wed, 31 Jan 2024 05:59:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 66ADD6B0071; Wed, 31 Jan 2024 00:59:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FD486B0074; Wed, 31 Jan 2024 00:59:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4BAD46B0075; Wed, 31 Jan 2024 00:59:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 38EDE6B0071 for ; Wed, 31 Jan 2024 00:59:57 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id F08231201F8 for ; Wed, 31 Jan 2024 05:59:56 +0000 (UTC) X-FDA: 81738555192.16.1EE6DF3 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf28.hostedemail.com (Postfix) with ESMTP id C65D5C0019 for ; Wed, 31 Jan 2024 05:59:54 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf28.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706680795; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uAS0A2Q/UWfDa2G3Bb4CijCiVlOpzDu1YJyqujeIA/M=; b=GFHZeEJ7K/IlVwfFvj2pF64wiRK1Lkq4HnZ4g8Gi53bahTFro9AIEbPTNLct07fzE3mSmH Lz0AAstTA5fTGNAskM2CRXUNu+cNDTCc5ALa1inQPvB0DZsQp4G440D1760Bwz+r4BkJo4 S7xUYkg2BpyUuaLrrSi502Lqlj2WM1I= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=none; dmarc=pass (policy=none) header.from=arm.com; spf=pass (imf28.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706680795; a=rsa-sha256; cv=none; b=UAI6QpN//dn6hccceM8nwQnJSgd2y5BNZlW36NI6QSsAsE+08Q/oKTFxdutA5VJEs23R7/ XNH6mVyP03jkMqPpVOLWnYAg8xydX+cbea04zMPhf+D/hHZDM+9LBzE/1tDgJ+zelJMQws 6pRfgvaJWNLTHrcXFhNpmnsEp+lHZ8g= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 0EAFADA7; Tue, 30 Jan 2024 22:00:37 -0800 (PST) Received: from [10.163.41.195] (unknown [10.163.41.195]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id B16933F738; Tue, 30 Jan 2024 21:59:41 -0800 (PST) Message-ID: <1fcf38b4-b0ff-40ec-8ac0-730c8bfd57ff@arm.com> Date: Wed, 31 Jan 2024 11:29:39 +0530 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC v3 07/35] mm: cma: Add CMA_RELEASE_{SUCCESS,FAIL} events Content-Language: en-US To: Alexandru Elisei Cc: catalin.marinas@arm.com, will@kernel.org, oliver.upton@linux.dev, maz@kernel.org, james.morse@arm.com, suzuki.poulose@arm.com, yuzenghui@huawei.com, arnd@arndb.de, akpm@linux-foundation.org, mingo@redhat.com, peterz@infradead.org, juri.lelli@redhat.com, vincent.guittot@linaro.org, dietmar.eggemann@arm.com, rostedt@goodmis.org, bsegall@google.com, mgorman@suse.de, bristot@redhat.com, vschneid@redhat.com, mhiramat@kernel.org, rppt@kernel.org, hughd@google.com, pcc@google.com, steven.price@arm.com, vincenzo.frascino@arm.com, david@redhat.com, eugenis@google.com, kcc@google.com, hyesoo.yu@samsung.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, kvmarm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-arch@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org References: <20240125164256.4147-1-alexandru.elisei@arm.com> <20240125164256.4147-8-alexandru.elisei@arm.com> <545bb7bd-31c7-4166-9f81-778b82ece6d4@arm.com> From: Anshuman Khandual In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C65D5C0019 X-Stat-Signature: xt5mrq45r9stz6orzdybf5o6gwwiexco X-HE-Tag: 1706680794-963186 X-HE-Meta: U2FsdGVkX19vDXu4LiUGI+hZGhxI/4dlwlJnwuvkHkO+ivRbON36VSl+Rubmw2p27XIHkH/gbUErIJtqIKPISMIh3i2tFrOM3WOux7iGkK9bUeYSkpZGDeChDdETGMHwDi0YT5nqG6r1mBqhhLjoax/qe4MoX8hwUGJ0ddI3uTe87NglSwxEi5jB3PUyIEe+KNcd1Xd5SUTd0/rf2mI2cvAT5bpFbdJHPQUf4E8+1cOSz4QnywfJwJyjLa4jE5WGQMH3HIg0R549BasBSxHe084jHRN8Bsowa87EScFgf/e6KdHqYJ7fK9ONK8sHblk25lcsAxMLRAOVi9IFgKEPhwYZqvx4G6rzpvJRr0y0USViNyP84p5XHRH0u7SrDEmCXiTAiOyx7s+wmn84HsXuPZ0E5q8JMCnwP8vDxYpOORYHe8xo1jNqMpOx8SBXhlpXjYFqSwgXjg5XYW9E7tuikqOENbyFQQWZ2UxQ+VhTcNRHkoQ0GLdIT9nGqfduJ0E2MTsJqUJsT0vVpPbMr86pP7g5b5Oivsq1uFGoePibxQz102L78N3mshP8ge/bkq2ouCJgyfYpqkcaCt/iorG4xgNS8d3heFhy12Bz6bnuBP6Y721tKhW0UuxVvU+ZZmPBJ2IiSApS73XIjVhFdnUmqF0CWzy5pdaLAM1CIzPmBNf9OP14BpByOhoNl3D11BLSmOcShrFAjmkE4HkstcCWxJIzqWrJYLRgIagf4oyqhidTrKkd3RTLfVSaSAqCIC3IJMSX7v8ERazUoHiIz5XN9a+Z5MGrfqaqwc+HbjCh6DPUx7DBzjAEYq97IMt3xAh/Yk59J1t0CyhPeTv2f4kqLSk/XBI9MtF+P58mjRtAhyCFBVwyrjKM9OnCQZgdncnPOoMVf2s8ldh+sTDYM+Jw7SlIKrZtXCnlCjOgv17kTC0+wVQDeWRsc+2sAHj5dez31mZlpL3nTemzAjXn4uG dB5G9pQq D9GD0SF/syOJNOAyuqGq67jazbnLTVSnNJKcKLaMAuxUTsedoy/Dlo7cwi9hqRhPDeCpHN/xBgXW5V/zKuD9ZdrSAOFl2rTzsHVYd7ODcnkN+vwI6SOuCgqUfy/fH9RPagk21S5DemYV7CVzWBtT4ygEB+eWolR0zT39xNehL+f+Z3eoze3cZ3QIchfaPznxRMS09 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 1/29/24 17:23, Alexandru Elisei wrote: > Hi, > > On Mon, Jan 29, 2024 at 03:01:24PM +0530, Anshuman Khandual wrote: >> >> On 1/25/24 22:12, Alexandru Elisei wrote: >>> Similar to the two events that relate to CMA allocations, add the >>> CMA_RELEASE_SUCCESS and CMA_RELEASE_FAIL events that count when CMA pages >>> are freed. >> How is this is going to be beneficial towards analyzing CMA alloc/release >> behaviour - particularly with respect to this series. OR just adding this >> from parity perspective with CMA alloc side counters ? Regardless this >> CMA change too could be discussed separately. > Added for parity and because it's useful for this series (see my reply to > the previous patch where I discuss how I've used the counters). As mentioned earlier, a new CONFIG_CMA_SYSFS element 'cma->nr_freed_pages' could be instrumented in cma_release()'s success path for this purpose. But again the failure path is not of much value as it could only happen when there is an invalid input from the caller i.e when cma_pages_valid() check fails.