From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79746C7EE2F for ; Thu, 2 Mar 2023 07:57:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E57FB6B0078; Thu, 2 Mar 2023 02:57:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E09A96B007B; Thu, 2 Mar 2023 02:57:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CCEE06B007D; Thu, 2 Mar 2023 02:57:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id BD2CF6B0078 for ; Thu, 2 Mar 2023 02:57:18 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 8D6531C5B23 for ; Thu, 2 Mar 2023 07:57:18 +0000 (UTC) X-FDA: 80523202956.10.218C5AA Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf08.hostedemail.com (Postfix) with ESMTP id 6A9C616001B for ; Thu, 2 Mar 2023 07:57:16 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1677743836; a=rsa-sha256; cv=none; b=zVJ+PTOu7aJ8+aX/ypox2ghbE3hnSDOzNeQD/QjZA0thOO54D+RvWoWDvOIKLfDWdZLK3G eBggwVW5I16Hs6iBmE/GQ2/esD99YRzwIp+nIh0MFMoP1Ihj7y08hi9jMd6MwoRmv9jNRi w0ROhGE5mpD8xhPQGcyQWcpANnPkXuI= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of anshuman.khandual@arm.com designates 217.140.110.172 as permitted sender) smtp.mailfrom=anshuman.khandual@arm.com; dmarc=pass (policy=none) header.from=arm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1677743836; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Hygs6vGRFdS0l6Kh6cqNPckKAlFCSicw48xc5A8x508=; b=nDbuMjswudoPppXTeS87SBiDWMnE6uokRoXomi8v7B7PyUK81lepDMVNhod/uc7yi1bJS1 6mIj6DUGvGviNYQXVtbdsO1c5ffaOA8XqwgfU3wgq7NFiKuj96186IIZK2UwIqKYAZozGU AuyAEDciyFBWHjNoaG4Vr/ICUKbZUxI= Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 24BF71FB; Wed, 1 Mar 2023 23:57:57 -0800 (PST) Received: from [10.162.41.9] (unknown [10.162.41.9]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 4FC573F587; Wed, 1 Mar 2023 23:57:11 -0800 (PST) Message-ID: <1fa898da-efdf-cf39-4be9-1d0354d3fa41@arm.com> Date: Thu, 2 Mar 2023 13:27:08 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH] mm/debug_vm_pgtable: Replace pte_mkhuge() with arch_make_huge_pte() Content-Language: en-US To: Christophe Leroy , "linux-mm@kvack.org" Cc: "david@redhat.com" , "mike.kravetz@oracle.com" , Jonathan Corbet , Andrew Morton , "Mike Rapoport (IBM)" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" References: <20230302031833.360679-1-anshuman.khandual@arm.com> <94473cc4-f84f-d42d-2bd1-b6389d8c9ab3@csgroup.eu> From: Anshuman Khandual In-Reply-To: <94473cc4-f84f-d42d-2bd1-b6389d8c9ab3@csgroup.eu> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 6A9C616001B X-Rspamd-Server: rspam01 X-Stat-Signature: 3zstd6qp7o9ey4zrnqu9yupjo7fimb3z X-HE-Tag: 1677743836-321450 X-HE-Meta: U2FsdGVkX1+3O9m8akOQ8130x4ioLRmoh6AR+zrOrGlvLONJaiOtAGLBNGa9O4JO/QjIQD0xYmr/goiA5uFwMjCp+e8Gq1Ma9zOtro87UPiIpRdBa1GTFssC15sv7+yxIxxaG51JDzV88sUu81HW9092dHuyn7YI6Px/v+no7uAQWyapvmyvocXIeTmARIQwXRNl7IJfNNo00O9bqNR6sr9jtZytIPf7P0b2LEdiH3l6orA6XthYke7RQ3vhdK5D0gkuvXXDKzz3pQZqRJ0FgWb4lPJuzjZ3Jdryi5Qa8l4pMD1UfQZvvK/MjAkHgsY4mzvQK4avYJYGZa1MKJlKKYS7AdNYD8tcYNDXfeYH0/5W7Vjp+YrV5VLqV/4R4Yr/bXPzZXmt1US54O2zrhSDKELOpt6SB17lHj0MJ35WpmBQYwGAKtjQr81vlf5lyLjBfCFZcwU/56lL7I4e8jjIh0bvWT+ZkuooGWS3FjOnbkoFtVwEMmqy3cy8TWQTF+sOg4ctngj7cdcgxRFOrM3bUE6gnYN5BrowZC9ImbpOMhK4P8+BDplRCB+Ytp0E50Dts/lmNN4lJ2JzBvRlM3SKMAtqRaoHSyVGzmK8LKPhTsc27HfQpx0bauZ6zHVC07Wo/hmbRSfBHGVFTTH8ivMyPqMrLBfHZxwdE/g2GT1Z4ENuLgjpgPVINiHDCQnmfyAsYqlhkrGb1Y2x8OgFWzQ0hOAlNdzvY9xRVnkr+HsKsxQmGImMyWFTwcaNcqT4jArf3UGhlPrMx55ttiQV+HGlDHxidEriVRw2i+CIYmZo0nuIObGsEd6rBrCny1B4m5WNLMr6PCyQ2E9KYY4frTRyU5762qEOYnOHd2chgNvAp3qY4WoG21vX83QQ6Vu3PVZBRQWpHj1VpaVQX1jwIzZp5J/gc1lMSYsyfOpZDMLJ5ez3J9ZH+GCXof33lcjTb9+olyHylVvZK5loOvamoPT 9jvQ6CuN ZmJ006NYaRUXMVQVLs3re5fpOkKs8blmEBcPZrlLuQn0sjZxFRZMATN72LFotOAbOaeS5gZpb+3W6INxSr6xB5rbZwgdjfWWNc+N4tFWVvIqP4oLXOrMe9MHsugvSkpsIXYpjaT0TmOTv7mcZifOL7Zn767JSYMfzT3EHwzqqr+xqAM/gaUG9L6ZSFAM8OcGZATUJI43JBRF9ymEqLY1kBU4UTsrJlFDqo0rlfXAb+F7xI63BiyaRHkFML1sqKo9r53suo2s59y8IVpgWHYSvlZfU7gqDt8JWIIfTKp5N260jGEN7KFEGiCLmnVQ2MTAP8vcXt6qG7xE7fNBHlqC3RE12ASJoBC/4DoSqxdVPZ2WgXn78zLn/sPgAUzoe1tR97fJvvZ/s1/61MHRWIIcnNIkm8+Tr34mBQXpONSx+UWpwtqv4UKkMd6HVmaopyj+LMeuqxdvJ1SMEfMi723lLnOx/yjvIWj62X0Fvi9SmUpJ5z7mypRguHIQYUBV6XYKf/Vc39jnhPMTyS4xZB8gcyNy0rgQGdMWe2icYezVJiWV4c4/a17wZs+r+ZaqBKlX9m13K X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 3/2/23 12:31, Christophe Leroy wrote: > > > Le 02/03/2023 à 04:18, Anshuman Khandual a écrit : >> Since the following commit arch_make_huge_pte() should be used directly in >> generic memory subsystem as a platform provided page table helper, instead >> of pte_mkhuge(). Change hugetlb_basic_tests() to call arch_make_huge_pte() >> directly, and update its relevant documentation entry as required. >> >> 'commit 16785bd77431 ("mm: merge pte_mkhuge() call into arch_make_huge_pte()")' >> >> Cc: Jonathan Corbet >> Cc: Andrew Morton >> Cc: "Mike Rapoport (IBM)" >> Cc: linux-doc@vger.kernel.org >> Cc: linux-kernel@vger.kernel.org >> Cc: linux-mm@kvack.org >> Reported-by: Christophe Leroy >> Link: https://lore.kernel.org/all/1ea45095-0926-a56a-a273-816709e9075e@csgroup.eu/ >> Signed-off-by: Anshuman Khandual >> --- >> This applies on latest mainline. >> >> Documentation/mm/arch_pgtable_helpers.rst | 2 +- >> mm/debug_vm_pgtable.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/mm/arch_pgtable_helpers.rst b/Documentation/mm/arch_pgtable_helpers.rst >> index 30d9a09f01f4..af3891f895b0 100644 >> --- a/Documentation/mm/arch_pgtable_helpers.rst >> +++ b/Documentation/mm/arch_pgtable_helpers.rst >> @@ -214,7 +214,7 @@ HugeTLB Page Table Helpers >> +---------------------------+--------------------------------------------------+ >> | pte_huge | Tests a HugeTLB | >> +---------------------------+--------------------------------------------------+ >> -| pte_mkhuge | Creates a HugeTLB | >> +| arch_make_huge_pte | Creates a HugeTLB | >> +---------------------------+--------------------------------------------------+ >> | huge_pte_dirty | Tests a dirty HugeTLB | >> +---------------------------+--------------------------------------------------+ >> diff --git a/mm/debug_vm_pgtable.c b/mm/debug_vm_pgtable.c >> index af59cc7bd307..92bed5bd5879 100644 >> --- a/mm/debug_vm_pgtable.c >> +++ b/mm/debug_vm_pgtable.c >> @@ -934,7 +934,7 @@ static void __init hugetlb_basic_tests(struct pgtable_debug_args *args) >> #ifdef CONFIG_ARCH_WANT_GENERAL_HUGETLB >> pte = pfn_pte(args->fixed_pmd_pfn, args->page_prot); >> >> - WARN_ON(!pte_huge(pte_mkhuge(pte))); >> + WARN_ON(!pte_huge(arch_make_huge_pte(pte))); > > Did you build it ? Ahh bad ! Built on arm64 which does not subscribe ARCH_WANT_GENERAL_HUGETLB. > > arch_make_huge_pte() need 3 arguments. Could call it with constants such as PMD_SHIFT and standard vm_flags without involving real arg based values (as they are not initialized for HugeTLB). But wondering if platform arch_make_huge_pte() implementation might complain. arch_make_huge_pte(pte, PMD_SHIFT, VM_READ | VM_WRITE)