From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 782BDC021A1 for ; Tue, 11 Feb 2025 13:49:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D54296B0089; Tue, 11 Feb 2025 08:49:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D03836B008C; Tue, 11 Feb 2025 08:49:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BA3E4280001; Tue, 11 Feb 2025 08:49:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 9DED96B0089 for ; Tue, 11 Feb 2025 08:49:22 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 15B5F1C5728 for ; Tue, 11 Feb 2025 13:49:22 +0000 (UTC) X-FDA: 83107795764.02.212BB1F Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf14.hostedemail.com (Postfix) with ESMTP id 94CC5100010 for ; Tue, 11 Feb 2025 13:49:19 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="VQuiU5o/"; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1739281759; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Z04xieTVSSjqGVmSfNHpRvbeVxnt/OPpjlijd1d2zec=; b=Bi7zP5zOB9EVBe4fffREXN0nOoVUZ2EHlF34bnoEUAv+JgG1pLkr+NigEgGA+rmvrMGqsb 2u0tdqNcmIkIzL+1axJEEeN2cHiM88xoZdM7DaehazH62YMmf7GuxznI0L9Zo63wwIIsu+ VCcsOochIN2Mxk8d1+i1UDLRup0g8aE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="VQuiU5o/"; spf=pass (imf14.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1739281759; a=rsa-sha256; cv=none; b=8R5TY6SuNM3UHhCBCVl6qt+wSycg/V708QnIX2UNWnY+5e4DK4GBcZy+VNK0MMTO3MyIzD 2u4QZy45NTzeG3ZOTXg6K8wEuZ0WPExKJ/3GCYqsnfWclipxYEsq6BIYnEy19msFJ+GcS5 FuafYXPcoTqtNhZqcXTiW0UUw6FTwuQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739281759; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=Z04xieTVSSjqGVmSfNHpRvbeVxnt/OPpjlijd1d2zec=; b=VQuiU5o/1Q7T9KM5yd0Zkm7NOlArzU+GxeDJZP1kBeH/sJNRk//6aB2EapDRzIpg9MTCPp zR/9X1ZqaArM4fhzD5wMwyVaVS0+C7mXRdt56NZIK2kav4FVDGybAAxFiohdKdC1JkfWM9 c+UGONm71xmqhGmJt2mKSq/wHOs2AU0= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-211-9Ws4yn0yNvGbs9qHpW7l1g-1; Tue, 11 Feb 2025 08:49:17 -0500 X-MC-Unique: 9Ws4yn0yNvGbs9qHpW7l1g-1 X-Mimecast-MFC-AGG-ID: 9Ws4yn0yNvGbs9qHpW7l1g Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43935bcec0aso23440925e9.3 for ; Tue, 11 Feb 2025 05:49:17 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739281756; x=1739886556; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=Z04xieTVSSjqGVmSfNHpRvbeVxnt/OPpjlijd1d2zec=; b=Y/97zYndj+mDG9UNhAtU7A/kk8a2V/58OulKujoqq3o6Dn+9TRVybsXaSbin0xQCtI qSAqldKroU/OjJnaAMWbrcrFXYMTLzbUt+fwIDeBya8T4W5iiGpcurhKnJ2R+zxaNNns aTGF9pT1+zKqGH5M7iIZsGdr1mahz0WIFVylb8UazepgH1NPGM1NF1GN7i31QyIG8jj6 kqwMeTYaz26/PCwvbTDfo+1t0yMnPgsrYqjHfszkFSYdFfE5lugiQTVXZ8C6YB+Gd4f2 G8XZxAFSHj4QMSlPUG7RECCkvnLIz6KqxFqJghJtMIqIqEvCfnAmKUwpL22o0m2yU2yU 68Tg== X-Gm-Message-State: AOJu0Yx3V3btIFagJqu/PzfbkroW719Nn9toDk0jIIsPwzF6/4list9N qKHe477BT20FXehgAkmHDZt0v4+GSNExABraUfIJAAYCn6hcNxVj4D+ymJJ8JQZGsSqEyxRVqsV QxcGFJeQkmQsJyxGyKbHLVKM/gXhLQstku7MKcojbHeV2UJqS X-Gm-Gg: ASbGnctFqZTaX76u85s/TBO7QYBLVkEpujBx35AgODSgVLvv9DY2pt9Um2SdRy3V6GG leDGP1n5YJkPYFXjPSZbQChae3+CK8SkJL4rU7e3aJP4/KMtLfb6HLFWZGtx3NTD7lqymc0C0sd 3toX2L+tgXMPQ3e0xs1Wmr7wfJcHFfF9vAGIAjKepvQNNkcc8tWc6tw83svrCCfu00Ng+OrtG7u nsDFqtmMiVIK6G0gpyktiWuunhZ4PgQlx0bFXNR2P9RuARPcJJMvAsN7nvEW3LBXKFjy2owtGeo jFvDjHvNwIwV0K9Jetqrq9MoEWjJnX8cArlr5yY= X-Received: by 2002:a05:600c:3494:b0:439:43b1:e60 with SMTP id 5b1f17b1804b1-43943b1108bmr86923705e9.17.1739281756430; Tue, 11 Feb 2025 05:49:16 -0800 (PST) X-Google-Smtp-Source: AGHT+IEka9WjkWk9QCTideeilCnodZcw9Xoe1YTaw59e/8HoaZM5k1CJr4YcGufrqrhch2iJbw1nNQ== X-Received: by 2002:a05:600c:3494:b0:439:43b1:e60 with SMTP id 5b1f17b1804b1-43943b1108bmr86923485e9.17.1739281756082; Tue, 11 Feb 2025 05:49:16 -0800 (PST) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4394127afcbsm74374905e9.23.2025.02.11.05.49.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 11 Feb 2025 05:49:15 -0800 (PST) Message-ID: <1f9f5fb4-27cd-4981-aa60-789a33376598@redhat.com> Date: Tue, 11 Feb 2025 14:49:13 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm: hugetlb: avoid fallback for specific node allocation of 1G pages To: Luiz Capitulino , linux-kernel@vger.kernel.org, yaozhenguo1@gmail.com, muchun.song@linux.dev Cc: linux-mm@kvack.org, akpm@linux-foundation.org, rppt@kernel.org References: <20250211034856.629371-1-luizcap@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250211034856.629371-1-luizcap@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 5n55WMR4rsPQ3-5Ij3G2rOoKGzg2TRb9mnv6ERT8_0A_1739281756 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 94CC5100010 X-Stat-Signature: 7g4gjb74w4g1cqjqfww1h18pc4cfewnx X-Rspam-User: X-Rspamd-Server: rspam01 X-HE-Tag: 1739281759-225160 X-HE-Meta: U2FsdGVkX1/k9kTPm/F9PBE7ZZHisVZ9lbLfSO9DLJ8w4j21y0VzvU1Tbb2TZ4/T6hfvIHccsOsma3ToimtD6JFxxoMNsDYWRPn0TycJgPmqz5YGZkw4d9rxR3/kL/q9NZFcxDVRJaJJh3k1sBtr/BLAQrSN6B1U/WALx7u5D04r27urp49KoQq+2UuN2r4Ex1ujHxDQT+ofRHW7vw6QJgbbr9XTH9RmTXdquSeqW9PyTZ3zLicyb79nd94GGVeGkDzj8pCG+EIw+Urb89R6jF4KxpCsHp7nnV+YdJontd0oTwHrvBfWAVT9WZ0BoJdOKYDT15IYQF3qkUggpGVAJKj7bNutkWog5TeHvf1RhhPlu8bLNDMhAEAS84NWmlCTCCy3TYTCIP1lLDGFGqlK3AaTppXl5YiaEZtif1p8BT66X8jpkXYB2K7caeZ2KV7oYxN+wfEjEWNsIQDYpnbvYBWx9MIj19FgDSBP+FkPiFj/uPxOGljuNE9PsNr+WIreP4r+HUkcaxEc8TYy5S6SqUCtzIQjFo7ekMbbBgGSGdiNv8SRxMxad+Z0uLj597n0UZg1/igYnYUHjVKyFmmgeBmdsQIoYVS+GyOhVzrVVYJYRSY9PWDdeobpijfqzxior28mNOnIrvylZH3PcY1jnNCdlcmPWX3A6UPgOp69rkv88N6IHhpoLY8XnNUFd9HxjWr3DyJAPapZDvLcz1rVICxu5+OCqvhMERsOJ2Ud2hD70S4UcfQP3W5TGAZiNSUZ7RF+7MN2Cjr3gztEXU9vgcOtcFXUom6lu4tp6N9fk77dtEQVim4F0OMRjQAHOKLp5kjXNfTAcz66a9lCf2mgcGqd20O0PRNT+Wmn2H2zvMeea/GdUTsheGBln3kXlQafK3eLeQwPkmopod4WGhaNcFJO0L/bEdl2Qr/QFny9fxNhyYLg6VXjCZGCwWba2Buy7k+7JNh8oaTnobGQRa+ XccknGm2 DU/CUlTCXZPbVMAkG+BQJpMHz3Q7iIcnCgeEXnpp4xSLrXZgvtJHSp0MJwfKyK0iSQ1QCMeY8Erva+TnbKMFxXWCEwEXt7cMxB3auojHxEKlgwd8zjjtPg9UdeR/jtmUX12dqpObRiXtI224dmco1BqICOlVzVs7r2Q9evDB/gwFNqlvuGzQ3ngIgMCl9BvX1RSONHQWnaoj9YDkJLaZWRzc7Aj9+CrpMghogCgrveZqAktpVWUmUIC3wf35U4PIW2nnLpeS8NFCcw0yFXjjndOJSXRbjI7/oGQjfIRQFejl6k16jsrJ53oDzDIiY6Dr4Zntoj9Fl7Qxq+8NqbH5QgF5tFLfI04cupqqth64VuFBJaw+VMoBrQ0tqLEdnLtr02ToxI1ie6wWIZ5YpniiLx6uqrUtxu00AjVGFMOpE4sgzi5eaTgjfvFOj2Vj1AXrskLqI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.02.25 04:48, Luiz Capitulino wrote: > When using the HugeTLB kernel command-line to allocate 1G pages from > a specific node, such as: > > default_hugepagesz=1G hugepages=1:1 > > If node 1 happens to not have enough memory for the requested number of > 1G pages, the allocation falls back to other nodes. A quick way to > reproduce this is by creating a KVM guest with a memory-less node and > trying to allocate 1 1G page from it. Instead of failing, the allocation > will fallback to other nodes. > > This defeats the purpose of node specific allocation. Also, specific > node allocation for 2M pages don't have this behavior: the allocation > will just fail for the pages it can't satisfy. > > This issue happens because HugeTLB calls memblock_alloc_try_nid_raw() > for 1G boot-time allocation as this function falls back to other nodes > if the allocation can't be satisfied. Use memblock_alloc_exact_nid_raw() > instead, which ensures that the allocation will only be satisfied from > the specified node. > > Fixes: b5389086ad7b ("hugetlbfs: extend the definition of hugepages parameter to support node allocation") > > Signed-off-by: Luiz Capitulino > --- > mm/hugetlb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/hugetlb.c b/mm/hugetlb.c > index 65068671e460..163190e89ea1 100644 > --- a/mm/hugetlb.c > +++ b/mm/hugetlb.c > @@ -3145,7 +3145,7 @@ int __alloc_bootmem_huge_page(struct hstate *h, int nid) > > /* do node specific alloc */ > if (nid != NUMA_NO_NODE) { > - m = memblock_alloc_try_nid_raw(huge_page_size(h), huge_page_size(h), > + m = memblock_alloc_exact_nid_raw(huge_page_size(h), huge_page_size(h), > 0, MEMBLOCK_ALLOC_ACCESSIBLE, nid); > if (!m) > return 0; Yeah, documentation says "The node format specifies the number of huge pages to allocate on specific nodes." Likely the patch simply copied the memblock_alloc_try_nid_raw() call; memblock_alloc_exact_nid_raw() seems to be the right thing to do Acked-by: David Hildenbrand -- Cheers, David / dhildenb