From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84DDDC54798 for ; Sat, 2 Mar 2024 07:31:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B41916B009B; Sat, 2 Mar 2024 02:31:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AF2346B009C; Sat, 2 Mar 2024 02:31:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9B9AF6B009D; Sat, 2 Mar 2024 02:31:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8D3266B009B for ; Sat, 2 Mar 2024 02:31:20 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 29164140631 for ; Sat, 2 Mar 2024 07:31:20 +0000 (UTC) X-FDA: 81851278320.02.EE4C6BB Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) by imf16.hostedemail.com (Postfix) with ESMTP id 8D63F180008 for ; Sat, 2 Mar 2024 07:31:17 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BX7R7NBm; spf=none (imf16.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.16) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1709364678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3OyQZhY3GOUcBdm82i+rIH27tpp8k3SI2BUo/dhEP38=; b=ibrAzt46Qba43UKPBT/EfoD9/mJJBNcNEa7D+LCzvLUTZ1yEHW7mzx1xCwe15XNtC3d6sU zzj94CLM/w6pSy28ohMhWcPRZFAvptWO7oKIlkOSMC3e4G/AEIkhBmu07c48ZOPL1sO5WY 9y6d+sLzNZcAANI5DIH5diH/NI7dLj4= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=BX7R7NBm; spf=none (imf16.hostedemail.com: domain of binbin.wu@linux.intel.com has no SPF policy when checking 198.175.65.16) smtp.mailfrom=binbin.wu@linux.intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1709364678; a=rsa-sha256; cv=none; b=Tbbhr4LHvyvbPkqB4DA+f+zWFxilVeTQba4OexcP5izvLMPL5rLMIu0giO3J4dukdTCVMQ zMcY4ocm3+nHUUVoc/17LwDbh3TCEMq6gScaqIgd4u2P0BwyHiwV7VO0/e/Xr6yMA4wEte NVD7dyyrfCpfX3rzqRZmOXT5P2mT/6I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709364678; x=1740900678; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=TN3SmDf8ga5MSo8DFjBXH+p7ASw4GxfM0zrVwvSxZl8=; b=BX7R7NBmFY/VhtnNGg6OOP0gz69PUi5q/yewqAE26c/wsBbxDTSiFppu I+tq8C+aMLv4mpfGRksk9UoiDuDGQo/Z6GtwVqVBYY1CFlXavqwd1bQz9 xvc8zIZkKSy+QtDHzIGyoHQ6aT10e9f43XOmkWs3mmvIHWa28OOuHjgqw 4XK9xJB/4ExL3/WyDROzko2soRnqu3iHqPHquaXNOlo0sUW16sXx8esuZ 8oRmfo0Y6dMRJzrlOday6uhyn4XMWEWwWV6Ruy5Zzqna7rN1gdRF/xRPt 4tDn8IQmBsfY5bD5i0XFy5Tfdqwk+uKeVmipmP+6g8oxSzPzeotBWFoxm w==; X-IronPort-AV: E=McAfee;i="6600,9927,11000"; a="4033595" X-IronPort-AV: E=Sophos;i="6.06,199,1705392000"; d="scan'208";a="4033595" Received: from orviesa002.jf.intel.com ([10.64.159.142]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 23:31:16 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,199,1705392000"; d="scan'208";a="39255742" Received: from binbinwu-mobl.ccr.corp.intel.com (HELO [10.125.242.247]) ([10.125.242.247]) by orviesa002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Mar 2024 23:31:11 -0800 Message-ID: <1f9d2b41-95ad-42ca-b1e5-70212b93a9c1@linux.intel.com> Date: Sat, 2 Mar 2024 15:31:07 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [RFC PATCH v5 16/29] KVM: selftests: TDX: Add TDX HLT exit test To: Sagi Shahar Cc: linux-kselftest@vger.kernel.org, Ackerley Tng , Ryan Afranji , Erdem Aktas , Isaku Yamahata , Sean Christopherson , Paolo Bonzini , Shuah Khan , Peter Gonda , Haibo Xu , Chao Peng , Vishal Annapurve , Roger Wang , Vipin Sharma , jmattson@google.com, dmatlack@google.com, linux-kernel@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org References: <20231212204647.2170650-1-sagis@google.com> <20231212204647.2170650-17-sagis@google.com> From: Binbin Wu In-Reply-To: <20231212204647.2170650-17-sagis@google.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8D63F180008 X-Rspam-User: X-Stat-Signature: d64sfiko6jsb851q1kkd7j5wy7r16aoe X-Rspamd-Server: rspam01 X-HE-Tag: 1709364677-248364 X-HE-Meta: U2FsdGVkX1/SXLqnt/NX3Dua3i3NGzHJdLhIQnKuThYqyU6z0AprC4ktIuBpd778alXGqk7RRd113sEwKuA4ZgjL2kdeEOla4XC8VtlZyakCUMTt7T5K1rzUGS4s6yFlEg7suAlXq9RGOZL4OjD7KdzF8DU5+3jai0mGAFnDpLOPEAtikc057j+CArsz+Q9SMX1poz4iKjrh58P8X3/b+UVSE5SardSE89wLrvskJsMSyNoCO5BJNTwS6wEgExZo9y2gmO39O02SMJpkhhHPzDKGupRsyPn8j99TSdfQ8TOsNiZNycH2ah3ahTk5jn09UBZ2B+ycPGAWfjj343U2Rh7N2/8l9lKhceodPxcHSPYRSXI5ewJDYk1/oGL/FXEgNU3t5jnkpfgyh+Q2rsdVZN62FbI75vRZVYBI2Ce6pG+aQztBtzWN7Xx8Px4De6QAregrY9QWs8nKywBppiKn2ZI6kc1Kjr9YaAqV58/lD4+Qp6rK7Js1X21GNRZ/hLir5oxzzPuMsDvoZeXED5KTU8f0r8fSv+mZ83oYOPvJ9XZnBvYlEv0uiwRQiW5WbtAhvxNNDfBfilFFCEntSaqej1gOUtTv7lQVLHaMeqFaGd7qjQvz44LYVKUj1AsR/rTn7Nnp4f6Y6P61J45pqJ4ARc/0w/LhCHvRAeD2D4JYCE36Ykjc35GVt2QFwebrVUf3eoYH3q2mFZh/yQAh8urp09Hufcuo7cvNrpNH88sSuo5falQiDGSwICqj2s3OuTFgtRvEmZ1Yt1adfkLaSE5uROz84tExDCzsnOPb8btdaY/viIKI3CHsfq3zs/o0S96gtcqnh/oZUPZdB9ZI3mXWsJZZfQryvQ+2Zq4rSH8sulN3Xg7eRj/nvrxUkMX+Xs6izZdUbIRaifkljDWK2vtpILU5fF6cvBXukl9qR6Ny89BFaTsHM4KLNhC57Hx8u0D7mNHXJWkYe4SRqtgqnhu 4wwNHC4X kMQQhU8NxyJ6B38v71GSM5Xx8azwsU/KUcS4wiN5FxWliZMrr/W3pecGN0DqdRhcRxIBY1HDPmEa+e8FPmUxdTJM7z6zg2mMRHQCn304xNXLxffrY/e4zYyEBUHLMelVbbPrfUvq0fBU8ghz+LXXv8FF/+JyNdUws1xEvVFAgpzh+RnFxoSXy4amwzxyu6Z9WeFEl X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 12/13/2023 4:46 AM, Sagi Shahar wrote: > The test verifies that the guest runs TDVMCALL and the > guest vCPU enters to the halted state. > > Signed-off-by: Erdem Aktas > Signed-off-by: Sagi Shahar > Signed-off-by: Ackerley Tng > Signed-off-by: Ryan Afranji > --- > .../selftests/kvm/include/x86_64/tdx/tdx.h | 2 + > .../selftests/kvm/lib/x86_64/tdx/tdx.c | 10 +++ > .../selftests/kvm/x86_64/tdx_vm_tests.c | 78 +++++++++++++++++++ > 3 files changed, 90 insertions(+) > > diff --git a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h > index 85ba6aab79a7..b18e39d20498 100644 > --- a/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h > +++ b/tools/testing/selftests/kvm/include/x86_64/tdx/tdx.h > @@ -8,6 +8,7 @@ > #define TDG_VP_VMCALL_GET_TD_VM_CALL_INFO 0x10000 > #define TDG_VP_VMCALL_REPORT_FATAL_ERROR 0x10003 > > +#define TDG_VP_VMCALL_INSTRUCTION_HLT 12 > #define TDG_VP_VMCALL_INSTRUCTION_IO 30 > #define TDG_VP_VMCALL_INSTRUCTION_RDMSR 31 > #define TDG_VP_VMCALL_INSTRUCTION_WRMSR 32 > @@ -20,5 +21,6 @@ uint64_t tdg_vp_vmcall_get_td_vmcall_info(uint64_t *r11, uint64_t *r12, > uint64_t *r13, uint64_t *r14); > uint64_t tdg_vp_vmcall_instruction_rdmsr(uint64_t index, uint64_t *ret_value); > uint64_t tdg_vp_vmcall_instruction_wrmsr(uint64_t index, uint64_t value); > +uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag); > > #endif // SELFTEST_TDX_TDX_H > diff --git a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c > index 88ea6f2a6469..9485bafedc38 100644 > --- a/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c > +++ b/tools/testing/selftests/kvm/lib/x86_64/tdx/tdx.c > @@ -114,3 +114,13 @@ uint64_t tdg_vp_vmcall_instruction_wrmsr(uint64_t index, uint64_t value) > > return __tdx_hypercall(&args, 0); > } > + > +uint64_t tdg_vp_vmcall_instruction_hlt(uint64_t interrupt_blocked_flag) > +{ > + struct tdx_hypercall_args args = { > + .r11 = TDG_VP_VMCALL_INSTRUCTION_HLT, > + .r12 = interrupt_blocked_flag, > + }; > + > + return __tdx_hypercall(&args, 0); > +} > diff --git a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > index 5db3701cc6d9..5fae4c6e5f95 100644 > --- a/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > +++ b/tools/testing/selftests/kvm/x86_64/tdx_vm_tests.c > @@ -721,6 +721,83 @@ void verify_guest_msr_writes(void) > printf("\t ... PASSED\n"); > } > > +/* > + * Verifies HLT functionality. > + */ > +void guest_hlt(void) > +{ > + uint64_t ret; > + uint64_t interrupt_blocked_flag; > + > + interrupt_blocked_flag = 0; > + ret = tdg_vp_vmcall_instruction_hlt(interrupt_blocked_flag); > + if (ret) > + tdx_test_fatal(ret); > + > + tdx_test_success(); > +} > + > +void _verify_guest_hlt(int signum); > + > +void wake_me(int interval) > +{ > + struct sigaction action; > + > + action.sa_handler = _verify_guest_hlt; > + sigemptyset(&action.sa_mask); > + action.sa_flags = 0; > + > + TEST_ASSERT(sigaction(SIGALRM, &action, NULL) == 0, > + "Could not set the alarm handler!"); > + > + alarm(interval); > +} > + > +void _verify_guest_hlt(int signum) > +{ > + struct kvm_vm *vm; > + static struct kvm_vcpu *vcpu; > + > + /* > + * This function will also be called by SIGALRM handler to check the > + * vCPU MP State. If vm has been initialized, then we are in the signal > + * handler. Check the MP state and let the guest run again. > + */ > + if (vcpu != NULL) { What if the following case if there is a bug in KVM so that: In guest, execution of tdg_vp_vmcall_instruction_hlt() return 0, but the vcpu is not actually halted. Then guest will call tdx_test_success(). And the first call of _verify_guest_hlt() will call kvm_vm_free(vm) to free the vm, which also frees the vcpu, and 1 second later, in this path vcpu will be accessed after free. > + struct kvm_mp_state mp_state; > + > + vcpu_mp_state_get(vcpu, &mp_state); > + TEST_ASSERT_EQ(mp_state.mp_state, KVM_MP_STATE_HALTED); > + > + /* Let the guest to run and finish the test.*/ > + mp_state.mp_state = KVM_MP_STATE_RUNNABLE; > + vcpu_mp_state_set(vcpu, &mp_state); > + return; > + } > + > + vm = td_create(); > + td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0); > + vcpu = td_vcpu_add(vm, 0, guest_hlt); > + td_finalize(vm); > + > + printf("Verifying HLT:\n"); > + > + printf("\t ... Running guest\n"); > + > + /* Wait 1 second for guest to execute HLT */ > + wake_me(1); > + td_vcpu_run(vcpu); > + > + TDX_TEST_ASSERT_SUCCESS(vcpu); > + > + kvm_vm_free(vm); > + printf("\t ... PASSED\n"); > +} > + > +void verify_guest_hlt(void) > +{ > + _verify_guest_hlt(0); > +} > > int main(int argc, char **argv) > { > @@ -740,6 +817,7 @@ int main(int argc, char **argv) > run_in_new_process(&verify_guest_reads); > run_in_new_process(&verify_guest_msr_writes); > run_in_new_process(&verify_guest_msr_reads); > + run_in_new_process(&verify_guest_hlt); > > return 0; > }