From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EFFBD21259 for ; Thu, 17 Oct 2024 08:51:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 992836B007B; Thu, 17 Oct 2024 04:51:32 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 91BC06B0082; Thu, 17 Oct 2024 04:51:32 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 747216B0083; Thu, 17 Oct 2024 04:51:32 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 565376B007B for ; Thu, 17 Oct 2024 04:51:32 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id AAC0E1610B0 for ; Thu, 17 Oct 2024 08:51:19 +0000 (UTC) X-FDA: 82682475372.05.65895A1 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf15.hostedemail.com (Postfix) with ESMTP id CEF5BA0009 for ; Thu, 17 Oct 2024 08:51:19 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gNclukrd; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1729154982; a=rsa-sha256; cv=none; b=Su7+NAikvEZAN9aIQlU2kUGbGF/z7uot37ZaVXTqixYcpdSJlMiWzScbSv4iD90Ursi2pv HCUmTHwaVQ6IBuNHQdVCJPxSt59lE1htXujSibJ58ttCMCj4eeHHeaaWGRb7mebVUsF25V xL2+6j9jOj/Y292t1kRiZSSAMgnn924= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=gNclukrd; dmarc=pass (policy=none) header.from=redhat.com; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1729154982; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EN/Eizswj47pmoV3qDsAgb+fvVuBqxHIhwGCCsZ/BBk=; b=wckTVtv6QGNTRpfZMBNIegwhxKMIo5/WmsLHNeUu7GXU/XFkTXbGhtAJ+ezeTTJ887s+mB O9dywEBZZ1CSo3ErHg+oEkYbyrTgQQQLy8lprniwURHvuPh86Iy+coKuG6B0AsJao3tFoz DmSNwAHd0XVQxwxdA8y5taPojHvIaiA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1729155088; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=EN/Eizswj47pmoV3qDsAgb+fvVuBqxHIhwGCCsZ/BBk=; b=gNclukrd+q4btHGnCTUhx/BKsVnivQ3Uu8AmXRiV+hvO3tAQlMNW0T3HtB+L8oQ4Ag5Gz0 aV3cIXkD5wO3Whmu8MfB5U990kRRhX/Kitdxv4a7J5CGZeJCEvSBNJo0NcZ1b0nike749i BhWs18FpRvHirMFQUhhxYQNxmq/BRm4= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-205-rZqGtH7xPxmRuAl6fwZzPQ-1; Thu, 17 Oct 2024 04:51:25 -0400 X-MC-Unique: rZqGtH7xPxmRuAl6fwZzPQ-1 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-4314f023f55so5573705e9.2 for ; Thu, 17 Oct 2024 01:51:24 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729155084; x=1729759884; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=EN/Eizswj47pmoV3qDsAgb+fvVuBqxHIhwGCCsZ/BBk=; b=TUpwp3ala7zKuaONei8gfgxPl48eRbD9knMuiJ78+rRtkzf81xz2Kcf/riQbwmsCFO w0nNJAZ7WfR2BHD+wxJ2g9o4TVcfdDdzkuFBpsT3+83d4quzUDz5GzF5RB2NukW8GbjD 0nje8ZmLuSgA7UJiLxDze9cItOdYjgJd0BdOtpS4FrOkQbgOUOr4JtPbfc8jsdanIOZU YQmnfoqeTSnyxfxyXyRYW70we4gMjCOyM/4E3ROSUDttYGaeU73+dto6F7fgjaaNc2ck /MDsITU2fht1H/AanN4rkLl1YxT69TM/mNcctC1/d8poL4EPHuMJ0cR1n4Fp/Qil6AqC RbxQ== X-Forwarded-Encrypted: i=1; AJvYcCVWkviQYZFHn09q9RsP1MbsF12atGPGdnatlgXYqTF2Srl7b3Lyz4Zk18cFWfEDRpqEDUSWPblZJA==@kvack.org X-Gm-Message-State: AOJu0Ywu8AMTtVVlRzfuHnT3Yyq0dakKAjOCfPuIwz4EiFPXlJq8dWsm I1Ze7+WOl7G6Nydq4uHqLvOw1jEk1YtqP/wNH6sqLPJrjPM5F82XZ9Ao8o6wTpfXQ9Gdb5T0ZEr 25vYacG/4vUIlQbKp8ZKr0QkGXlkh0wqBAwnnbVJMneDBpSFN X-Received: by 2002:a05:600c:3c9c:b0:42c:e0da:f15c with SMTP id 5b1f17b1804b1-4314a32333bmr50976065e9.20.1729155083674; Thu, 17 Oct 2024 01:51:23 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGYYhBoPFvFWP0XlaQg+uyhe3vARcgCr9/+6i0JB3VhiAXicmKPY9C+kRks11rZ04Pl5CnMrA== X-Received: by 2002:a05:600c:3c9c:b0:42c:e0da:f15c with SMTP id 5b1f17b1804b1-4314a32333bmr50975865e9.20.1729155083293; Thu, 17 Oct 2024 01:51:23 -0700 (PDT) Received: from ?IPV6:2003:cb:c705:7600:62cc:24c1:9dbe:a2f5? (p200300cbc705760062cc24c19dbea2f5.dip0.t-ipconnect.de. [2003:cb:c705:7600:62cc:24c1:9dbe:a2f5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37d7fc12dbcsm6666212f8f.96.2024.10.17.01.51.22 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Oct 2024 01:51:22 -0700 (PDT) Message-ID: <1f8dcae1-416e-43cf-8dda-5440e0db4c00@redhat.com> Date: Thu, 17 Oct 2024 10:51:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/gup: stop leaking pinned pages in low memory conditions To: John Hubbard , Andrew Morton Cc: LKML , linux-mm@kvack.org, Alistair Popple , Shigeru Yoshida , Jason Gunthorpe , Minchan Kim , Pasha Tatashin References: <20241016202242.456953-1-jhubbard@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20241016202242.456953-1-jhubbard@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: CEF5BA0009 X-Rspam-User: X-Rspamd-Server: rspam05 X-Stat-Signature: 7n61n1x5ff7isbyrbqcg45gsd755s7ra X-HE-Tag: 1729155079-699734 X-HE-Meta: U2FsdGVkX192dpiIcCVTwnW6LFjBDgTm6OOmsGSiDt/17TGBF+wdIow0njnHt+U8TJxex7qXTHS20LD2kTEVCUmALg6re9dN4M3sj4c/WKtVTtc9eolG4ESSSQFveZ/iKH2lzM4zBsgLIZRLm3IRwiDTeVA+i53LKWzYlMoCgCcqdTEZMowUSkHohmBDcUIjcnMaqdPBRfaOwpVkzOugsCCT4FMtscpTx/EEU4j4Spn7gnVVjv3vx1kK2Kld+HyRisyBjZALNWn3ePgELbpwU78eiHsgzq9gL3NIuFkDc716G0dy9hwPK/nrDLbZuek0kIEhNI+wxq8ZLmqajnQLhVruUX6aO2aEkaUoyvIvmk2Vk90UYOkMAJm+QCqNLfpEuoWDn1QgvmhPtClTD/O6b5L/HKUhFSIvshebEBoiWfI2GAHkhlwLL1rEmdqUCuZ/nacI5FB0y4zRb6wVtb/nOm5cvhnMjZwK6Hk6CO42J3DEl9Vqug+SQRkRAehbkLh5sV+mdiVxPXwb4/I0eTeSzs4pbOPoA3lr/In8cjIG9nW7HIgB1YwhzYW3ivjQJXQy4c7w0E8YkmOEAgo499HHRGRbEUmlmQPz0dqEHdeoIhnO5lKG2/+eg0Jx7YuPF9a44G6hqiT1HEPwRE4mobWVErnvjaIgES9HL3oyhziMsUVDGWwex9UMjtZpw3AIaPQVSyrWEUz8jzpE6rY5Fj1rNaU8gHKT1/BF8bMUct8AL9+u0iztkK2jQelAzrA2fG9hcfgzqe/wu5ExpgVsQR3pPBdRfaMdUqSyCkZN5jr20Vqp7Jfe3TLkMzTlCahUm/5EbNICXWHDr17QwOo7YpH+fczg1dz3GsyT4sif+eOAmuC8Yw/JlKoFOuWh+yZQSl+kyrH5+pf0orOOgtLp3QutgH3xM3gdWe3+fNyU1i0uZKqLn95o9bMpV/iSX8RAEB9QoTmNstWd2+E4oGFbd2P ShYXMDLn Y+ZaBBD4iSA61aH48Z0npKHfYBmYFUqXACytkvliDkoC66G074ZQVV/H7vHhTPTs4sQwsSKIt9xVbnBVpOxnQ08wXfnYzG3OrztqJo5X0lmk8KJYIKYLUKhiC8xt6J20UdSXsWIjEoh3+zSaV4fuanzVi/v/7CwECItA6eWHpue3SsvcNSMZNk9GHw+hta0yKTj3mYQpSoaVdlpeyhug8QdQ+6x/V61VkPes1aBr331PMlSysAHyqm6gRwjzGktdHzEguj6miIz17S7rwVU11HnWECDP4IQLGyqAmOefkXwUmwsazTJtx0RhjbqoJ+3pka9scfRN/Ap2ch5Hvw+PG0YddHqhYTxuMcG/o1i8Xbw9ZdFmRIVigoLSlYb6FE9x3sQdSCVLCkythiuYN/LmxTzWBhqg+cEcLktfuIRuGlwkOxfB1Uk6nd0iKHa0pjyXGusd9HPQ7n+xgF49gjQwGaYf1R2vPUha6h4RZ4EhpnMYGLD6WP1uEQgPHMNMd/yndaLqLO+YtQiBEnds= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.10.24 22:22, John Hubbard wrote: > If a driver tries to call any of the pin_user_pages*(FOLL_LONGTERM) > family of functions, and requests "too many" pages, then the call will > erroneously leave pages pinned. This is visible in user space as an > actual memory leak. > > Repro is trivial: just make enough pin_user_pages(FOLL_LONGTERM) calls > to exhaust memory. > > The root cause of the problem is this sequence, within > __gup_longterm_locked(): > > __get_user_pages_locked() > rc = check_and_migrate_movable_pages() > > ...which gets retried in a loop. The loop error handling is incomplete, > clearly due to a somewhat unusual and complicated tri-state error API. > But anyway, if -ENOMEM, or in fact, any unexpected error is returned > from check_and_migrate_movable_pages(), then __gup_longterm_locked() > happily returns the error, while leaving the pages pinned. > > In the failed case, which is an app that requests (via a device driver) > 30720000000 bytes to be pinned, and then exits, I see this: > > $ grep foll /proc/vmstat > nr_foll_pin_acquired 7502048 > nr_foll_pin_released 2048 > > And after applying this patch, it returns to balanced pins: > > $ grep foll /proc/vmstat > nr_foll_pin_acquired 7502048 > nr_foll_pin_released 7502048 > > Fix this by unpinning the pages that __get_user_pages_locked() has > pinned, in such error cases. > > Fixes: 24a95998e9ba ("mm/gup.c: simplify and fix check_and_migrate_movable_pages() return codes") > Cc: Alistair Popple > Cc: Shigeru Yoshida > Cc: David Hildenbrand > Cc: Jason Gunthorpe > Cc: Minchan Kim > Cc: Pasha Tatashin > Signed-off-by: John Hubbard > --- > mm/gup.c | 11 +++++++++++ > 1 file changed, 11 insertions(+) > > diff --git a/mm/gup.c b/mm/gup.c > index a82890b46a36..24acf53c8294 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -2492,6 +2492,17 @@ static long __gup_longterm_locked(struct mm_struct *mm, > > /* FOLL_LONGTERM implies FOLL_PIN */ > rc = check_and_migrate_movable_pages(nr_pinned_pages, pages); > + > + /* > + * The __get_user_pages_locked() call happens before we know > + * that whether it's possible to successfully complete the whole > + * operation. To compensate for this, if we get an unexpected > + * error (such as -ENOMEM) then we must unpin everything, before > + * erroring out. > + */ > + if (rc != -EAGAIN && rc != 0) > + unpin_user_pages(pages, nr_pinned_pages); > + > } while (rc == -EAGAIN); Wouldn't it be cleaner to simply have here after the loop (possibly even after the memalloc_pin_restore()) if (rc) unpin_user_pages(pages, nr_pinned_pages); But maybe I am missing something. > memalloc_pin_restore(flags); > return rc ? rc : nr_pinned_pages; -- Cheers, David / dhildenb