From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AD3FC77B7F for ; Fri, 19 May 2023 11:04:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C2252900005; Fri, 19 May 2023 07:04:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BAB58900003; Fri, 19 May 2023 07:04:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A24F6900006; Fri, 19 May 2023 07:04:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 912BC900005 for ; Fri, 19 May 2023 07:04:28 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 65423A0A3E for ; Fri, 19 May 2023 11:04:28 +0000 (UTC) X-FDA: 80806721016.09.65F4CEA Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf17.hostedemail.com (Postfix) with ESMTP id 4D3B14001D for ; Fri, 19 May 2023 11:04:26 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=fgD3+fCl; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=dFs0aALa; dmarc=none; spf=pass (imf17.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.25 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684494266; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/Cwla6Z93CmdqEZ213cheaHU/C7xFoaUH7cr2bjxpHQ=; b=v8dYtBNzv9biCs9OGeobu2rgO5BlB656Hlohc+wlrvXXqTAf97rKYJ46Ma3j0lSL6PwQVI Tvtwec7irJpjrforNcdCrtGDP7F24GwZdfIG1F1N5dRWDggyyUbVYqDK8ocTdolvYpPCfx tJxII0UiqZbGMxvdnDUpAzGrpWZ3G4s= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=arndb.de header.s=fm3 header.b=fgD3+fCl; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=dFs0aALa; dmarc=none; spf=pass (imf17.hostedemail.com: domain of arnd@arndb.de designates 66.111.4.25 as permitted sender) smtp.mailfrom=arnd@arndb.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684494266; a=rsa-sha256; cv=none; b=TKQ0m5w/pdhW6ZDZ2BgdOXgCxeOkQfXyZw6uSq3tSHajZBFUnJfo5ywwnzfkNLfOqEf/rF 7Kr4NMsZ7xTdp5iJk2liSKMZi8ysJnPvSeWKvjTCzhNTO9HBaHkmIA4/AXRWQHNWIasl2e AXt/8uiuQSm2frIUtLtguLVSMK3dKXI= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 888FD5C018C; Fri, 19 May 2023 07:04:25 -0400 (EDT) Received: from imap51 ([10.202.2.101]) by compute6.internal (MEProxy); Fri, 19 May 2023 07:04:25 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=arndb.de; h=cc :cc:content-type:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm3; t=1684494265; x=1684580665; bh=/C wla6Z93CmdqEZ213cheaHU/C7xFoaUH7cr2bjxpHQ=; b=fgD3+fClg58VBaUs// zaPCHvCJP5VwPquLsJQCejG585X4z+0cgq8+PVQLQhfsm5YWTZtpvK/KaaglSt4v AZlDlbvGF3uoZD3fC2SSE25eKMeiJ6Wom5J1YcG2GkUcncWYRhxQyk68GPcM/VQp 34Ei3ImxNpBRwXdc9tym77ZcH2TZYznA5nJLd0dV2c5Gry+glxktVg9gmMI9439a f3L5sFm8wopBNd1vAmNNyXTneaLVTBRRVuEaIadcCeApET3YIvFnFJalDw9tA0h/ 2TZol3iqiGR+i22jK3aoA3M0ZmXVLJnvyzijOnDj+ydVHvdZRUx6GiucYtjtNpoN JBTA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:content-type:date:date :feedback-id:feedback-id:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1684494265; x=1684580665; bh=/Cwla6Z93Cmdq EZ213cheaHU/C7xFoaUH7cr2bjxpHQ=; b=dFs0aALapqY2/RKBVBoRgsFC+kwwn aghUbwauR7c1rX0XPL5DOBgegPR2+r/bkGNCHfJxUzqFkNmnzE8s/4FBbZi5lUoP nAOFrE15xfCXbV5De8PpVHEPPQaEzx07LPV8M2YiUR692Ae414HT9CDIPsp6/adS ri78lMwnrM8+0M82lszLmKjmmPSM5wfqXIhxwrHo/HhPJmcwFpyMcgcL4OhJuOKD iQ+iy6dLE5E+W30aMejTZcd8FnCpaTSh3UIXb6IRU53VnkL0NvNyaDJ3yMEEg3jy Amhm2R5vJ7t1jx6KTPd6J1GyNs70g8SgYMjfUjxhve2s0eAY/TVDwYw5g== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeeihedgfeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvfevufgtsehttdertderredtnecuhfhrohhmpedftehr nhguuceuvghrghhmrghnnhdfuceorghrnhgusegrrhhnuggsrdguvgeqnecuggftrfgrth htvghrnhepffehueegteeihfegtefhjefgtdeugfegjeelheejueethfefgeeghfektdek teffnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprg hrnhgusegrrhhnuggsrdguvg X-ME-Proxy: Feedback-ID: i56a14606:Fastmail Received: by mailuser.nyi.internal (Postfix, from userid 501) id 9A414B60089; Fri, 19 May 2023 07:04:23 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.9.0-alpha0-431-g1d6a3ebb56-fm-20230511.001-g1d6a3ebb Mime-Version: 1.0 Message-Id: <1f771dae-1bc7-4fd3-8514-613cf3b12e1a@app.fastmail.com> In-Reply-To: References: <20230516193549.544673-1-arnd@kernel.org> <20230516193549.544673-11-arnd@kernel.org> Date: Fri, 19 May 2023 13:04:03 +0200 From: "Arnd Bergmann" To: "Dave Hansen" , "Arnd Bergmann" , x86@kernel.org Cc: "Thomas Gleixner" , "Ingo Molnar" , "Borislav Petkov" , "Dave Hansen" , "H. Peter Anvin" , "Andy Lutomirski" , "Steven Rostedt" , "Masami Hiramatsu" , "Mark Rutland" , "Juergen Gross" , "Srivatsa S. Bhat (VMware)" , "Alexey Makhalov" , "VMware PV-Drivers Reviewers" , "Peter Zijlstra" , "Darren Hart" , "Andy Shevchenko" , "Boris Ostrovsky" , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-pci@vger.kernel.org, platform-driver-x86@vger.kernel.org, xen-devel@lists.xenproject.org, linux-pm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 10/20] x86: xen: add missing prototypes Content-Type: text/plain X-Rspamd-Queue-Id: 4D3B14001D X-Rspam-User: X-Rspamd-Server: rspam02 X-Stat-Signature: 5qxsr9ajmw53m9e5ny3w8j8ph4jnzzop X-HE-Tag: 1684494266-442431 X-HE-Meta: U2FsdGVkX19bAvHwBcUBnLnTX9ONQLFvdG2zV57qpeP5aowaZP7G8Sqye9zh+LYdHhLXwBfE9DNf8s3vka8cx821Hx+xn1GmUwyI4iqBMlfRPWUuLva6Ai/j7plrFCSQgdm+GuNLNfudF9gt4K429jVxpLzGr/zS1skLtriCWz42KrGobQb2lI/f6ypPZMDhUHrEd9/doD8Kxv9EeQ330SNdY3x4cXCDZ/siXee/gLv/3/aJETKUcRyJRLL+xBwmlOfCw9z9aOMNJeV0sLlCjbz5RGhZPLtwAilanTGCr8xHNvG6dwEt1RKfpu1qP0uyDKmCqx0w+UleheUvXCkzzlc3wrDPHI4N8M4OJb89kAUU+kbzyHJly/QB57Zkwi79m+4CJL0FONr87EVK4guUVZhlBxhF3L/iOc8otC3EWei7m7hv8tGPuiNzstMuDX/R8ArOUmfDxWbhjXWy9t70spULST7NFNb14gAWvBnaQJNQkrG+w5XMNCDv11F2y8Wbu40L0tOOlCghKHaRnyK4OSZmrWG+e5fZeY5o07qRKV+jzcqEEBJEq/MRX9ybO2ASyYAnHTdU7CE7s7vNDw2FN0uiQUbqCPzySjCRYC4YAqL1BbSwItv6twb/AZ3qV1lca2MMxIaUinqtOx7Vj7fo0L1PtYuRAOVCOPd/XPAfJ0VNbfPdlmc0GepgfyVe70zUMN/Ujq+Z3SO+4FO6eTj/m01OCcCEZs6KLUfaP8rwIpxVCWM2eJ+TNlhT0up3TrZni/KAhFXs2my58LcsVbwVpsV7IPj4fuo5MBgOPHEjWZ+h1mh+9GgjFG5W5Zp0EIvDiRSAYJWqmsWlj8rqL1xvN2O3aIF9ml/VJXvkJI2qJJMQmBXM64NjDBItpsNHAND3K+JxAhf5MZTd0p0SwSA68/885+Tx5g3DJ2wgjGhqJhbHcOzZNuCXSe4XIo9+IoW8T9GirZWumrXnhSCkUHU 15F6I35O WUwCbI2kEL1Gp4fLtDyxIBdZ+2XX48psloWyFT/wClkgoOawEvNkTVd80Fw2FCTfe5foaLn+MKY6KBWZxqGgSKBdx53BdrryCp45auaGSa1t5EgjCwVOYEhgxkNL8CaLEDcRu X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, May 18, 2023, at 19:28, Dave Hansen wrote: > On 5/16/23 12:35, Arnd Bergmann wrote: >> >> arch/x86/xen/enlighten_pv.c:1233:34: error: no previous prototype for 'xen_start_kernel' [-Werror=missing-prototypes] >> arch/x86/xen/irq.c:22:14: error: no previous prototype for 'xen_force_evtchn_callback' [-Werror=missing-prototypes] >> arch/x86/xen/mmu_pv.c:358:20: error: no previous prototype for 'xen_pte_val' [-Werror=missing-prototypes] >> arch/x86/xen/mmu_pv.c:366:20: error: no previous prototype for 'xen_pgd_val' [-Werror=missing-prototypes] > > What's the deal with this one? > > The patch is doing a bunch functions on top of the ones from the commit > message. Were you just showing a snippet of what the actual set of > warnings is? I missed this one going through the changelogs before sending them out, I thought I had added a proper text to each one, but it fell through the cracks. I've followed up with a v2 patch that has a proper changelog now. Arnd