From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 95DA3C636CC for ; Mon, 13 Feb 2023 17:05:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 006F86B0075; Mon, 13 Feb 2023 12:05:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EF9746B0078; Mon, 13 Feb 2023 12:04:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DC17F6B007B; Mon, 13 Feb 2023 12:04:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CCEEB6B0075 for ; Mon, 13 Feb 2023 12:04:59 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9DCDA160811 for ; Mon, 13 Feb 2023 17:04:59 +0000 (UTC) X-FDA: 80462893518.17.22F8F92 Received: from mail-il1-f174.google.com (mail-il1-f174.google.com [209.85.166.174]) by imf27.hostedemail.com (Postfix) with ESMTP id 13BA740006 for ; Mon, 13 Feb 2023 17:04:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=0Up9q+rt; spf=pass (imf27.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.174 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1676307897; a=rsa-sha256; cv=none; b=UHe3jC/VjWt64Bfso/JQOphJ+adpn0ZRS200A4wuZFgHgQCV61LD9x/kB2SBIP/OFkeC2O /hQDLa+YwD9rlBKyCPUxr4MLl2RI59k/dc7LOwJ1MnCmUj6SBtrcTYUjZiHKknkhrqObZh wTbzkQUvZrjKhUACoPOU8UD0nmhbjKA= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel-dk.20210112.gappssmtp.com header.s=20210112 header.b=0Up9q+rt; spf=pass (imf27.hostedemail.com: domain of axboe@kernel.dk designates 209.85.166.174 as permitted sender) smtp.mailfrom=axboe@kernel.dk; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1676307897; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/vgCGFkrQwcp/7jPx+PdVEy8B0KpHLcBmVE/3aSXGL0=; b=0l422dXDEnWEOpisVXsLm56kGTtlq/ooDjUSpNML7FjCULKF93qO1SwDIH3Y2JlWlIzkTu hA3rY+XbCkSByOKfF9ZlZOP1p7bw5B0E493lRzSU3Bpihhe6wBPSpdXVlbWXLUJGBWLnSl CCjnCJQfyW3UIAc0IpFrh1i00OsVNdk= Received: by mail-il1-f174.google.com with SMTP id v6so492432ilc.10 for ; Mon, 13 Feb 2023 09:04:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=/vgCGFkrQwcp/7jPx+PdVEy8B0KpHLcBmVE/3aSXGL0=; b=0Up9q+rtS4ekW744Yp+SKLSPhEYbbmzoeNX7HtHa6nB/W3vmkqNHtEjDtXJnxq268p WwPoBNu0h/3N7pYDeeiy5Rgw91FcAzGMhvGRuJVzbf54Hoo81DtAyDQWk1TfI6YA3Tnv CGAF8rkvn3JdTC4ugT0/wu1gifN8sOG9SlmYwbA+UNj0MsrHkP25N3/Vw7/SZkI3Wwau vETaQjDeorwX5qhpWyGB9iLf0CGF3n66W9/RbGTlzHoLulQhZV3beSSR/r0juaCcqhBz Q/RRTm8NcqdnG2+EVjBu2QDVXbDqyxXvckxMl5aWKTnf7jVx/n/sGkDaRWKOqLIb5zez uOLg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=/vgCGFkrQwcp/7jPx+PdVEy8B0KpHLcBmVE/3aSXGL0=; b=1UuNOrJsOUT6arUJ7OYDdoggKCokTRqIBaKSFFceaKIgaclqoQYnfTy7W+tHSVzbY7 JWBpbrzAJT+ovMVJKfvrY56FDATos/LXx6f9StBUGMtULMl8A5xuSwky7wOwMn6s7oRM bpJ1on47GPg8UX08w++47hq/jPoTVOrsyGN6llbgA3nkZUOITvKKzUbmLVU7HtWrTMij B8qdR2MnePnMi67lWMAuAjM9uQf9veCn1lSACIfCI1RZNwd2nkiNPVPlDu2mi3Qz+9K7 f1KlIm/eL7HqlJIy1hM3p4EdsICkRZDayP7eT3A31Z+44PjqJIJ36yk768Inm0YXvvoj 52QA== X-Gm-Message-State: AO0yUKWNVVCg3+0tvVnetr1bYqMBPgRtot3kKajoaDBvmetpvxdyA1iL PuiOrtnfOQzS6SLzFNt+7CgG1A== X-Google-Smtp-Source: AK7set9Hc8PI/3Vz78e4+P2zWBzi6x265jfVpLGfmkLl7P2VS/PPl73lyILaUovAKnyd2uibp/VWOw== X-Received: by 2002:a05:6e02:1d84:b0:315:39ce:abd2 with SMTP id h4-20020a056e021d8400b0031539ceabd2mr4774352ila.3.1676307895839; Mon, 13 Feb 2023 09:04:55 -0800 (PST) Received: from [192.168.1.94] ([96.43.243.2]) by smtp.gmail.com with ESMTPSA id y13-20020a056e02118d00b0031537da6ba3sm1530437ili.87.2023.02.13.09.04.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 13 Feb 2023 09:04:54 -0800 (PST) Message-ID: <1f716ecb-3f27-af5f-66b4-ac4dae52cf23@kernel.dk> Date: Mon, 13 Feb 2023 10:04:52 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:102.0) Gecko/20100101 Thunderbird/102.7.2 Subject: Re: [PATCH v2 0/4] iov_iter: Adjust styling/location of new splice functions Content-Language: en-US To: David Howells , Al Viro , Christoph Hellwig Cc: Matthew Wilcox , Jan Kara , Jeff Layton , David Hildenbrand , Jason Gunthorpe , Logan Gunthorpe , Hillf Danton , linux-fsdevel@vger.kernel.org, linux-block@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org References: <20230213153301.2338806-1-dhowells@redhat.com> From: Jens Axboe In-Reply-To: <20230213153301.2338806-1-dhowells@redhat.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 13BA740006 X-Rspamd-Server: rspam01 X-Stat-Signature: 3gupn61o4zd3dcwmunpy974kxxsnsmpp X-HE-Tag: 1676307896-323276 X-HE-Meta: U2FsdGVkX1+HzohjBoIyy6mX4KEpafxWLOSIvJzQuSmXdoIjxD944rCBhrCBEeQflYYnerk+5VmUDaDZ29HMyYP6LrhrJr2KL7jPe6HVDy6+AHUuB/TSAgv0Ay5gonNGalVGI81czmjCwXc9pCCqDXVDrm7uwwFgAKtNq2GdXRG85vUxmIAXM1OK/dFY7XTUHm8f+uEqleiUnSRIXxD1ZCzVjfqeh5G+IwKyOL98QgYd9Z+YFdEiSOy6ACvS60p2N4IJ8OrrulA/jmTBOergS8/QqbWU9QVJ9VWFdSMZrYjtsrF83eMi7EPMKh0l87sTJ/vqaBElHSsT1THvlORI3ESSZx4dxZASa7hSZIhUjkuKxLKLTG6FPBMsxRNvXmVSSSLQOyMo2lLKVjgs8jv0fkqoi71oeqVrHqGxPpnCkgh6w+q1R+oLiNRocuZuAQjRw0oi3jHSpCU/uwzLxFk+1a1fdQuqjubEdpfp+k8XOncKk/ojmnkn3NIAmJADLdr8X0LWCBO7eoYruly8Ot2wbraotBqMo3hJARxVYKpWtq2vkdO2wgtA+1lRRda2l9UTFA7Mzs1GNoxqZbw+401veLXCzWpnyU6NefILgMNKZQr9QHaQHusH6qnuPLMsjIGiXuMqYbShGtGz9Qr+oZScsXGsPqbqCs7lmKmC+2AwkG//Bn5lseEDR9Wz0p3NI2KM+dA/HX+Awp4FgT3var0USlxKNPdWEnmMid4sZc+xWyyNQFK3rJTWFJkXhUsnIMa7QPgwZOcOybDjrzQVI+t0PBlD1hENHDTeo4ZOV7f+OYZvnE4ChG5RA8KvbXWcoCqbg833f2ZOkmrvJ52+4/XNso8ay8z183Mq8KR8LervjewUXLxfL/y3sIQr827l8WJBMOscyzrZfSLy1v0KnP2fVbYHBBs99RUDYGtifVQVz5U5AY+lTcnCOrxLPvOGzKDG5I+60wZ2nsC4phpMFdJ T3GbhJCb I62zvbTYjcYIPcOSSYig4t4SAOpeCAeQNFCeVp+aHp5VFTHLkysR3YjV1bnKXe5h96eo48Kf3edFKDlpnH67ji7JIMZVuD+aY22KKcxu+u7jIEX+SFQnzZMUsHNsQj6gQeduxCzaK+nTYmN9p6p4U3siiftwiGWg+X2CSy/Q6LnnzjJIxo6WD/tcUz9zmXnGsZURU32AASaSmyRQsJFuQtp5jOumVVVCyv7nq+VnznHUVBk0VYZNBVcyFc5j3qvv5iVLuA8Grr8ZfQbgsCGOlzmtdCFlYaS7Po68ox7GAnMjxVsfzpcn09zYSh1sR4cbSRH2nDpquWwgNwn1Ym7gg6QgCZJ88QmrhpvPs2WKrNuG/7B8ZZ+a7sOazg3OB1EkJ2xMrjiRIEmD+IW549AOuiAtUkEFPCbaK5Cv+E8Du2uV90WClh9d3wQoaDw2WayTOKviRoYVb17WjyLQzPxKzwFavtfCHdztHNaKx+mAJSfRF8mKvwV2H7q2MVVgBsG/26htYdYwysUNw9uGr0DlxtQjio3Oeto2k+KSmN97jq4TOcSXXQFUyQhvNl6Um4Pm1fJ6H X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2/13/23 8:32 AM, David Howells wrote: > Hi Jens, Al, Christoph, > > Here are patches to make some changes that Christoph requested[1] to the > new generic file splice functions that I implemented[2]. Apart from one > functional change, they just altering the styling and move one of the > functions to a different file: > > (1) Rename the main functions: > > generic_file_buffered_splice_read() -> filemap_splice_read() > generic_file_direct_splice_read() -> direct_splice_read() > > (2) Abstract out the calculation of the location of the head pipe buffer > into a helper function in linux/pipe_fs_i.h. > > (3) Use init_sync_kiocb() in filemap_splice_read(). > > This is where the functional change is. Some kiocb fields are then > filled in where they were set to 0 before, including setting ki_flags > from f_iocb_flags. I've filtered out IOCB_NOWAIT as the function is > supposed to be synchronous. > > (4) Move filemap_splice_read() to mm/filemap.c. filemap_get_pages() can > then be made static again. > > I've pushed the patches here also: > > https://git.kernel.org/pub/scm/linux/kernel/git/dhowells/linux-fs.git/log/?h=iov-extract-3 > > I've also updated worked the changes into the commits on my iov-extract > branch if that would be preferable, though that means Jens would need to > update his for-6.3/iov-extract again. Honestly, it's getting tight on timing at this point, and there's also a crash report from today: https://lore.kernel.org/linux-block/Y+pdHFFTk1TTEBsO@makrotopia.org/ I think we'd be better off folding in this series and then potentially pushing this series to 6.4 rather than 6.3. -- Jens Axboe