From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77647C02192 for ; Wed, 5 Feb 2025 14:53:03 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2825280018; Wed, 5 Feb 2025 09:53:02 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DD667280017; Wed, 5 Feb 2025 09:53:02 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C9FB9280018; Wed, 5 Feb 2025 09:53:02 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 99ACE280017 for ; Wed, 5 Feb 2025 09:53:02 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 575D5B13C8 for ; Wed, 5 Feb 2025 14:53:02 +0000 (UTC) X-FDA: 83086183404.23.E1DD5AE Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf02.hostedemail.com (Postfix) with ESMTP id A01808000F for ; Wed, 5 Feb 2025 14:53:00 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738767180; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Sdrun7I5cFymJ2TKCUwNxoSHz3b1/AnwDfYA5ofqh4E=; b=H9g7lZ1HIt0vOXBI6iIDQexkzvDIPevcw9XLkeeu1qDN7i/ZZQOb8qV4sGCYFstPsLerCG CTOKD91MX5mrH3pwaqh7vJhTrBIYySkZzKALVst7Ed4yBbO04K41CW+9UJa0dnaW1ivPqD RCDMjslPYAERQWxynTlY3kdMyO6YEF4= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=pass (imf02.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738767180; a=rsa-sha256; cv=none; b=JDlqY7TBkhW4Ss2Z2LpJSTyebgspCbp86zMo3RHBpfOOzYfKSG7SDxXv6i6P3e8MLZmKre jwzcF7mVbjNEbJYKz2/Qfi8hF1P5vGrqnYxxW7HlXykT6pU7wro4g9aozaUT/RRioNtKef 5BGiPRTUzqwqDN2NrgXv+oAEJwVz2zc= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tfglK-000000008PA-1xy6; Wed, 05 Feb 2025 09:52:22 -0500 Message-ID: <1f687692160c4c4574588fd2815ab912892ed10c.camel@surriel.com> Subject: Re: [PATCH v8 10/12] x86/mm: do targeted broadcast flushing from tlbbatch code From: Rik van Riel To: Peter Zijlstra Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Manali Shukla , David.Kaplan@amd.com Date: Wed, 05 Feb 2025 09:52:22 -0500 In-Reply-To: <20250205135156.GI14028@noisy.programming.kicks-ass.net> References: <20250205014033.3626204-1-riel@surriel.com> <20250205014033.3626204-11-riel@surriel.com> <20250205135156.GI14028@noisy.programming.kicks-ass.net> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: A01808000F X-Stat-Signature: ar6wc3acjr6msnoir35156z45zd7se1u X-HE-Tag: 1738767180-140753 X-HE-Meta: U2FsdGVkX19H53uIx60vhi2Z7OyHGpLhsZuLP/B8QXoUeJphkpGeR98eCX5aW3DT5JtH7V/vLGhiqU7bO/8pV+iHREh0z5ZmdHU8SFura8dueGP4MtcJqQu7Z5jEibEGFZdtTUGi4pNAUYVfx1ldZwkQaDwCESknBZ2vTi1knJ8NcGCJRYZ2eeOvdsNTZuna1RPo1/J2m5IC2DdVebTXGmmE2rZcGFuRWHyi2sISp0xUpDEHfgxvB7ILhitIsx2SSSiFfICy00A3WsQ9mRrC2RkhN5drY/0F8OCCOGdDZXgB4NG6WgWbZNBiPjp53Ts/cg3CizpM3vg4OXrWVHUkKAueIEKOlB8FFQEZQ9weVNSC6OOXjX6WJlQkyuPpFYFmcs8YXgrP1r9eDrW9/MqA89pXo2b1MNPvqZ3yj5uhmsI+Di40b1EOyh1RBuk8zcX6EULXNgbMJzAu3OvNvZzuUB43xgSsa/7Gw23EEiX4s67dyxcDdxQfMGbKxPfkLAF64PV+Wsk/7Xksr6N0R4zpyet5xncyyQ5NDPRcn1AaoSNpL6/wzmB1OcajGmsMlZfql/e1vJdgL4XdxZOgaqiEnWlC0qXbiTD6s5rrLnnnHclvqALHo8DCGUYsjYTauBV40hY7gH1qOAQYbimQXeBzTL1i13Cq/OtFFa/AHJ+loD8M5tuBbZ7QGrZaKiHuu6TtZMA8GPITFQBhZKLPIAY6mumXC08rUAqCBnsKuP2IfQNY5ve5J1XcKtpf+YXk2nYT0uUYcewM54WqtlebU8bpMUblgwT/fTZlhDZnzS0DVNCbnWsO6AtPK5ufD2nPJUONu/ZmZaX9LjB8SJD3nRhYwnLk0WrGsZywLJmFbngnMuWjp7faWy15WPfUcwilsEd4ZA4aHuAoQ84dMCMA1NdkYmqGevYnpx5MbnsKywL6zBhOqM9R0Bn/wPjHjq/uNC5AN7Q/hTg3lZECTtOnlCM YEjI3tFx hs1+TMSdC4n8kr5U5Hnrc4zQw9JhQA1X2L5M+2GQzGEteYuu/ipNTaCgY6C39qDM0JZX/Oi2e+Y8z4NMFtGCXNcItRU8K8JIShdetPu60dSm18zYq5tHEKpqbofU3w5S48SnHnalnd04y/GLXpjZvbeex5/yGDRfLCWmWxf6SRqoDcHoxU6M4V3vcPOoJvXnnqtQ1U+U1wJDcetEfG7LYjG/4DKHsEVEBzoI/h9zSQDcXq8itndPKUdt33Mx0RLyxD/OtDauN7UAcRz1wLSsq4EIx+ITcOk5eq8Op1VX9/jCrCVdfwNXT5GrWTp4aUFymRma0KOz0E8Itg7/+vR78AJEnD3ey7x+2oroYldhixM5YD59bnCjC7jr5hPXAhuvcJpJXBXh3ivQCvlCOXgzWQKn5tWbq59kCmgRprRGpmAK+0WA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 2025-02-05 at 14:51 +0100, Peter Zijlstra wrote: >=20 > How about we do something like this instead? >=20 > This keeps all the TLBSYNC in the same task as the INVLPGB, without > making things complicated and allowing random CR3 writes in between > them -- which makes my head hurt. I like your idea better! Guess I should go make and test a v9 with the WARN_ONCE in patch 3, and these changes :) --=20 All Rights Reversed.