From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0F76AC433EF for ; Wed, 29 Sep 2021 08:59:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 980E4613A6 for ; Wed, 29 Sep 2021 08:59:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 980E4613A6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codeaurora.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 258746B007E; Wed, 29 Sep 2021 04:59:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1E130940011; Wed, 29 Sep 2021 04:59:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 082136B0081; Wed, 29 Sep 2021 04:59:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0158.hostedemail.com [216.40.44.158]) by kanga.kvack.org (Postfix) with ESMTP id E68396B007E for ; Wed, 29 Sep 2021 04:58:59 -0400 (EDT) Received: from smtpin17.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9297B2FD84 for ; Wed, 29 Sep 2021 08:58:59 +0000 (UTC) X-FDA: 78640011198.17.A770B70 Received: from m43-7.mailgun.net (m43-7.mailgun.net [69.72.43.7]) by imf09.hostedemail.com (Postfix) with ESMTP id CD19F3000106 for ; Wed, 29 Sep 2021 08:58:58 +0000 (UTC) DKIM-Signature: a=rsa-sha256; v=1; c=relaxed/relaxed; d=mg.codeaurora.org; q=dns/txt; s=smtp; t=1632905939; h=Content-Transfer-Encoding: Content-Type: In-Reply-To: MIME-Version: Date: Message-ID: From: References: Cc: To: Subject: Sender; bh=lCRl9tb/bosLKkvyhrvHol20i0z076BczTy3dEuygxU=; b=ZmEXYVTdSuikDNWa+H2wYWdRcKLm6GUA+VBUzVvYcM1exaqPhwN0N9JKnAsunnRssC/rFkSp 6FR64K7DaCv+D78Vb31qYGzcgxsotGMycC06iLiiNLoYrGIbBBwlKYwD9nv1qeRKIo+AVvBo +21oY5Z8xihq+IwUBGeQIrxS268= X-Mailgun-Sending-Ip: 69.72.43.7 X-Mailgun-Sid: WyIwY2Q3OCIsICJsaW51eC1tbUBrdmFjay5vcmciLCAiYmU5ZTRhIl0= Received: from smtp.codeaurora.org (ec2-35-166-182-171.us-west-2.compute.amazonaws.com [35.166.182.171]) by smtp-out-n02.prod.us-west-2.postgun.com with SMTP id 61542ad1a5a9bab6e822310c (version=TLS1.2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256); Wed, 29 Sep 2021 08:58:57 GMT Received: by smtp.codeaurora.org (Postfix, from userid 1001) id 9D055C4360D; Wed, 29 Sep 2021 08:58:56 +0000 (UTC) Received: from [192.168.0.109] (unknown [49.204.182.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: faiyazm) by smtp.codeaurora.org (Postfix) with ESMTPSA id 6763DC4338F; Wed, 29 Sep 2021 08:58:54 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 smtp.codeaurora.org 6763DC4338F Subject: Re: [PATCH v1] mm: page_alloc: Add debug log in free_reserved_area for static memory To: David Hildenbrand , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Cc: guptap@codeaurora.org References: <1632819849-511-1-git-send-email-faiyazm@codeaurora.org> <248ec931-7c16-3e2d-cc8f-8ce0dd4e923b@redhat.com> <0149edd5-fe7f-2786-413c-6de2eab3e30c@codeaurora.org> From: Faiyaz Mohammed Message-ID: <1f6708d2-1ca8-6d1f-d9f0-855f2df755ed@codeaurora.org> Date: Wed, 29 Sep 2021 14:28:51 +0530 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: CD19F3000106 X-Stat-Signature: j3rxqm8rceks74y474mcwtnsd9r8daw1 Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=mg.codeaurora.org header.s=smtp header.b=ZmEXYVTd; spf=pass (imf09.hostedemail.com: domain of "bounce+d06763.be9e4a-linux-mm=kvack.org@mg.codeaurora.org" designates 69.72.43.7 as permitted sender) smtp.mailfrom="bounce+d06763.be9e4a-linux-mm=kvack.org@mg.codeaurora.org"; dmarc=none X-HE-Tag: 1632905938-81855 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 9/28/2021 4:46 PM, David Hildenbrand wrote: > On 28.09.21 12:53, Faiyaz Mohammed wrote: >> >> >> On 9/28/2021 4:09 PM, David Hildenbrand wrote: >>> On 28.09.21 11:04, Faiyaz Mohammed wrote: >>>> For INITRD and initmem memory is reserved through "memblock_reserve" >>>> during boot up but it is free via "free_reserved_area" instead >>>> of "memblock_free". >>>> For example: >>>> [=C2=A0=C2=A0=C2=A0 0.294848] Freeing initrd memory: 12K. >>>> [=C2=A0=C2=A0=C2=A0 0.696688] Freeing unused kernel memory: 4096K. >>>> >>>> To get the start and end address of the above freed memory and to >>>> account >>>> proper memblock added memblock_dbg log in "free_reserved_area". >>>> After adding log: >>>> [=C2=A0=C2=A0=C2=A0 0.294837] memblock_free: [0x00000083600000-0x000= 00083603000] >>>> free_initrd_mem+0x20/0x28 >>>> [=C2=A0=C2=A0=C2=A0 0.294848] Freeing initrd memory: 12K. >>>> [=C2=A0=C2=A0=C2=A0 0.695246] memblock_free: [0x00000081600000-0x000= 00081a00000] >>>> free_initmem+0x70/0xc8 >>>> [=C2=A0=C2=A0=C2=A0 0.696688] Freeing unused kernel memory: 4096K. >>>> >>>> Signed-off-by: Faiyaz Mohammed >>>> --- >>>> =C2=A0=C2=A0 mm/page_alloc.c | 5 +++++ >>>> =C2=A0=C2=A0 1 file changed, 5 insertions(+) >>>> >>>> diff --git a/mm/page_alloc.c b/mm/page_alloc.c >>>> index b37435c..f85c3b2 100644 >>>> --- a/mm/page_alloc.c >>>> +++ b/mm/page_alloc.c >>>> @@ -8129,6 +8129,11 @@ unsigned long free_reserved_area(void *start, >>>> void *end, int poison, const char >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 pr_info= ("Freeing %s memory: %ldK\n", >>>> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0 s, pages << (PAGE_SHIFT - 10)); >>>> =C2=A0=C2=A0 +#ifdef CONFIG_HAVE_MEMBLOCK >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 memblock_dbg("memblock_f= ree: [%#016llx-%#016llx] %pS\n", >>>> +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 = __pa(start), __pa(end), (void *)_RET_IP_); >>>> +#endif >>> >>> IMHO, the "memblock_free" part is misleading. Something was allocated >>> early via memblock, then we transitioned to the buddy, now we're free= ing >>> that early allocation via the buddy. >>> Yes, we're freeing the early allocation via buddy, but for proper >> memblock accounting we need this debug print. >> >=20 > What do you mean with "accounting" ? These are debug statements. >=20 >=20 Yes, these are debug statements, which help to know the a-b address belongs to x callsite. This info is required when memblock=3Ddebug is passed through command line and CONFIG_HAVE_MEMBLOCK is enabled. Thanks, Mohammed Faiyaz