From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3ED8C02194 for ; Thu, 6 Feb 2025 18:21:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 338D86B0083; Thu, 6 Feb 2025 13:21:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2E8FD6B0085; Thu, 6 Feb 2025 13:21:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 189FC6B0088; Thu, 6 Feb 2025 13:21:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id F033D6B0083 for ; Thu, 6 Feb 2025 13:21:53 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 60E88B2519 for ; Thu, 6 Feb 2025 18:21:52 +0000 (UTC) X-FDA: 83090338464.06.6748A4E Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.14]) by imf29.hostedemail.com (Postfix) with ESMTP id A7E5F120010 for ; Thu, 6 Feb 2025 18:21:49 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IpliMfrz; spf=pass (imf29.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738866110; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xQAs6T68fQVNISVvBc3Y6QXOY+qEKxtcmNPZtJrj1/Y=; b=Wxt4bJmL7SscPNJk7zzRTHI1uYXMFe9/9BphEbc72LDO3VVs8qA3uFfJYv7UJhLzjGklHQ awBjB/Hbx6ZMQ37P7tBTrQZk3O5J8n7gNHr3ma/fDhuzdn6clCr6AD+22SDYFWtpSD++F+ qSa8XSWTKMlXTZQzfyRx5GRYxX3phSI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b=IpliMfrz; spf=pass (imf29.hostedemail.com: domain of dave.hansen@intel.com designates 198.175.65.14 as permitted sender) smtp.mailfrom=dave.hansen@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738866110; a=rsa-sha256; cv=none; b=Cqq/iY7oPCdKhU6c0tC8d/mGjIeekk+1gCVdVo5KL/mk5ZXiSxeymyNNfYHu0zeug6HGxY Ur2aj7Oso5wS3xlBIdDOO67bb3+VTz6ouYbslHGjv330QW46lYMk6MJ1f3nEDXE5KFJo2b i8flhWJZOy5YDOrVwYQIttdXXnhHcZk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1738866110; x=1770402110; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=weAKqXf6Y8AhG7m0BqxFtr8VPRuv1H8LfjKFnuTDoZ8=; b=IpliMfrzjsvR/X2OocCnILDyv8cQ5JcyH4CSD/OULpiOVUJhlY1N0g3v SA73J4pipDbaMuHG106g9WWc+LZSj17rslorWWJVyJ4s8J/d0coVa7nS+ XETp1i4qBt63sHg1qpsqQNlUlgdH6605h4F9a6CsNlySxl6lcm6AeCh7c dX6ElI7EZEtl830j+hoPP9/QxpGdENnsiOSnoKsPyGCvfcyyZGb+uK+Le n8Guop/qEy7KHkZ7hZwLXIFdaHLKSMU9aXrxleJo6MGv8xgfh49u2ow1H u/anpU5VgcgK85ajkMVBItJY7JYVP4/dqXEocLjbw+caUD6cInaTQp5Xm Q==; X-CSE-ConnectionGUID: eodAY5UzRtmpmblvk76Wcg== X-CSE-MsgGUID: kfnIcqlfQj244ZZdQostog== X-IronPort-AV: E=McAfee;i="6700,10204,11336"; a="43246762" X-IronPort-AV: E=Sophos;i="6.13,264,1732608000"; d="scan'208";a="43246762" Received: from fmviesa009.fm.intel.com ([10.60.135.149]) by orvoesa106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2025 10:21:36 -0800 X-CSE-ConnectionGUID: 0VPAEPdzT9ONVf+us53e9A== X-CSE-MsgGUID: jDcTGLTCSEyB/s4rpfu72g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.13,264,1732608000"; d="scan'208";a="111892478" Received: from dnelso2-mobl.amr.corp.intel.com (HELO [10.125.111.17]) ([10.125.111.17]) by fmviesa009-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 Feb 2025 10:21:34 -0800 Message-ID: <1f3f60b3-1741-4ced-951c-8e103970170f@intel.com> Date: Thu, 6 Feb 2025 10:21:36 -0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v8 3/5] x86/pkeys: Update PKRU to enable all pkeys before XSAVE To: Dmitry Vyukov , aruna.ramakrishna@oracle.com, mathieu.desnoyers@efficios.com, peterz@infradead.org, paulmck@kernel.org, boqun.feng@gmail.com Cc: dave.hansen@linux.intel.com, jannh@google.com, jeffxu@chromium.org, jorgelo@chromium.org, keescook@chromium.org, keith.lucas@oracle.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, mingo@kernel.org, rick.p.edgecombe@intel.com, sroettger@google.com, tglx@linutronix.de, x86@kernel.org References: <20240802061318.2140081-4-aruna.ramakrishna@oracle.com> <20250204100134.1843654-1-dvyukov@google.com> From: Dave Hansen Content-Language: en-US Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20250204100134.1843654-1-dvyukov@google.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: A7E5F120010 X-Stat-Signature: o7dyub18brug9boxo57i3o11ks55qkan X-Rspamd-Server: rspam03 X-HE-Tag: 1738866109-336016 X-HE-Meta: U2FsdGVkX19QMFsX38Nl2EFXsxy7C7CPBXQ8B3YEjEAVkhXs5BqgPZk++balnyV7tUxJOb/Ci7Xx4VcuybgjT9Mf25NyeNZrj454a7H8cgHVMSViDvEjVSiZLOYnTvKpbAur+CD+EYU0eaPIe5Pstbo9T7bfIc6SrNUjMLSzuMX9N0w3NIHv7L/lPxw4uIQt/Qb0BVxIHz0dEH//RsEE3mkHY+OpTyo0Z8qcx14jIIbSxtQihb1UtSPG/bD6plvl9FLKHNnOzhxzsFJyykm3QQaA0Qk2an8z8lLxgCf48+K0wg2VmHAQZbUVyqtSGyUHD2P1KwhNwQeNi+uwbgss3q/Il9WAu9iYCLTeL3OEwU8er2JEFdst1kUHBEj4f32Ics3Jl9bK1HyYR2bXnWoce8+DEILuzfgTkjrxDWgE3rZRyvg9I3p5VJ2gm9Pcp3Hs3Kj7XhrXhwS+GITmUK2QwtJfY5jR0g+nDEgu6eHf4gffzQr8tm7HCQ7NOaTRtEbG6gYBprQVu7IiWYtTfgIRT+y79JuHWQqoQxKv8ug1Wr1eLaRFBl51nnRHVl9JVmfRb29KjYElOQj+/fiCtuioReeReR1tY/EaBJENebThbq30JplSLHQfgR04fZ1KJQwn69s6wJ84RJ3jOhraD44NeD4nLlCKH10Ksc/wmRMCJBGQ4ep2zINFM+mH4o/wyW9CF4WwmdzUuv572wiM3Ed6BRrE9yK3alUeczSX2y/Yc7YWVkltgkJJTv7zvldO5JTM+7AmEpxHDKmh98oV0bHLAZ1pNZt7nyMjHzkK+ycbLsPGkAzibB1HX9vD/yy+PuF+JGHSJdWmfqdokL1HAaGHvJzn2fhwmrVbPIf6iNkZg2tG7Llh4q2aE5dAFtCIj7rtpw4UbFSqWQ04OIXGWEsde8TafwCX0ojwnR2f7vEhgLrKGo4CWaLDCp+1HRpg8mC/0CuQe03lSWMTH706PKl 7CygmZmW ep4vaE6see05zS4y+kUO24zvMnJldpBv/G6LxaKn/YvU1AB/tL6Bjch1nbUbUQMZOilozbthO0k4PMq03+OHoP19dmbbw/cR+Kl1idFhdMk1I4KHronjLbHLTz6YbJSsGdJkBFxBIriAllffuNzHfimhnSGY/m5wv47ZLIHf/Z3HrSUvotoq6PwnOPFwMFJ7bMGzHK07skh4g677DoA8s2vquD9zxIh7GOuaZLg+1vPh0GohKQl1By51GRCYlEa9l8mb7rJGFpqvX+eReLsms+J0XPQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2/4/25 02:01, Dmitry Vyukov wrote: >> But this updated PKRU value is also pushed onto the sigframe, which >> means the register value restored from sigcontext will be different from >> the user-defined one, which is unexpected. Fix that by overwriting the >> PKRU value on the sigframe with the original, user-defined PKRU. > > This unfortunatly seems to be broken for rseq user-space writes. Hi Dmitry, Are you saying that Aruna's patch caused a regression in the rseq code? Or that the rseq code has a separate but similar issue to the one that Aruna's patch fixed?