From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 45158C27C53 for ; Fri, 7 Jun 2024 07:00:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CC9AB6B009C; Fri, 7 Jun 2024 03:00:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C796C6B009D; Fri, 7 Jun 2024 03:00:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B42AC6B009E; Fri, 7 Jun 2024 03:00:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 946926B009C for ; Fri, 7 Jun 2024 03:00:15 -0400 (EDT) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3F5A6A1474 for ; Fri, 7 Jun 2024 07:00:15 +0000 (UTC) X-FDA: 82203193590.23.617A46F Received: from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187]) by imf22.hostedemail.com (Postfix) with ESMTP id 88558C0027 for ; Fri, 7 Jun 2024 07:00:12 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717743613; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=zU1F+urRIz5PkIKbbq9WBkc2TQw8ANDZshCRZA9+xwQ=; b=RgRmUFJboLg0KxWg4wGtX5mIH/RArP7Pe1eURuWwal3OQcZc8Bwg3yTkp9DIvufmpLZ1kB JfQX5os+9gyE+0jbvGrBdZCzwxf3+PbKSdamSLJEa9DqvwrdnFhQ5dvNC6eextY0Osezh9 u6aZB6c2eCOps18oKvnzdhr6gdJHS/U= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf22.hostedemail.com: domain of linmiaohe@huawei.com designates 45.249.212.187 as permitted sender) smtp.mailfrom=linmiaohe@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717743613; a=rsa-sha256; cv=none; b=RhyZCspauPKiGfrCMSX7ubI/lR2h60JliUa4fcfEc71y0Y905UIxpgm0ebbWSgDlGmsKs2 gJEkXherr3VkSBVCaiesFsbiPqTOOL5SCzoAdm7zRKWuNjAB9gL53oYCq0R0cT4lQVbZ1C PrUd9hTFALMze8Q2uQPbqixjW7Bz6qY= Received: from mail.maildlp.com (unknown [172.19.163.252]) by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4VwX6K4fg1zsTTP; Fri, 7 Jun 2024 14:56:09 +0800 (CST) Received: from canpemm500002.china.huawei.com (unknown [7.192.104.244]) by mail.maildlp.com (Postfix) with ESMTPS id 6EF9C18007E; Fri, 7 Jun 2024 15:00:08 +0800 (CST) Received: from [10.173.135.154] (10.173.135.154) by canpemm500002.china.huawei.com (7.192.104.244) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Fri, 7 Jun 2024 15:00:07 +0800 Subject: Re: [PATCH v2 10/13] mm/memory-failure: move some function declarations into internal.h To: Matthew Wilcox CC: , , , , , , References: <20240606063247.712575-1-linmiaohe@huawei.com> <20240606063247.712575-11-linmiaohe@huawei.com> From: Miaohe Lin Message-ID: <1f3bdaf8-bc9b-1dc9-b06c-e670a906dc1b@huawei.com> Date: Fri, 7 Jun 2024 15:00:07 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.6.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.173.135.154] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To canpemm500002.china.huawei.com (7.192.104.244) X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 88558C0027 X-Stat-Signature: wz5e6t14q8utf6y966u63eu37fecn9er X-Rspam-User: X-HE-Tag: 1717743612-52695 X-HE-Meta: U2FsdGVkX1/fcRYRtjIIq6M9M+zK062O71BBQROlXV7EYeSM6bE9tq/4v+uUKEzcRyA5qNxApiNMF9Ng7zjK9tx2MnXlJ5qkFurhTHYfzRBuvem9EbvvlnJWXzmhp9mxfgWKAwsGgAvX70t1Hjj0e6gSuxMfasiLjXNOn0Bba/Z0axvTm9cbs1XDZCYC4TwyhW/z/Sn6SZUz+EvpgU6K9GKgNWLtTPyOzIyvbb41U9H6I1EGeMnvO/TaSCvXXk0rwso13ggdwDEZkvIK01uOqvsBHhnb+IvJsL5aWCaPVW7XnzazarnXEpfaRA93AqI0IDaovz2p7Vp6c03otAPYKFGY+JxKkh62L8rdb4IRtXmV4dnTgO2tzv/Y6lpTxvJasRJGiSQReSQmdQtt8exYcvD9yq5MLSGrIo988wyX52vqWzcXkZXDXa2kRGprJQzEn6e16w2nm74QBMtC/yx3xN75MRacVFsYSihW8cHKfri6zYRockZcraZyty5TnFx3KIQh8cRBh3TEc50dwlFA9MsQFeH4jW/1pyruKwlj4OZ7gKnLMXVCGEUB2fdH0kXadZ3Pn57PPnBbaD/J46aHnj2DMpol3rvUekYLDQbfsGv0iJcz1jCxXLL30bs7/gQu9Dh5orQP30KzxrL2TpHi1g1pEB/Gr/5RmjkBDH0w7jfuj+G5plGiuPnZjJWyNMxUSAw5yVFO3jdGAt8WovB649UBj++sIRgTkQhnPv9qb9z0dX826MVqzV4jW/afbBzH20X50kIxZ5rqnqEDCRIU7ZpdxTDX70t6JnVBPXDye3Mf3kUqEX3Q6wNaUVpJILy7LKm/+Zy4EO9mqGHNb79Sa5HNIkppSrQHTrBAeOXi8wWcRVdqwncKg/GXhv86eKM2tMY8NVWiEJ7XF1b7lhWLIDKyG6OnVI2jsc51rvg2v+pwb0CfFfi1rThdJrLV6wK9bIUM42Dno1mzvhDtaKM JWrdwcon PdADrXc6iGxQ09tXHGtIy2CBV6zjATOHsfyjTlpujdDf0zTyT3D1t1lla/xm4kqCzWMJv/WUpX5+Cj6xni0fpquwDor+wxSl2ZMAFL0UA/jNVAE2v1ITmRWwROwpbMOCFrLHHEccWgEFJEmFH3qnLvfLn7mVAbHLJ0GSl+iCp2e4GsO0IRjjgl3fhuE29rFUbHN7ucUsGIkJvJ90= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/6/7 11:47, Matthew Wilcox wrote: > On Thu, Jun 06, 2024 at 02:32:44PM +0800, Miaohe Lin wrote: >> +++ b/mm/internal.h >> @@ -1077,6 +1077,16 @@ extern u64 hwpoison_filter_flags_mask; >> extern u64 hwpoison_filter_flags_value; >> extern u64 hwpoison_filter_memcg; >> extern u32 hwpoison_filter_enable; >> +#define MAGIC_HWPOISON 0x48575053U /* HWPS */ >> +extern void SetPageHWPoisonTakenOff(struct page *page); >> +extern void ClearPageHWPoisonTakenOff(struct page *page); >> +extern bool take_page_off_buddy(struct page *page); >> +extern bool put_page_back_buddy(struct page *page); > > s/extern// for function declarations. Will do in next version. Thanks. .