From: Miaohe Lin <linmiaohe@huawei.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: <akpm@linux-foundation.org>, <tony.luck@intel.com>,
<bp@alien8.de>, <nao.horiguchi@gmail.com>, <linux-mm@kvack.org>,
<linux-kernel@vger.kernel.org>, <linux-edac@vger.kernel.org>
Subject: Re: [PATCH v2 10/13] mm/memory-failure: move some function declarations into internal.h
Date: Fri, 7 Jun 2024 15:00:07 +0800 [thread overview]
Message-ID: <1f3bdaf8-bc9b-1dc9-b06c-e670a906dc1b@huawei.com> (raw)
In-Reply-To: <ZmKC0Z3omr04grkj@casper.infradead.org>
On 2024/6/7 11:47, Matthew Wilcox wrote:
> On Thu, Jun 06, 2024 at 02:32:44PM +0800, Miaohe Lin wrote:
>> +++ b/mm/internal.h
>> @@ -1077,6 +1077,16 @@ extern u64 hwpoison_filter_flags_mask;
>> extern u64 hwpoison_filter_flags_value;
>> extern u64 hwpoison_filter_memcg;
>> extern u32 hwpoison_filter_enable;
>> +#define MAGIC_HWPOISON 0x48575053U /* HWPS */
>> +extern void SetPageHWPoisonTakenOff(struct page *page);
>> +extern void ClearPageHWPoisonTakenOff(struct page *page);
>> +extern bool take_page_off_buddy(struct page *page);
>> +extern bool put_page_back_buddy(struct page *page);
>
> s/extern// for function declarations.
Will do in next version.
Thanks.
.
next prev parent reply other threads:[~2024-06-07 7:00 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-06 6:32 [PATCH v2 00/13] Some cleanups for memory-failure Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 01/13] mm/memory-failure: simplify put_ref_page() Miaohe Lin
2024-06-06 6:46 ` Kefeng Wang
2024-06-07 3:28 ` Miaohe Lin
2024-06-07 4:38 ` Kefeng Wang
2024-06-06 6:32 ` [PATCH v2 02/13] mm/memory-failure: remove MF_MSG_SLAB Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 03/13] mm/memory-failure: add macro GET_PAGE_MAX_RETRY_NUM Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 04/13] mm/memory-failure: save some page_folio() calls Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 05/13] mm/memory-failure: remove unneeded empty string Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 06/13] mm/memory-failure: remove confusing initialization to count Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 07/13] mm/memory-failure: simplify unneeded hwpoison_filter() variant Miaohe Lin
2024-06-06 17:15 ` kernel test robot
2024-06-07 3:30 ` Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 08/13] mm/memory-failure: use helper macro task_pid_nr() Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 09/13] mm/memory-failure: remove obsolete comment in unpoison_memory() Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 10/13] mm/memory-failure: move some function declarations into internal.h Miaohe Lin
2024-06-07 3:47 ` Matthew Wilcox
2024-06-07 7:00 ` Miaohe Lin [this message]
2024-06-06 6:32 ` [PATCH v2 11/13] mm/memory-failure: fix comment of get_hwpoison_page() Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 12/13] mm/memory-failure: remove obsolete comment in kill_proc() Miaohe Lin
2024-06-06 6:32 ` [PATCH v2 13/13] mm/memory-failure: correct comment in me_swapcache_dirty Miaohe Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f3bdaf8-bc9b-1dc9-b06c-e670a906dc1b@huawei.com \
--to=linmiaohe@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=bp@alien8.de \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=nao.horiguchi@gmail.com \
--cc=tony.luck@intel.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox