From: Hugh Dickins <hughd@google.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Hugh Dickins <hughd@google.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Yang Shi <shy828301@gmail.com>,
Zach O'Keefe <zokeefe@google.com>
Subject: Re: [PATCH 1/2] mm/MADV_COLLAPSE: set EAGAIN on unexpected page refcount
Date: Thu, 9 Feb 2023 13:50:30 -0800 (PST) [thread overview]
Message-ID: <1f344fc1-834d-f1df-8a2c-79918be5b22@google.com> (raw)
In-Reply-To: <20230209132846.122ad88e1c2bd0603a630e5c@linux-foundation.org>
On Thu, 9 Feb 2023, Andrew Morton wrote:
>
> Thanks, I'll merge [1/2] into mm-hotfixes.
Great, thanks.
>
> I'm not seeing anything in the [1/2] changelog which indicates that a
> backport is needed. IOW,
Correct: it's just changing the errno for some racy cases from "you're
wrong, don't bother me again" to "it might be worth having another go":
not fixing an instability, as 2/2 was.
>
> # cat .signature
> When fixing a bug, please describe the end-user visible effects of that bug.
If whatever's being run by the end-user is coded to try again on -EAGAIN,
then the end-user will less often see occasional unexplained failures.
Hugh
next prev parent reply other threads:[~2023-02-09 21:50 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 1:57 Zach O'Keefe
2023-01-25 1:57 ` [PATCH 2/2] mm/MADV_COLLAPSE: catch !none !huge !bad pmd lookups Zach O'Keefe
2023-01-25 12:54 ` kernel test robot
2023-01-25 13:38 ` kernel test robot
2023-01-25 18:06 ` [PATCH 1/2] mm/MADV_COLLAPSE: set EAGAIN on unexpected page refcount Yang Shi
2023-01-25 19:15 ` Zach O'Keefe
2023-02-09 5:09 ` Hugh Dickins
2023-02-09 21:28 ` Andrew Morton
2023-02-09 21:50 ` Hugh Dickins [this message]
2023-02-09 22:12 ` Andrew Morton
2023-02-09 22:29 ` Zach O'Keefe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1f344fc1-834d-f1df-8a2c-79918be5b22@google.com \
--to=hughd@google.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shy828301@gmail.com \
--cc=zokeefe@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox