From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C6D7AC77B7E for ; Tue, 2 May 2023 16:12:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 08984900002; Tue, 2 May 2023 12:12:46 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 03A426B0075; Tue, 2 May 2023 12:12:45 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E4362900002; Tue, 2 May 2023 12:12:45 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by kanga.kvack.org (Postfix) with ESMTP id C39E86B0074 for ; Tue, 2 May 2023 12:12:45 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1683043965; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9eeDMuJZPu6ODufcZPGNKxI5KHuttnVPRF879rkqTz8=; b=cQnG4DdNYdOhHazE3htSj/DonSxwedTaMSDjqT92vixMWyCwtULOSqillkoKGeMjoSqEt3 jU+ovfA1bhesE22X6FtK4po3E9Kk39eix9x7lahDAHcgJE/Yduat2XaRss1PCs9kU6Raat r7sc2GV0sq2jrUAlCyy4gTyObF6RLSU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-299-X0JlRpYvM2OfakGxiyYJcg-1; Tue, 02 May 2023 12:12:44 -0400 X-MC-Unique: X0JlRpYvM2OfakGxiyYJcg-1 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-3f3157128b4so109558005e9.0 for ; Tue, 02 May 2023 09:12:44 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683043963; x=1685635963; h=content-transfer-encoding:in-reply-to:organization:from:references :cc:to:content-language:subject:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=9eeDMuJZPu6ODufcZPGNKxI5KHuttnVPRF879rkqTz8=; b=VnGp824JpWde64Nh8CM6rRa4/RHb/GdxlRVKQ0pUJSl7E+OuH0aUu4ntCmB9aPcQmI odS6tUsTf0FxMk52cwvsWsrSY4+6FtjySzBCVW/dEHp4pYYNOFJDReVYNi5hTYj7MU00 iRR1LeujT5+uPuCh/JV2mrTfBYq0L9V1Zdla9aHw7UqxHHHNWMSUpPO5o8nN4tVqv0Vk xBa0fWZwDwU2CqHVlhlqFQXrpURhMJYYM8jVdQCEf+9zplBKh8GOVGLNqDKTZgBW9ea9 pLbmEexKhLi8SD/DnRv1lvxGLyKB7/NNxNSZNUqqRHrHB3QmSdDMelymigY+zcXiDTwi Hwyg== X-Gm-Message-State: AC+VfDw7ioOtFT5qE0Hvuu9fyGX6jY5uuwRL3Q5EO9KpCfVNajJ6KBb7 /qqN7RQxBasreJALFhtcMC6pxQptDSLfhNNQtn0ZR1LQ0Pe+1qZPAGtGdSZnqzDNA16eVEZXMAT R16eiOr8GuTA= X-Received: by 2002:adf:e911:0:b0:2f6:661:c03c with SMTP id f17-20020adfe911000000b002f60661c03cmr13759790wrm.28.1683043963191; Tue, 02 May 2023 09:12:43 -0700 (PDT) X-Google-Smtp-Source: ACHHUZ50FlsdEb7AJE6SqMVbMDAUvRqWZ/pApIWnjC3i8JYXqQp98IhMaOQg4hPFsdc+YA9Dmgqv7g== X-Received: by 2002:adf:e911:0:b0:2f6:661:c03c with SMTP id f17-20020adfe911000000b002f60661c03cmr13759744wrm.28.1683043962801; Tue, 02 May 2023 09:12:42 -0700 (PDT) Received: from ?IPV6:2003:cb:c700:2400:6b79:2aa:9602:7016? (p200300cbc70024006b7902aa96027016.dip0.t-ipconnect.de. [2003:cb:c700:2400:6b79:2aa:9602:7016]) by smtp.gmail.com with ESMTPSA id v3-20020adfedc3000000b003062c0ef959sm6522031wro.69.2023.05.02.09.12.40 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 02 May 2023 09:12:42 -0700 (PDT) Message-ID: <1f29fe90-1482-7435-96bd-687e991a4e5b@redhat.com> Date: Tue, 2 May 2023 18:12:39 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v6 3/3] mm/gup: disallow FOLL_LONGTERM GUP-fast writing to file-backed mappings To: Jason Gunthorpe Cc: Peter Xu , Matthew Rosato , Christian Borntraeger , Lorenzo Stoakes , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrew Morton , Jens Axboe , Matthew Wilcox , Dennis Dalessandro , Leon Romanovsky , Christian Benvenuti , Nelson Escobar , Bernard Metzler , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Ian Rogers , Adrian Hunter , Bjorn Topel , Magnus Karlsson , Maciej Fijalkowski , Jonathan Lemon , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Christian Brauner , Richard Cochran , Alexei Starovoitov , Daniel Borkmann , Jesper Dangaard Brouer , John Fastabend , linux-fsdevel@vger.kernel.org, linux-perf-users@vger.kernel.org, netdev@vger.kernel.org, bpf@vger.kernel.org, Oleg Nesterov , John Hubbard , Jan Kara , "Kirill A . Shutemov" , Pavel Begunkov , Mika Penttila , Dave Chinner , Theodore Ts'o References: <1ffbbfb7-6bca-0ab0-1a96-9ca81d5fa373@redhat.com> <3c17e07a-a7f9-18fc-fa99-fa55a5920803@linux.ibm.com> <4fd5f74f-3739-f469-fd8a-ad0ea22ec966@redhat.com> From: David Hildenbrand Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.05.23 18:06, Jason Gunthorpe wrote: > On Tue, May 02, 2023 at 05:45:40PM +0200, David Hildenbrand wrote: >> On 02.05.23 17:36, Jason Gunthorpe wrote: >>> On Tue, May 02, 2023 at 11:32:57AM -0400, Peter Xu wrote: >>>>> How does s390 avoid mmu notifiers without having lots of problems?? It >>>>> is not really optional to hook the invalidations if you need to build >>>>> a shadow page table.. >>>> >>>> Totally no idea on s390 details, but.. per my read above, if the firmware >>>> needs to make sure the page is always available (so no way to fault it in >>>> on demand), which means a longterm pinning seems appropriate here. >>>> >>>> Then if pinned a must, there's no need for mmu notifiers (as the page will >>>> simply not be invalidated anyway)? >>> >>> And what if someone deliberately changes the mapping? memory hotplug >>> in the VM, or whatever? >> >> Besides s390 not supporting memory hotplug in VMs (yet): if the guest wants >> a different guest physical address, I guess that's the problem of the guest, >> and it can update it: >> >> KVM_S390_ZPCIOP_REG_AEN is triggered from QEMU via >> s390_pci_kvm_aif_enable(), triggered by the guest via a special instruction. >> >> If the hypervisor changes the mapping, it's just the same thing as mixing >> e.g. MADV_DONTNEED with longterm pinning in vfio: don't do it. And if you do >> it, you get to keep the mess you created for your VM. >> >> Linux will make sure to not change the mapping: for example, page migration >> of a pinned page will fail. >> >> But maybe I am missing something important here. > > It missses the general architectural point why we have all these > shootdown mechanims in other places - plares are not supposed to make > these kinds of assumptions. When the userspace unplugs the memory from > KVM or unmaps it from VFIO it is not still being accessed by the > kernel. Yes. Like having memory in a vfio iommu v1 and doing the same (mremap, munmap, MADV_DONTNEED, ...). Which is why we disable MADV_DONTNEED (e.g., virtio-balloon) in QEMU with vfio. > > Functional bug or not, it is inconsistent with how this is designed to > work. Sorry to say, I *really* don't see how that is supposed to work with a page that *cannot* be faulted back in on demand. -- Thanks, David / dhildenb