From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 324DBC25B74 for ; Thu, 30 May 2024 15:21:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AEB046B009B; Thu, 30 May 2024 11:21:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A9B956B009C; Thu, 30 May 2024 11:21:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 914CB6B009D; Thu, 30 May 2024 11:21:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 739BD6B009B for ; Thu, 30 May 2024 11:21:26 -0400 (EDT) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 9D0388170C for ; Thu, 30 May 2024 15:21:25 +0000 (UTC) X-FDA: 82175426130.13.68EAE99 Received: from mail-ed1-f47.google.com (mail-ed1-f47.google.com [209.85.208.47]) by imf17.hostedemail.com (Postfix) with ESMTP id 6D12640002 for ; Thu, 30 May 2024 15:21:23 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=FlSWmA7n; spf=pass (imf17.hostedemail.com: domain of jbeulich@suse.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=jbeulich@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1717082483; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=gyK+bVeazhd8nGn5gGyIhTnSQCVoq4B2yZL4ZZfp9XE=; b=EeTl/ist/yKH94Z/FdSUFbbYYcAIItEe3F7RHThLGou8IHC6RjJjtPwyRspNqUBsckxZZz ZIQhAj4IvzIBBHJkVIVSuUW8duKxmAkvhmqGNNApiacxj84LOBHGuqDGkIRPY7bSaZ0k60 YR73fbbttXCYcg4Ak9FJM6p9SssLs8w= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=suse.com header.s=google header.b=FlSWmA7n; spf=pass (imf17.hostedemail.com: domain of jbeulich@suse.com designates 209.85.208.47 as permitted sender) smtp.mailfrom=jbeulich@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1717082483; a=rsa-sha256; cv=none; b=rQU3lYE5UbKLMOOSsqialF0AFZwD/oeJrBAcSF2CooYlXYPwm5xZ4j4UPM6xW9EhcHbUSK h2Jg7kxw0Gpj8n9zCmft1LY+KcD+dzOh+qg8YeAgxazi2/AMx3CELsWgFSZ5rwLmAgJQEw OyP9ycnTkrdQXBS99DEqFBTD4k1xhIs= Received: by mail-ed1-f47.google.com with SMTP id 4fb4d7f45d1cf-57a2f032007so74713a12.0 for ; Thu, 30 May 2024 08:21:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=google; t=1717082482; x=1717687282; darn=kvack.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to; bh=gyK+bVeazhd8nGn5gGyIhTnSQCVoq4B2yZL4ZZfp9XE=; b=FlSWmA7nwrgoLzjdVd7lSUASrJ3Agj4I12Dnb+CcJnla9A26v6QlNxfT5hU8FMJfVc payWhWNghhjfLPcd02XmJclnDr0qDOKlrrjAkvn7CWKpJUvaTUlDEr/InhlWE2XCSTok tr3HcgxjR7h85+DPFBd9hm46xpAxl3mDf8l/t4fMcOLTXC8QvhpGyWn1OywzYm99/nNT 6i582VDrD9DQwQ/W+NFE0q0tKs8m+t7FYDPxmC65ZRhF6PJJwkgJuEsZlgVQJso3H/PF GktF7wXEzngWnWCJ3D+XIhBY0M22UuIrA8Iwi/hcQIX+n+YCVGI8n0F2EOn6XYBsYNcw LO2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1717082482; x=1717687282; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gyK+bVeazhd8nGn5gGyIhTnSQCVoq4B2yZL4ZZfp9XE=; b=agNZHKr51vOBoYdqz8MSlWIyx3dBkWTeE5rVAPRCYLVXBKllNfb3Xo5aravBQP2MaG LB3chxrKCc3cTlfkWTuWDfJhR3GiNKZvaJhqOnTdF5WlS6FTTyCLUsnyVX/wamEbHqm6 krsL2ZM3P6gCdlqyQWYUwjlS+7jLi9EXuv4JYuV2KtiE1EvV/jXB0YrDYGTsaseUqb2k f0BmkNmvqMNItGHRFnqESxFfFmxW6X/4MYAmEPW33mJp2W+gejMhXC0m2zP8M/H05JKN iiRRP2iRuLC1rct88aPeOasC6q8BacrrV0illw/d153bG0YdAwTw6Mw+NVdLbzi5jzOs /1jA== X-Gm-Message-State: AOJu0YwWsjrPQd+GTyWAaV7qVfwERNvzoJvvWXK5fjFIsxxiyRgKh5Sn CuBLwgNjVYEc9QTNCqll+FYyxgq+CpPm0vxbUxfU7wi99aOOwlDJAV8olf+Ghh6L1FSb5qPCNkA = X-Google-Smtp-Source: AGHT+IFCgkDLVNzQ5CHfricyYo2pAzDpJGe22D/0bGplsc+f7C4o0my2PjF4ABWKC1E+1FUjAzyahw== X-Received: by 2002:a17:907:2991:b0:a67:5705:8033 with SMTP id a640c23a62f3a-a6757058162mr23015466b.55.1717082481635; Thu, 30 May 2024 08:21:21 -0700 (PDT) Received: from ?IPV6:2003:ca:b724:491c:251a:48e:75b1:a320? (p200300cab724491c251a048e75b1a320.dip0.t-ipconnect.de. [2003:ca:b724:491c:251a:48e:75b1:a320]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a631e324816sm370335566b.15.2024.05.30.08.21.21 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 30 May 2024 08:21:21 -0700 (PDT) Message-ID: <1f282369-daec-4915-93b7-60142429d780@suse.com> Date: Thu, 30 May 2024 17:21:21 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] memblock: make memblock_set_node() also warn about use of MAX_NUMNODES To: Mike Rapoport Cc: "linux-mm@kvack.org" References: <1c8a058c-5365-4f27-a9f1-3aeb7fb3e7b2@suse.com> Content-Language: en-US From: Jan Beulich Autocrypt: addr=jbeulich@suse.com; keydata= xsDiBFk3nEQRBADAEaSw6zC/EJkiwGPXbWtPxl2xCdSoeepS07jW8UgcHNurfHvUzogEq5xk hu507c3BarVjyWCJOylMNR98Yd8VqD9UfmX0Hb8/BrA+Hl6/DB/eqGptrf4BSRwcZQM32aZK 7Pj2XbGWIUrZrd70x1eAP9QE3P79Y2oLrsCgbZJfEwCgvz9JjGmQqQkRiTVzlZVCJYcyGGsD /0tbFCzD2h20ahe8rC1gbb3K3qk+LpBtvjBu1RY9drYk0NymiGbJWZgab6t1jM7sk2vuf0Py O9Hf9XBmK0uE9IgMaiCpc32XV9oASz6UJebwkX+zF2jG5I1BfnO9g7KlotcA/v5ClMjgo6Gl MDY4HxoSRu3i1cqqSDtVlt+AOVBJBACrZcnHAUSuCXBPy0jOlBhxPqRWv6ND4c9PH1xjQ3NP nxJuMBS8rnNg22uyfAgmBKNLpLgAGVRMZGaGoJObGf72s6TeIqKJo/LtggAS9qAUiuKVnygo 3wjfkS9A3DRO+SpU7JqWdsveeIQyeyEJ/8PTowmSQLakF+3fote9ybzd880fSmFuIEJldWxp Y2ggPGpiZXVsaWNoQHN1c2UuY29tPsJgBBMRAgAgBQJZN5xEAhsDBgsJCAcDAgQVAggDBBYC AwECHgECF4AACgkQoDSui/t3IH4J+wCfQ5jHdEjCRHj23O/5ttg9r9OIruwAn3103WUITZee e7Sbg12UgcQ5lv7SzsFNBFk3nEQQCACCuTjCjFOUdi5Nm244F+78kLghRcin/awv+IrTcIWF hUpSs1Y91iQQ7KItirz5uwCPlwejSJDQJLIS+QtJHaXDXeV6NI0Uef1hP20+y8qydDiVkv6l IreXjTb7DvksRgJNvCkWtYnlS3mYvQ9NzS9PhyALWbXnH6sIJd2O9lKS1Mrfq+y0IXCP10eS FFGg+Av3IQeFatkJAyju0PPthyTqxSI4lZYuJVPknzgaeuJv/2NccrPvmeDg6Coe7ZIeQ8Yj t0ARxu2xytAkkLCel1Lz1WLmwLstV30g80nkgZf/wr+/BXJW/oIvRlonUkxv+IbBM3dX2OV8 AmRv1ySWPTP7AAMFB/9PQK/VtlNUJvg8GXj9ootzrteGfVZVVT4XBJkfwBcpC/XcPzldjv+3 HYudvpdNK3lLujXeA5fLOH+Z/G9WBc5pFVSMocI71I8bT8lIAzreg0WvkWg5V2WZsUMlnDL9 mpwIGFhlbM3gfDMs7MPMu8YQRFVdUvtSpaAs8OFfGQ0ia3LGZcjA6Ik2+xcqscEJzNH+qh8V m5jjp28yZgaqTaRbg3M/+MTbMpicpZuqF4rnB0AQD12/3BNWDR6bmh+EkYSMcEIpQmBM51qM EKYTQGybRCjpnKHGOxG0rfFY1085mBDZCH5Kx0cl0HVJuQKC+dV2ZY5AqjcKwAxpE75MLFkr wkkEGBECAAkFAlk3nEQCGwwACgkQoDSui/t3IH7nnwCfcJWUDUFKdCsBH/E5d+0ZnMQi+G0A nAuWpQkjM1ASeQwSHEeAWPgskBQL In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: k1niw7sn7x1m3mgrk1zs7g45zo3qum9x X-Rspamd-Queue-Id: 6D12640002 X-Rspam-User: X-Rspamd-Server: rspam10 X-HE-Tag: 1717082483-943468 X-HE-Meta: U2FsdGVkX1/+XXoRY/VM8w5R+ly4sitC1H28GnrPEJWRCkmnJbOVYMyvoUnLXrAS30AshU9KWawd3qwjaEhI3gNowhhQrObLfxYsiOrRGtoNOcCNMHnj+pL18nGNuUyMpgnzGc91o0S3l7O0ACOpW/4axPpwQC8ymUvwCyoWOyWrJ9sBTiygQS9XX5mhn2QDtvbnkcKM9ehoJdIcdwkPwdFw97GjXyIqXnKN9C6XvrYt7bBIBW82dp810IWHI/hMg0BcjqR3/u4TgfYZTwEiyanl/mSvMnXZFop1gA+MeVesRZOgf339WXvWGoya4uTF75HLMyWiDOlvFwbG1pfwOjzKFHq42D+xtcy6KxJf9oWTNNjeINepWmCFXCGuloHWo+1T1CGXD9Sc03FFv3GUMeEUSLBZjBxkSKZGfIVb7gPM6o0qk1MXWn/NhodwxnQqxYkPAohVVqGD4LMqkmUUQer8MAGtmAt+xON1QlgNlHZkC2MQ0UNiarN6r13eXcj8YWNsF6Q49Q0KeWOF3DctGIUY0PbscKx3Vh9PcMvP06vPswRCFkWwL26WxyW6ho7Vupz4uaeJzrH45pYaxKuqUVX/UJ7fRTXvXfs9Z0fYf/ZBEJE1Rt+NBE7sMcUVCwwgNiu5za7MDRYagGB7nIj77BVSDJGw0c0onBmpIFDw9Xk+oEwuAEubhL/GPYoJdbbMQNy2LM67VTVjgPiDlq4wwrrKBSuDUpN3o3Zwvrbrn+QQmOLcySaYA1Z+vV85lroUXm9jT1S0qRTzAZDkcLwgMX7dCuefV0s0XaRTTVsmkQmjl9b+tldaO6cKVXyRM4LyFkNY5jotPsuvTczfd0hQLJYMIL/ya0J2v/i6YSWS9ILrde2kfu6zgLFjicIMH0e6LEAaD0wrqsoZTJ8tCTvv1zK2IXeGELJXNKv35Uf6OgwuDYHv+HoegSeV4EXvp5jWRlShedAkxr2XOoVjYMq 69rehJtd ACdGPZw/ASGB5YP+BX+r0NGvzJeZcsk0Ne3jRS9czCKKTyZdOvohYvTGjWeujPu3l9iMzptlCYo7gA5yuBnYueQIwAQGSs/jokVGsjKzqiF1/oToE8jNGt+WKorlpOs7Y+jtJztBRyjjKGc2ewWntkupY4ay8Kgvtr/StPAXneqIyT25uFZzoCx+ZPb8NjkiEg8JugW1bkAKSWr1fbXTMeXAotSjTEbTXTH3JTOQq8jxI7/Ce363F8LbN5vCA41tYIA2BRkwASKYT0oORz2QhNlIxvqx5isvS+Q8VsHxhg/ndPvt4gy2ORYyDtqAvgqhqG+RY3GJGp9QeuLEF8jBnaWsa6HPA+3oErednZgWJNzKAMHqVY+gPN/DV9P0Hyqc4s3vujKjag0wtlnPyrYYge9eHXUr+UsKurK0ccgwoMuRTN8Ou7+41rQdiv2CwqBkuvfX25vkpq+4wXhzzipbHqWvkJOmuyj2sI6fItc/cop++PW9iYfTkkJe+sl8kF5J/2OKoHsbfmSwl/3i13TVkRafXvT1dLO5u4dChzR3jenUpOLjpKUOdWd5Y9+sdW6V/W619KkOmlol8mWXaO6yMqsN+u7lTL8m3yVJHZfia7lwvj2Q/jmGFujVtpA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 30.05.2024 09:48, Mike Rapoport wrote: > On Wed, May 29, 2024 at 09:39:10AM +0200, Jan Beulich wrote: >> On an (old) x86 system with SRAT just covering space above 4Gb: >> >> ACPI: SRAT: Node 0 PXM 0 [mem 0x100000000-0xfffffffff] hotplug >> >> the commit referenced below leads to this NUMA configuration no longer >> being refused by a CONFIG_NUMA=y kernel (previously >> >> NUMA: nodes only cover 6144MB of your 8185MB e820 RAM. Not used. >> No NUMA configuration found >> Faking a node at [mem 0x0000000000000000-0x000000027fffffff] >> >> was seen in the log directly after the message quoted above), because of >> memblock_validate_numa_coverage() checking for NUMA_NO_NODE (only). This >> in turn led to memblock_alloc_range_nid()'s warning about MAX_NUMNODES >> triggering, followed by a NULL deref in memmap_init() when trying to >> access node 64's (NODE_SHIFT=6) node data. >> >> To compensate said change, make memblock_set_node() warn on and adjust >> a passed in value of MAX_NUMNODES, just like various other functions >> already do. >> >> Fixes: ff6c3d81f2e8 ("NUMA: optimize detection of memory with no node id assigned by firmware") >> Signed-off-by: Jan Beulich >> Cc: stable@vger.kernel.org >> --- >> This still leaves MAX_NUMNODES uses in various other places. >> Interestingly >> https://lore.kernel.org/lkml/20170309034415.GA16588@WeideMacBook-Pro.local/T/#t >> was a more complete patch which, for an unclear reason, looks to never >> have made it anywhere. IOW the two memblock_set_node() invocations from x86'es >> numa_init() likely also want adjusting, among others. > > They do. And I think that actually would be the right fix. > The warning and nid adjustment in memblock can be added for robustness, but > the calls to memblock_set_node() in x86 should be fixed regardless. And indeed I sent one already: https://lkml.org/lkml/2024/5/29/354 For addressing the regression either is sufficient. Jan