From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E816AC63798 for ; Wed, 25 Nov 2020 16:54:58 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5C7F8206D8 for ; Wed, 25 Nov 2020 16:54:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5C7F8206D8 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C993F6B0070; Wed, 25 Nov 2020 11:54:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C49396B0071; Wed, 25 Nov 2020 11:54:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B5EA86B0072; Wed, 25 Nov 2020 11:54:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0008.hostedemail.com [216.40.44.8]) by kanga.kvack.org (Postfix) with ESMTP id 9E5A86B0070 for ; Wed, 25 Nov 2020 11:54:57 -0500 (EST) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id 66634181AEF1A for ; Wed, 25 Nov 2020 16:54:57 +0000 (UTC) X-FDA: 77523540234.08.maid98_130933427378 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id 49F321819E769 for ; Wed, 25 Nov 2020 16:54:57 +0000 (UTC) X-HE-Tag: maid98_130933427378 X-Filterd-Recvd-Size: 1926 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf32.hostedemail.com (Postfix) with ESMTP for ; Wed, 25 Nov 2020 16:54:56 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 8E1EEABCE; Wed, 25 Nov 2020 16:54:55 +0000 (UTC) Subject: Re: [PATCH 1/7] mm,hwpoison: Refactor get_any_page To: Oscar Salvador , akpm@linux-foundation.org Cc: n-horiguchi@ah.jp.nec.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20201119105716.5962-1-osalvador@suse.de> <20201119105716.5962-2-osalvador@suse.de> From: Vlastimil Babka Message-ID: <1f2561be-15bb-9c74-16e3-719ddc310cb3@suse.cz> Date: Wed, 25 Nov 2020 17:54:54 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 MIME-Version: 1.0 In-Reply-To: <20201119105716.5962-2-osalvador@suse.de> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Bogosity: Ham, tests=bogofilter, spamicity=0.000060, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 11/19/20 11:57 AM, Oscar Salvador wrote: > When we want to grab a refcount via get_any_page, we call > __get_any_page that calls get_hwpoison_page to get the > actual refcount. > get_any_page is only there because we have a sort of retry > mechanism in case the page we met is unknown to us or > if we raced with an allocation. > > Also __get_any_page prints some messages about the page type > in case the page was a free page or the page type was unknown, > but if anything, we only need to print a message in case the > pagetype was unknown, as that is reporting an error down the chain. > > Let us merge get_any_page and __get_any_page, and let the message > be printed in soft_offline_page. > > Signed-off-by: Oscar Salvador Acked-by: Vlastimil Babka