From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1A838C5AD49 for ; Mon, 2 Jun 2025 20:59:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 92D0E6B033D; Mon, 2 Jun 2025 16:59:27 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 8DD6C6B033E; Mon, 2 Jun 2025 16:59:27 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7CC406B033F; Mon, 2 Jun 2025 16:59:27 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 5D74A6B033D for ; Mon, 2 Jun 2025 16:59:27 -0400 (EDT) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1B3C41D7554 for ; Mon, 2 Jun 2025 20:59:27 +0000 (UTC) X-FDA: 83511676374.25.1C7112A Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf15.hostedemail.com (Postfix) with ESMTP id 9D43DA0005 for ; Mon, 2 Jun 2025 20:59:24 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lcdye5nn; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1748897964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oHj5LplUQW2Rs+qaSOWR1ovRsM9lEK+tcVFyNq+5pQo=; b=6H6bY5Y4SREEQl72TjG06yrqaF/YND1Y9xKiI45vt9Vjv6WsItqUP+uYE/OoXTiTnTY50Q vAs2/4gAHHDN78SISkmkdV8Rhrc+DePcrW0sj4jDawofH5kKj7l1smKrl26Taxi6rrxjEk paJ2Ormse1PyKSR4XPEcUx1+bIaVj5c= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Lcdye5nn; spf=pass (imf15.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1748897964; a=rsa-sha256; cv=none; b=4gjISgdZ1/L2QCPn97N2sU1g1nVA180tfarj2ZDd7YxKoVmx3/8Nsty5J0HLVeOS/9n9zz mpCxgTyQsHH5u9Vlv4ooON2Gt2MlUBi5kvAZgBS71ItpUQbZp2zp3mvF5cp35Myz4xMBba OmMpYQp3xyJayenXw/NffQVoNhjsSlU= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1748897964; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=oHj5LplUQW2Rs+qaSOWR1ovRsM9lEK+tcVFyNq+5pQo=; b=Lcdye5nn6LRw/aPNc5l/hK0KSYCoEC4KKIAX/e0ZbgOENMO7fA7RizHYkvegphEQNq1v1o qmW7x+WZ/TKfbSZYlQ1GGy6NnBgplUiM+AUpauQm6r8ZWO3etd004XCKuvghU4GbHweeVz BXV27aZS1A7NtJpatJeYk/iU8lfs9eM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-516-yfvebY3YOnaeI6k2w7_U8g-1; Mon, 02 Jun 2025 16:59:21 -0400 X-MC-Unique: yfvebY3YOnaeI6k2w7_U8g-1 X-Mimecast-MFC-AGG-ID: yfvebY3YOnaeI6k2w7_U8g_1748897960 Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-450db029f2aso14871205e9.3 for ; Mon, 02 Jun 2025 13:59:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748897960; x=1749502760; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=oHj5LplUQW2Rs+qaSOWR1ovRsM9lEK+tcVFyNq+5pQo=; b=DIlLNhiDz1n5VmV1h3BIOfwxZ+H4bxsOJ1u5BDxIXCWHjZrfKgv2snutaCVpOFASsm zF1slH4Mf8CB0nzBO9k9kE9oD8VlaxhHuw74YecClWvqot0AMmpJ8Q5toSbSf28FH6q9 /evLRUQgSJiwhIwmaxn4l5UTkyP+cjBUuQysSnVP7O/KbGadRBMvdEY66Evu2eE9C9vQ js6xlKcIr7jTVCIpp9u9gilxL3lpw4oLdOWunJ9m/forcdhF8JyVQHNoQ3op1PG9sgZ6 5X6kNtBegotC9yu/wxbltH19NrgV3NyH5trNMZncsyUPS3+XPIGEB78tfFK5uYGed/wu OJbg== X-Forwarded-Encrypted: i=1; AJvYcCUR/Eao8yqxz3IJjxYGdGHLIgHbC5RZ9pT+ZNsEQmZBmnxZkliExHGKasGwTeGwCzvy5n8dIlGOuw==@kvack.org X-Gm-Message-State: AOJu0YyXLF+0KI0s09hTU/7Ih2Twq5yedDmGcgku0AZvjKcfgxMiGhw6 Lg6htmypAiaaBAjIP5OmnRDxV+7g1PrKFxwHGAHfEIryinpW31Wx57Xoc+jAC5vWduXh/lM2VCI 7sTXyu6jX4T8dyDkUP/Yxsh1LEAsIgL8HdaA5dJLJkf0wcA407dWf X-Gm-Gg: ASbGncuyshpij2+gvI2EX/7/Yrhuwgei5dGaLaGKaeWL0G+VHeGMLcQLP6WftX3JUle KX7yIviTFgWQ9idExE+zaU4o8opWDJBOok3jVENgr7fTtkyIOpIrBnV69UBSbkr8JEaUf0V/iit jftEA+QDVq+R8pYy8PjizEBVNNCx9/FAUNosFjAcS0yfKSX6MLwOvsDDdQPVewUpt0Qoqhxldzl vSfHsgtTPHuoI+Mwzt4R92tQnXsuvwfzbiiXJKbV0yMoABi+pPVO+1fSwNkhmNQiHJegNsSry+S R3mTVGRjQWGc7IHwo9PL0V4o8EhYDRy8pFjCQAwChK9WiWY9oTB+szXoHoYFfqe3PxkkYZeIdHE ZcKcoaRl0bRSVbxDVOqPIdRrsJSBUPgj0kEelny8= X-Received: by 2002:a05:6000:250f:b0:391:3aaf:1d5f with SMTP id ffacd0b85a97d-3a4f89e8f3fmr11162948f8f.52.1748897960500; Mon, 02 Jun 2025 13:59:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IFmNd8bL6O6l0mWFBg4PXRgZB4V57QVpYJFhasmS2itus8IMdBaTylJQrtMhsnUaKK3xXzPCA== X-Received: by 2002:a05:6000:250f:b0:391:3aaf:1d5f with SMTP id ffacd0b85a97d-3a4f89e8f3fmr11162935f8f.52.1748897960102; Mon, 02 Jun 2025 13:59:20 -0700 (PDT) Received: from ?IPV6:2003:d8:2f34:a300:1c2c:f35e:e8e5:488e? (p200300d82f34a3001c2cf35ee8e5488e.dip0.t-ipconnect.de. [2003:d8:2f34:a300:1c2c:f35e:e8e5:488e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-450d7f8edebsm134353075e9.6.2025.06.02.13.59.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 02 Jun 2025 13:59:19 -0700 (PDT) Message-ID: <1f1f1d26-5bbf-498a-b6af-0fb51fb3d50f@redhat.com> Date: Mon, 2 Jun 2025 22:59:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v7 6/6] mm/page_isolation: remove migratetype parameter from more functions. To: Zi Yan , Johannes Weiner , Vlastimil Babka , linux-mm@kvack.org Cc: Andrew Morton , Oscar Salvador , Baolin Wang , "Kirill A . Shutemov" , Mel Gorman , Suren Baghdasaryan , Michal Hocko , Brendan Jackman , Richard Chang , linux-kernel@vger.kernel.org References: <20250602151807.987731-1-ziy@nvidia.com> <20250602151807.987731-7-ziy@nvidia.com> <7BD9FB05-4125-4EA8-841D-9D08907D01D5@nvidia.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <7BD9FB05-4125-4EA8-841D-9D08907D01D5@nvidia.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -aU_84xBOTZku71NJlbpSXu5yh0Gicq8e4QE6G45Mvs_1748897960 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 9D43DA0005 X-Stat-Signature: c9tidskgpsxo3tds1ot1s5kqcf8rgp6d X-Rspam-User: X-HE-Tag: 1748897964-427084 X-HE-Meta: U2FsdGVkX1+fAnjLOLeD76eq3n8oJVtIyWnP3TuGAjGdJGEPSb/QvrSN3ja1a9bUV6paHDHaRvElegnOWJAUoPfZ+D2bW1vkhPKs5CQQ+h8EaWW7IbbYTZfcfcaO25XqIqpEeAgf78jmOEDT8I9iEs2P3NF3HYarJ5OO94cz+voOoJs80AhtrWZ1AgVs2Xg/oBDTPh+5F4QCYj7f/TyV+r492oc6Pexvnq8/zIqnGMs34bpRyZGMny5ynLdbTKyF6FKftTtD0xErVwbSHQBu2BNZyYfZwAihBmmW+Ru68yOf/LxAvuebgTPVuz2Yy2ke1JxkmSPsHU/0MQvpUF4M7Go4pxHXPRcaaPyayOiIgjUFINcSzXY4bs/q9bzkdOg1Mlzfw11R9ugsk1XMUhO5rvdOEJH4eE/v99xkrWqDXtJUHVZD5zSxtMZVKwBCotVKeODERMzcYxxccV+DqK/6HbwhzyZojExX4INtvwfMifC7H5ffbhGFTNUEJJBfotXAOIPYbBSBBw0nG3QJDRc/n/GZwnYVQNQlswCwganzAsPdhBHltvX3NHwqL3ekNi5cjH26FxFd175Cut9wF/eoBN7CuQyCPOpgFQyqf0A3yXUKu6nwnKof+Ww7vd4b6CBlyBYLI+I87UWj06P7rPbwzxdIPBHxQjZxEUNAIyVDMdZqwfFmHYVruRVUEIBYG5AnX7UOn8PIGsfRwa45Z4CUWRcCGvRj3Q9uYq7Whl2dJ9fmC/ZANHceOh0bMMk/G0igz1w2h1Gv4lVqc1MPk2zLrZwvr5WKS4q1kBGbiwC7UAgkMgqhrB8IDgkGpR+39Y5oIFxhoRY/R3WAGgh6zrw3F6gkG+/hYIKJ3nxauqr922v+Y9cG5Sk5xpPAWSuG3B3j+GSaWim+xQoRMGavRofHV3Xl4oWR1b4ETDO9HBbt+Yu2vzNuhZEgqmV8cj9EdgIKKMusgi8ycZPRhyHtvrx PbyEtlNI i01vvExv3YqL+3Mz6BdA3oIMkyIhwksV42v2/qrpEHxO++H4fubenZqGFv3V4kV57/bgIwKLNXqLr0KbMCOcaq2OlQog4qvwjiLDJNTYth36OYirc2o7xHRpgAan99tWKhkkAA+qMXYGtaXBGRYnzmLEln7x4fmZYJNvDyX5oKVN0zc3aFJm2Yf1+HBkPf62/DIOLtyxayUrxizTLJDdvE802iIrXDDf/SrV3wqwpY7KtmwjkpZ+kEVQSn+wKcBG7ZfQeQnKq6JBYJniZusylWPhnyVwWduUXzoL2C/qkOCokLs6hwALIiGH1t5eRNgeAq/UwIsIW8rnXIAMohLDQjqrKoB6B01enpjLjlZqZx/h1TFIsZ15l48zRjeCwP8naRHL3pvY3QbD6Y9wuDVcdLc7kq1uudPELoWsd4XgG9GjzyfChfNWRLnT5bqbarPWI29na1jDkBR426nuAqOl8zbz+ZTm3mv4rlKWx X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 02.06.25 18:59, Zi Yan wrote: > On 2 Jun 2025, at 11:18, Zi Yan wrote: > >> migratetype is no longer overwritten during pageblock isolation, >> start_isolate_page_range(), has_unmovable_pages(), and >> set_migratetype_isolate() no longer need which migratetype to restore >> during isolation failure. >> >> For has_unmoable_pages(), it needs to know if the isolation is for CMA >> allocation, so adding PB_ISOLATE_MODE_CMA_ALLOC provide the information. >> At the same time change isolation flags to enum pb_isolate_mode >> (PB_ISOLATE_MODE_MEM_OFFLINE, PB_ISOLATE_MODE_CMA_ALLOC, >> PB_ISOLATE_MODE_OTHER). Remove REPORT_FAILURE and check >> PB_ISOLATE_MODE_MEM_OFFLINE, since only PB_ISOLATE_MODE_MEM_OFFLINE >> reports isolation failures. >> >> alloc_contig_range() no longer needs migratetype. Replace it with >> PB_ISOLATE_MODE_CMA_ALLOC to tell if an allocation is for CMA. So does >> __alloc_contig_migrate_range(). > > This paragraph should be changed to: > > alloc_contig_range() no longer needs migratetype. Replace it with > a newly defined acr_flags_t to tell if an allocation is for CMA. So does > __alloc_contig_migrate_range(). Add ACR_OTHER (set to 0) to indicate > other cases. > >> >> Signed-off-by: Zi Yan >> Reviewed-by: Vlastimil Babka >> --- >> drivers/virtio/virtio_mem.c | 4 +- >> include/linux/gfp.h | 18 ++++++++- >> include/linux/page-isolation.h | 7 +--- >> include/trace/events/kmem.h | 14 ++++--- >> mm/cma.c | 3 +- >> mm/memory_hotplug.c | 6 +-- >> mm/page_alloc.c | 27 ++++++------- >> mm/page_isolation.c | 70 +++++++++++++++------------------- >> 8 files changed, 79 insertions(+), 70 deletions(-) >> > > > The fixup to restore acr_flags_t: > > > From d0205580ab70aaf93f3f7c04b53dc595ee387bac Mon Sep 17 00:00:00 2001 > From: Zi Yan > Date: Mon, 2 Jun 2025 12:53:58 -0400 > Subject: [PATCH] restore acr_flags_t. > > Signed-off-by: Zi Yan > --- > drivers/virtio/virtio_mem.c | 4 ++-- > include/linux/gfp.h | 21 +++++---------------- > include/linux/page-isolation.h | 15 +++++++++++++++ > include/trace/events/kmem.h | 12 ++++++------ > mm/cma.c | 3 +-- > mm/page_alloc.c | 24 ++++++++++++------------ > 6 files changed, 41 insertions(+), 38 deletions(-) > > diff --git a/drivers/virtio/virtio_mem.c b/drivers/virtio/virtio_mem.c > index 535680a54ff5..6bce70b139b2 100644 > --- a/drivers/virtio/virtio_mem.c > +++ b/drivers/virtio/virtio_mem.c > @@ -1243,8 +1243,8 @@ static int virtio_mem_fake_offline(struct virtio_mem *vm, unsigned long pfn, > if (atomic_read(&vm->config_changed)) > return -EAGAIN; > > - rc = alloc_contig_range(pfn, pfn + nr_pages, > - PB_ISOLATE_MODE_OTHER, GFP_KERNEL); > + rc = alloc_contig_range(pfn, pfn + nr_pages, ACR_OTHER, > + GFP_KERNEL); > if (rc == -ENOMEM) > /* whoops, out of memory */ > return rc; > diff --git a/include/linux/gfp.h b/include/linux/gfp.h > index 17b92888d6de..95065cec85e5 100644 > --- a/include/linux/gfp.h > +++ b/include/linux/gfp.h > @@ -423,25 +423,14 @@ static inline bool gfp_compaction_allowed(gfp_t gfp_mask) > extern gfp_t vma_thp_gfp_mask(struct vm_area_struct *vma); > > #ifdef CONFIG_CONTIG_ALLOC > -/* > - * Pageblock isolation modes: > - * PB_ISOLATE_MODE_MEM_OFFLINE - isolate to offline (!allocate) memory > - * e.g., skip over PageHWPoison() pages and > - * PageOffline() pages. Unmovable pages will be > - * reported in this mode. > - * PB_ISOLATE_MODE_CMA_ALLOC - isolate for CMA allocations > - * PB_ISOLATE_MODE_OTHER - isolate for other purposes > - */ > -enum pb_isolate_mode { > - PB_ISOLATE_MODE_MEM_OFFLINE, > - PB_ISOLATE_MODE_CMA_ALLOC, > - PB_ISOLATE_MODE_OTHER, > -}; > + > +typedef unsigned int __bitwise acr_flags_t; > +#define ACR_OTHER ((__force acr_flags_t)0) // other allocations > +#define ACR_CMA ((__force acr_flags_t)BIT(0)) // allocate for CMA For FPI I called that "FPI_NONE" -- no special request -- and similarly for RMAP "RMAP_NONE". So if ACR_CMA is set, it's a CMA allocation, otherwise just an ordinary one. Apart from that LGTM. -- Cheers, David / dhildenb