From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 43895C77B7C for ; Thu, 3 Jul 2025 07:30:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 976446B011E; Thu, 3 Jul 2025 03:30:28 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 927296B0120; Thu, 3 Jul 2025 03:30:28 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 83D7F6B0121; Thu, 3 Jul 2025 03:30:28 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 740C96B011E for ; Thu, 3 Jul 2025 03:30:28 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id DEA795A859 for ; Thu, 3 Jul 2025 07:30:27 +0000 (UTC) X-FDA: 83622130494.17.258DD36 Received: from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190]) by imf14.hostedemail.com (Postfix) with ESMTP id 8048B100010 for ; Thu, 3 Jul 2025 07:30:24 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1751527825; a=rsa-sha256; cv=none; b=XyuxsunOHrMYhMRL3SqBBO2eWhZNfjtyPb5a1Wt9wjruB9p1JKIF62WVGdIwUh1w/XrUx5 NO7pRIeyY9/LNHP18xtiQrxI/M+v8JfUa/Rof612BjLu1BmELGL8aFyjou/sNL+ihgCzdy /Kjh82Cu5+1jV6XEe8V+H+JEJTBBYys= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf14.hostedemail.com: domain of tujinjiang@huawei.com designates 45.249.212.190 as permitted sender) smtp.mailfrom=tujinjiang@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1751527825; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=icLSMappIBanm/qsaS4uqUHSj4TdHXVnG3SN5vFmKz0=; b=ZrFxZUEx0FPzT4Eljb3MCqLhoIF/4CukMqb4QlK24SVQX5OIICALaKbiT2G/vIS1198Tei 9FL1fczz//QEHU9QySJr5pVA94UA/cUXrSmcYUHprIpCSLd9SgkylKAtvcYxj1qhmQJF+a Vgdwkn3jCJmA6TUqFoM5yDe59NMyIQ4= Received: from mail.maildlp.com (unknown [172.19.162.112]) by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4bXpGg6TJ6z2CfbG; Thu, 3 Jul 2025 15:26:19 +0800 (CST) Received: from kwepemo200002.china.huawei.com (unknown [7.202.195.209]) by mail.maildlp.com (Postfix) with ESMTPS id 046031401F3; Thu, 3 Jul 2025 15:30:21 +0800 (CST) Received: from [10.174.179.13] (10.174.179.13) by kwepemo200002.china.huawei.com (7.202.195.209) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 3 Jul 2025 15:30:20 +0800 Message-ID: <1f1d7ded-79b4-efec-ec14-a3d0b1dbcdc8@huawei.com> Date: Thu, 3 Jul 2025 15:30:19 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH v2 1/2] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list To: Oscar Salvador CC: , , , , , References: <20250627125747.3094074-1-tujinjiang@huawei.com> <20250627125747.3094074-2-tujinjiang@huawei.com> From: Jinjiang Tu In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-Originating-IP: [10.174.179.13] X-ClientProxiedBy: kwepems200002.china.huawei.com (7.221.188.68) To kwepemo200002.china.huawei.com (7.202.195.209) X-Stat-Signature: fu68bbcnfjkgg3qtyk89xrdwpsy5qjkq X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: 8048B100010 X-Rspam-User: X-HE-Tag: 1751527824-27706 X-HE-Meta: U2FsdGVkX1/gESUmFdHyphEhFT1tx0IEKmNMxCK2HPORjCCwRhR4RJEPwC69fOjvKbS/ckuSACGGvBg9iP2u1/wSTrR6NkSwPe47LxfxFJFZ9kIXT4ey7nTOd0DbBAynZIaJf5UXgOP5+SNSw1n4oInQF7XSBchBKDjEEYK1tLJxJG/KsZPnimmXwEj1bt+/AmtgtjNYC5ze52lrcpP+ZNOXTO839sE9AUBJrphAdOK8b8v7y7uCYDXzPrjA5/H89IkDhaoceoLj/BWFC+aeKOu8LQuyjRzxMWYiymaIMtowS4nR+75GqXWuR0xe2BTtLF9fr9yCVESqJo7mz4xrerj5O3sOLO4UzdjqN0l/FwGmYqaea6jReHzYQMLzfu53rUv9+q6iC1iwsW9MPazlU8sIcHJLjQ2oaXvoXaK8x85bgp6gLkj0vcA39eGrcq/RJnqZIdbHzerqJFn9BxKdahPad2k5C3yDNDDathIy941Sy7oNPGmnJ/WZazaNa/JD/oIZ0ZuczSgunucL2vifH48icYFQxY8NCTr+r+JqmkB+wjs/opK7ACbFOa3crLdI5I4H8ukYHG3sIjcmDkhWTdZrkMpslghljaKvIo+Fms66Nqc3EQxZeggxukuu8aCvfX66EeNtv/i5gAYdCuzdGCFTUghx1ErMaX+Impo61t1dcxWe7nmmvEvCZC1GdsMC6azh5S/xFS6aAmUlQbxiLASIM5yVMldRPfWYSJlJkWcMVNMiHeOVzBpXoP5EamksNRqZvJiubSzCQwJvzx/eYDFDQryrG53QjFmzaA8qJR6URIx6LxpBO/HIvx8ZMSJjt4CjAlRfjUQyhw2TQ02yzIr2Gl3Rs82T9KX3jQcev8LkFn5fWe0xLUJaXaBJp9imAFp3XCjG3NfbgPFs+n3YVSTYxBgCHAAwhtvmHzTBtJUpgR+GS9wIaXERtcKwAk/suCXN2iiBCE4+uF/IFGQ 0Cy5kUib GU4ukN0KaR++uvKPrM2SoOyIvIffokVXeds3CQ9lCvnuC7D32UHVaxYNYQlZr4nKfP5gfAJ0xA/Esd8hJk2WRi0OvdhNYv7jV9PbnkGz/goqusWvsQL1paUlSmuI+su0ZVYjiyQjzvc8pnYNUdcxgQ6bxpaKEHv2EOEBdmPDnR67OUXh6vbiJwW3T2ZUEIn9PQX40Kab6oh7EJZNrejajluH+CSwqG1oh/R4tFrxwuFl/Pgw4UmTKLXcD6IfF1fT/1U3IJ+WpSYo7ARrjHV9uJXzQ9peVpLpxm1HgW/10nHbR+Tq0+MMmPmOC5wE5DggoXfZcSpdMH4pS0IEzmFp9YUf1OA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: 在 2025/7/1 22:13, Oscar Salvador 写道: > On Fri, Jun 27, 2025 at 08:57:46PM +0800, Jinjiang Tu wrote: >> In shrink_folio_list(), the hwpoisoned folio may be large folio, which >> can't be handled by unmap_poisoned_folio(). > Uhm, why can't be handled? I think we should spell it out, and maybe > even put a comment above unmap_poisoned_folio. This is disscussed in https://lore.kernel.org/all/68412d57.050a0220.2461cf.000e.GAE@google.com/ I will add more comments to explain it in the patch. Thanks. >> Since UCE is rare in real world, and race with reclaimation is more rare, >> just skipping the hwpoisoned large folio is enough. memory_failure() will >> handle it if the UCE is triggered again. >> >> Fixes: 1b0449544c64 ("mm/vmscan: don't try to reclaim hwpoison folio") >> Reported-by: syzbot+3b220254df55d8ca8a61@syzkaller.appspotmail.com >> Closes: https://lore.kernel.org/all/68412d57.050a0220.2461cf.000e.GAE@google.com/ >> Signed-off-by: Jinjiang Tu > With the above addressed: > > Acked-by: Oscar Salvador > >