From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9CB7EC71137 for ; Wed, 11 Jun 2025 08:36:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EB546B008A; Wed, 11 Jun 2025 04:36:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 09C2F6B008C; Wed, 11 Jun 2025 04:36:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA6216B0092; Wed, 11 Jun 2025 04:36:06 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CB6516B008A for ; Wed, 11 Jun 2025 04:36:06 -0400 (EDT) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 72EC01A04DA for ; Wed, 11 Jun 2025 08:36:06 +0000 (UTC) X-FDA: 83542462332.18.111C740 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf16.hostedemail.com (Postfix) with ESMTP id E4BB0180011 for ; Wed, 11 Jun 2025 08:36:03 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hpw+Y12U; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749630964; a=rsa-sha256; cv=none; b=zCYFl4NfxKQdlmaGiO3qLoLO92y6beWcv8AW5YiIcFr27lpJLp0hS7/xOcB6cF/hQatyFA 0Yt5jsRAUO8vaawGuyLXAtg9Np3FMQOdMRtULYnTTgV2SLeb7BTEhyXg7n+u18Aw+sg3GG XXfnL8VfXiC3nMvZ3dZ8aJd6ChPKzas= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=Hpw+Y12U; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf16.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749630964; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=k9ehRRHxRyDkVpGZVHEhMhOHW2qYHpROg2BQf7NAz90=; b=L85O3yyYd+gvhzEQfTUBrj8pxYu7sW6/PS3rKPlyf5AgPTN3Dlu6X69NlvHyqcjoP2UBe2 1Og0XMt1c+zb3/LdqwNY6PMU8o/s5IT/myWJ2teZoskCEwyRHxgFrTyzCcDI18kPYHA3Rc OjyoNkHLcnSDeJ14aEv2znAyKOPTEMQ= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749630962; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=k9ehRRHxRyDkVpGZVHEhMhOHW2qYHpROg2BQf7NAz90=; b=Hpw+Y12U/U6YlK7XAzd+3X0+fozHlphrLRAXrT/SUET6G6gnqiOBcD2BMSpm4B6JXwlgoV E0Xsq8L6J+yyJaIGhw4HGQI/+rgQICgkjCq9A/pwKiz/s2KMV8Plv7qKguych5U98VG/6Y Bnlss5syKu9trwz22mBvgwJPLn0PS90= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-336-QskK3DiPOxW5U1m9OsZs4g-1; Wed, 11 Jun 2025 04:36:01 -0400 X-MC-Unique: QskK3DiPOxW5U1m9OsZs4g-1 X-Mimecast-MFC-AGG-ID: QskK3DiPOxW5U1m9OsZs4g_1749630960 Received: by mail-ej1-f69.google.com with SMTP id a640c23a62f3a-acb8f9f58ebso479914266b.2 for ; Wed, 11 Jun 2025 01:36:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749630960; x=1750235760; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=k9ehRRHxRyDkVpGZVHEhMhOHW2qYHpROg2BQf7NAz90=; b=J6Gq9Eg5j4MTNy9ZIcdYub4ld8zAhuTynMa92mpkb7KLwoHDRAubGML9OB3DjpjgMG 9adik2E0ceKbNJATYgljAPSc7NkknSl1na+1gydCp2gdHaYgTDFcs/mbd7+V7AkQ24t5 0U26c2/mdelyYRFVEjfAjQLWgHSO1Iuv+iu1R7SU4OTMuMfWbvdG+gsk4NzotINTtko+ mOUJ8zSdb5n+RRTPaxLgbbb7T8C8CnKiUOCF7YI41UlSkWwLSxCGsuplWs74Q0vjo2EA T7fCu5BMc0MgjJE7bB//qZ4O20ilgcfFCRdZxk2k/3ZNko87dLlLG/3pG8ApIKMcvObW tH4w== X-Gm-Message-State: AOJu0Yx79qBQwM4KKBzT0m7QwebOgT2MYEC9WCQJ0XytGYAwa/d+vj4W bdm9o7DyBp5FDq0PeDMTcxzTyBecnaw+L7kG2JtMV4x0zqR80RBfyo/e2slfaWV+pj5OWEuWcgs jCX0MVYvyZzT5aOfDSbKYb6fdImVoL2hItMxzSlXnQ9wH7uCCUibr X-Gm-Gg: ASbGncvYQxRJIXxGJ/HUJc+Lk3PxZ18qzGorFpBGrFYO5A0LQJv73rWK5jvKOZPW7Bg 9+PXaF0AwNLsIMomCwMHgGFOs2/D6oze+ctzaon7rDazjcujX2LV9e9hEgb4nOBYUsg4ZBmXeC3 0ytlTVZ8TNRXytUuINzk4ICLKh9acK2gHg1VLFmtgIcsvm8vCdCx4NuC9VZDhKuV1FFxh1cSJNw +HCdgJpvu/Ecgj3X5a+CdFMi3UfBex2V8wbh/FbDh40QMgIDn3aRuhIaI8F3Efekna6DUz2N72B nXP/G/yv9fGLo+hYw5Kl/H4xvxuty5OITW60BJgx5SA4 X-Received: by 2002:a17:907:1c22:b0:ad8:a329:b488 with SMTP id a640c23a62f3a-ade8946225amr228605166b.13.1749630960045; Wed, 11 Jun 2025 01:36:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEL/WqJM2mNwrzS5d45Py5oSbVNmlJBGXg7I5NvETwh5Pjy1XH+PhTJdFsUfH1CDkc3s17xZw== X-Received: by 2002:a17:907:1c22:b0:ad8:a329:b488 with SMTP id a640c23a62f3a-ade8946225amr228603066b.13.1749630959556; Wed, 11 Jun 2025 01:35:59 -0700 (PDT) Received: from [10.32.64.156] (nat-pool-muc-t.redhat.com. [149.14.88.26]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ade33c09594sm762920866b.97.2025.06.11.01.35.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Jun 2025 01:35:59 -0700 (PDT) Message-ID: <1f0c7d73-b7e2-4ee9-8050-f23c05e75e8b@redhat.com> Date: Wed, 11 Jun 2025 10:35:58 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] mm/vmscan: fix hwpoisoned large folio handling in shrink_folio_list To: Jinjiang Tu , akpm@linux-foundation.org, linmiaohe@huawei.com Cc: linux-mm@kvack.org, wangkefeng.wang@huawei.com References: <20250611074643.250837-1-tujinjiang@huawei.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 3h0wM3RHjdO1VGOMl2JTuvWR-AMpmUJT2ikUsbtfQz0_1749630960 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam01 X-Stat-Signature: cc7t6znu4o7fzg1w6tdeu8tg9kof4ozy X-Rspamd-Queue-Id: E4BB0180011 X-Rspam-User: X-HE-Tag: 1749630963-110223 X-HE-Meta: U2FsdGVkX18Ki7jkpNKgkWLoC+OHclYnAPLT8iNAbxwFHPu+BjglBVMn+EtPfL/hAaCTxX4Kriqez3Ii59SsYNwFgL7j3LYG3XlpWYWiGoTkscVB9WTXW0/SoznWf3kqJ2ibIDVXdzarQXBdIcmb9VvccSzqGSX+u2vqWhzmGyJZ7JOGJdf1gMA9tQA+4Pu11TPZGoXimnZNrL0yP2IZgzr5Q4sOEBYOlmY4gdiPFl3p+T5ddZUUmkoQ07sdcWepwD33ypinWs0nR6QeyXCs7QVvzxd5q/whNkfBBJIC7xdpwuJYIZ9mFvu44SvVkh1GhKFhP+TBTXZMMINpTl3ww4tfQmVngifczUDGlTQ0nEXgJ971+DbrR7ymmJDpZcWVq41H74oyZChoymwhpi5XrMCi9yZsO2B2pOqx8jr7EEqzP/syyRYS+WcuuOixMCbv8wVMcn4wLtLQEtGOLwbNLyQsmgm/wyPYTsFWlyezwlOKxJDRFirsV6cCo1ZEHr9/JZEXgIF16IYGm3uGm9o9QuQWFGziMaV/FpfxdqIdO6R+kSwJssNV9dKNG/S/uBbOG7RRoBBAfORtVsU4jHhqaAjfyLZu3M6s+Kt+S8jkW96fPLp2i0dLAZSNeq9j6RW3HS6/3u5MtFtvDk/AYpxZlaShu72ZTDzx+v9F8n4+Jkbx/NrFACD6IL6KCcELS43zk1BrofkHnJ/ibuTDMdRxpS3SNGWQLKuitxWFInIQ3h98XJn9wolxrXAYZtKJuKtTyd1qGw+SN8ssJ/b5mdGs361FgavgjwuV6dKcQ9uvHfQKvcok6gFjQJeELWQq+N0hkGO025/3fUEcaXF3NyBUCS+mYE+OcqovZowfhO3bqQJA2PX4Q5Ll0PchdIVuXa8g/uvS7hJvRuKUGCH0q59jpbjBB8qiJmFZCEeUGqNIUEaFx1ceqP3fvQJNJheSYAXEvLTDNvOCPIYPriGzKRl UQjqpRjP ecFSz/FbRHipvWn6auSmg/zdftKzIK1bPxoq9wANYb8pg2nJQ1xMxj9TUgvZ0C8rfZAOxfEDQt7jfbOmxGCj7epk5d4g2u2kjF6o4G8+pl2VrjpH9ZyC0Y2VDlx+90gdoxw+JiiXuJMhHw6mFGusz2URzJiLocG+E8Y0MokaA/Yl5OrjoLIgFbNBcgEl3Z96oU//F+5H2evA/U6l0Sao80PThOWyFTvrLr4WGk1nsg4k2QF4PZAg47qWV0AMtrDUX3IgtZl//5h9u0ugWJmJitJVSgzJP/4UM2Fck2WDafhauD5aUolv7XMbaF5SzcB5QhqCOmcuoTng2KrqmYeAuRgbhz6VgBmisoATMhDvYu3LfH5/lf+keRyIcgWIvZjg17rbN4TDj3BZmAMfd932qNul+VaISgV9nRnWR/5ybbI5qmIXwB61QGpA0rAfxPndSf6r8WEmCvAj8fPyUfb3ipI4GPOcIq1odbHc2EzlTSIS1M4dnb/WTOZ0d2kOgbzteFg2YyXnt0FClkPJOtELFj/WCQXEidH4tN7iN8sTyGTJT8dXq/LFuv7ClylFJTHfX2CL3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 11.06.25 10:29, Jinjiang Tu wrote: > > 在 2025/6/11 15:59, David Hildenbrand 写道: >> On 11.06.25 09:46, Jinjiang Tu wrote: >>> In shrink_folio_list(), the hwpoisoned folio may be large folio, which >>> can't be handled by unmap_poisoned_folio(). >>> >>> Since UCE is rare in real world, and race with reclaimation is more >>> rare, >>> just skipping the hwpoisoned large folio is enough. memory_failure() >>> will >>> handle it if the UCE is triggered again. >>> >>> Fixes: 1b0449544c64 ("mm/vmscan: don't try to reclaim hwpoison folio") >> >> Please also add >> >> Closes: >> >> with a link to the report > Thanks, I will add it. >> >>> Reported-by: syzbot+3b220254df55d8ca8a61@syzkaller.appspotmail.com >>> Signed-off-by: Jinjiang Tu >>> --- >>>   mm/vmscan.c | 8 ++++++++ >>>   1 file changed, 8 insertions(+) >>> /home/tujinjiang/hulk-repo/hulk/mm/mempolicy.c >>> diff --git a/mm/vmscan.c b/mm/vmscan.c >>> index b6f4db6c240f..3a4e8d7419ae 100644 >>> --- a/mm/vmscan.c >>> +++ b/mm/vmscan.c >>> @@ -1131,6 +1131,14 @@ static unsigned int shrink_folio_list(struct >>> list_head *folio_list, >>>               goto keep; >>>             if (folio_contain_hwpoisoned_page(folio)) { >>> +            /* >>> +             * unmap_poisoned_folio() can't handle large >>> +             * folio, just skip it. memory_failure() will >>> +             * handle it if the UCE is triggered again. >>> +             */ >>> +            if (folio_test_large(folio)) >>> +                goto keep_locked; >>> + >>>               unmap_poisoned_folio(folio, folio_pfn(folio), false); >>>               folio_unlock(folio); >>>               folio_put(folio); >> >> Why not handle that in unmap_poisoned_folio() to make that limitation >> clear and avoid? > I tried to put the check in unmap_poisoned_folio(), but it still exists > other issues. > The calltrace in v6.6 kernel: > > Unable to handle kernel paging request at virtual address fbd5200000000024 > KASAN: maybe wild-memory-access in range > [0xdead000000000120-0xdead000000000127] > pc : __list_add_valid_or_report+0x50/0x158 lib/list_debug.c:32 > lr : __list_add_valid include/linux/list.h:88 [inline] > lr : __list_add include/linux/list.h:150 [inline] > lr : list_add_tail include/linux/list.h:183 [inline] > lr : lru_add_page_tail.constprop.0+0x4ac/0x640 mm/huge_memory.c:3187 > Call trace: >  __list_add_valid_or_report+0x50/0x158 lib/list_debug.c:32 >  __list_add_valid include/linux/list.h:88 [inline] >  __list_add include/linux/list.h:150 [inline] >  list_add_tail include/linux/list.h:183 [inline] >  lru_add_page_tail.constprop.0+0x4ac/0x640 mm/huge_memory.c:3187 >  __split_huge_page_tail.isra.0+0x344/0x508 mm/huge_memory.c:3286 >  __split_huge_page+0x244/0x1270 mm/huge_memory.c:3317 >  split_huge_page_to_list_to_order+0x1038/0x1620 mm/huge_memory.c:3625 >  split_folio_to_list_to_order include/linux/huge_mm.h:638 [inline] >  split_folio_to_order include/linux/huge_mm.h:643 [inline] >  deferred_split_scan+0x5f8/0xb70 mm/huge_memory.c:3778 >  do_shrink_slab+0x2a0/0x828 mm/vmscan.c:927 >  shrink_slab_memcg+0x2c0/0x558 mm/vmscan.c:996 >  shrink_slab+0x228/0x250 mm/vmscan.c:1075 >  shrink_node_memcgs+0x34c/0x6a0 mm/vmscan.c:6630 >  shrink_node+0x21c/0x1378 mm/vmscan.c:6664 >  shrink_zones.constprop.0+0x24c/0xab0 mm/vmscan.c:6906 >  do_try_to_free_pages+0x150/0x880 mm/vmscan.c:6968 > > > The folio is deleted from lru and the folio->lru can't be accessed. If > the folio is splitted later, > lru_add_split_folio() assumes the folio is on lru. Not sure if something like the following would be appropriate: diff --git a/mm/memory-failure.c b/mm/memory-failure.c index b91a33fb6c694..fdd58c8ba5254 100644 --- a/mm/memory-failure.c +++ b/mm/memory-failure.c @@ -1566,6 +1566,9 @@ int unmap_poisoned_folio(struct folio *folio, unsigned long pfn, bool must_kill) enum ttu_flags ttu = TTU_IGNORE_MLOCK | TTU_SYNC | TTU_HWPOISON; struct address_space *mapping; + if (folio_test_large && !folio_test_hugetlb(folio)) + return -EBUSY; + if (folio_test_swapcache(folio)) { pr_err("%#lx: keeping poisoned page in swap cache\n", pfn); ttu &= ~TTU_HWPOISON; diff --git a/mm/vmscan.c b/mm/vmscan.c index f8dfd2864bbf4..6a3426bc9e9d7 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1138,7 +1138,8 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, goto keep; if (folio_contain_hwpoisoned_page(folio)) { - unmap_poisoned_folio(folio, folio_pfn(folio), false); + if (unmap_poisoned_folio(folio, folio_pfn(folio), false)){ + list_add(&folio->lru, &ret_folios); folio_unlock(folio); folio_put(folio); continue; -- Cheers, David / dhildenb