From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 853D4C7EE29 for ; Wed, 24 May 2023 02:22:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 20B756B0075; Tue, 23 May 2023 22:22:37 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 1BB1C6B0078; Tue, 23 May 2023 22:22:37 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0AA74900003; Tue, 23 May 2023 22:22:37 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id EFA856B0075 for ; Tue, 23 May 2023 22:22:36 -0400 (EDT) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id BE12E4066F for ; Wed, 24 May 2023 02:22:35 +0000 (UTC) X-FDA: 80823549870.30.C1627F6 Received: from mail-yw1-f170.google.com (mail-yw1-f170.google.com [209.85.128.170]) by imf13.hostedemail.com (Postfix) with ESMTP id E47F020002 for ; Wed, 24 May 2023 02:22:32 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=CYHuBQt4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1684894952; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=dNoZFE15KVCGaDsKWYPa3AXU3xXgJ31/Z6hKlwSh2kQ=; b=CibSu9SMHJoNPi+Isi0lpZmqTV0oMtoPj8d/1uO8Z8pv48kCmKF1opMMq+3uuD81+a775V kILRcVrJylNhBYZKjgtnd7Hs5yoyyIqukX2AcxuVJA3pc1PLDzU/4fCzo69PdQti1fGK0Z aJV6CBA4lcVCOr0EzZvAJEOCvwMkxLU= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=google.com header.s=20221208 header.b=CYHuBQt4; dmarc=pass (policy=reject) header.from=google.com; spf=pass (imf13.hostedemail.com: domain of hughd@google.com designates 209.85.128.170 as permitted sender) smtp.mailfrom=hughd@google.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1684894952; a=rsa-sha256; cv=none; b=FNghE3H7dPeEJDamE5dyCsWNG8/MTfh2eDkPoMWeq9Sr49wV9l21Ffe0pVW3n3w/n+TYbo 5SG0vZuACfg2oSrS5xbRd9dfhmc7u0rbZy7kg+X51YrU0P2dQ/mAGFgjaz7+Xq2UEFn/Z9 GdcNAc+F60DNgtQajquxaUwksJ9vt2Q= Received: by mail-yw1-f170.google.com with SMTP id 00721157ae682-5621a279cbbso9054627b3.1 for ; Tue, 23 May 2023 19:22:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1684894952; x=1687486952; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:from:to:cc:subject:date:message-id:reply-to; bh=dNoZFE15KVCGaDsKWYPa3AXU3xXgJ31/Z6hKlwSh2kQ=; b=CYHuBQt4sNY1VOu7Oe2TF9KvZ6A5MpM3eHBJ3Hfajar8vhIXv3EieQ7KdHlCEj4hBN xRxLPqXXyAVpvGoVZxqv9xRQBK07xF7CxPJnjWwZ1P9UU1jnUYnZl/H+yd4O+yWjScr+ 6f8lLLMPEGj7tc+dNVo35Pgu1j9pjhH1eB2mjv0A2KNN5OosxpXlvr1W8iy5i6riCr1s uZDAZz29t0+rDczY3vYUYMp17f9D0nCVLUQl7f/+4Xq0bJGKkpLfU1xgGu21qcak1VEq X8U2GUv2hE+I0vwadhlJKWzJoI/QEtZ7MyP56j1xnS1Jpxnw4CsYGfk84Q8jhOJjNKpw 0YUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684894952; x=1687486952; h=mime-version:references:message-id:in-reply-to:subject:cc:to:from :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=dNoZFE15KVCGaDsKWYPa3AXU3xXgJ31/Z6hKlwSh2kQ=; b=k1T7OIljnpeQEqOnOvfvh7yriQKvVr4dk6llojZLDHllct2ENtyH0PFj6mIdvluOcT O0pcXxn2Tc0VJdndGRavvLWz41NpTC46EuJQKbCezX84vrG+Li5hvU0onZJc2xu4e8wW Pza20B3baMISI4B7ZmFh2L61osx6MWART7lHZzuheBIzRqlY69NOK8pJGUD9hPGtnMkn kGvrdYo6yOt2qK38QfhUtSYspC+nrljNeLrnrexCudD0k4nlv0NMDKbsFFVqumbr5PEB vXq+fln1K91Nb184/wyhOzg9+PQlLTvslyMJjHfD4ZsCnmeeX+zU6qJbxWoDKccfZIIr kxvA== X-Gm-Message-State: AC+VfDwnka/Jt4G0tZZMyo11uWy3t/hQpqrMK7t+xGoQj+3Z/hfNaVSx mB/dXrbNkqnNh0moirXnDaNi8g== X-Google-Smtp-Source: ACHHUZ5CYV+kqZ1ERIdLFZg8vNO+dYiJO6JxvUqRllYKXRSR+T73Ju+E0jdwMxZkpwTw380HTv4cCg== X-Received: by 2002:a81:981:0:b0:561:b53d:d1f1 with SMTP id 123-20020a810981000000b00561b53dd1f1mr16007563ywj.19.1684894951822; Tue, 23 May 2023 19:22:31 -0700 (PDT) Received: from ripple.attlocal.net (172-10-233-147.lightspeed.sntcca.sbcglobal.net. [172.10.233.147]) by smtp.gmail.com with ESMTPSA id d188-20020a0df4c5000000b0054601ee157fsm3342840ywf.114.2023.05.23.19.22.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 23 May 2023 19:22:31 -0700 (PDT) Date: Tue, 23 May 2023 19:22:28 -0700 (PDT) From: Hugh Dickins X-X-Sender: hugh@ripple.attlocal.net To: Qi Zheng cc: Hugh Dickins , Andrew Morton , Mike Kravetz , Mike Rapoport , "Kirill A. Shutemov" , Matthew Wilcox , David Hildenbrand , Suren Baghdasaryan , Qi Zheng , Yang Shi , Mel Gorman , Peter Xu , Peter Zijlstra , Will Deacon , Yu Zhao , Alistair Popple , Ralph Campbell , Ira Weiny , Steven Price , SeongJae Park , Naoya Horiguchi , Christophe Leroy , Zack Rusin , Jason Gunthorpe , Axel Rasmussen , Anshuman Khandual , Pasha Tatashin , Miaohe Lin , Minchan Kim , Christoph Hellwig , Song Liu , Thomas Hellstrom , linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 04/31] mm/pgtable: allow pte_offset_map[_lock]() to fail In-Reply-To: <9dc72654-79db-e988-54a8-488550d235ac@linux.dev> Message-ID: <1efc993b-5b41-4895-a4d-20d38eb95de5@google.com> References: <68a97fbe-5c1e-7ac6-72c-7b9c6290b370@google.com> <8218ffdc-8be-54e5-0a8-83f5542af283@google.com> <9dc72654-79db-e988-54a8-488550d235ac@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: E47F020002 X-Stat-Signature: 1b6pfrsjcu8173ottshow9x91p4whuac X-HE-Tag: 1684894952-651917 X-HE-Meta: U2FsdGVkX1+DswdThdgiisnoc3cpiS/Q9y44KtgrW1BWhUQDrNrqgb4yOAuj/zNCwiOkvK0g/yJOUHnBbAbLbNyUq+cMRtYBiV9cjCRifrAlbehvD2Wsu7YT4xWz5z4DqF6F+IIoWt9C4hcbE8cgFDwFSV8iatxg8F2iIIUTikv2BDBDpSxtbP1sb4fz7quXF6Y7wseHnRdFhsi4pPpppmbldX2ZRfBEpjtdjTdxRNaWJXwW0NgUcmmPEoiFvN8HFGQsx0uaapY+mfDUPEePKA2T9509F92rzcYXl2AyAK19RdHSHI0i7L7H8tphGJ/e4mdkSdKnDUQ3yvKvtHxruK680T8ue3ErXA0JK7gXmvp+s/+RuBg3Ih0jZl4ikNJ5Xjf7uVFHV3/Zt4/urmA6wlmsXms2i7f3sTVFFYUWJRHvBtOGatEvazL0Mcl6kBR53hHjyMQrPrt8GJhzTjxt4r4yK2PideesMjau5iponFE8taVFX6i1eezBNE6khmgcQPy45ZVWVsR1Da4KXc8rzIqmh8WVS9ItTg4OjZnT6busoSG29l5FxZnyUVsQ1TZTC5uEBShdGl9LSL9gmkjTIDaOdmCRE0CWqaml09i03yb8NcPpri4XY4zkO/jATL3AOK6y1i9cEUIKpBFJbj1L2dvaQ21/RziUi1dWGbbowZ4dBaMxUwYMMpNKQs2Hqgf26IlPiUj8dv2hD+WJOvKnpbBj0IDrnbXbwyjuJQIUHdi3Z9aN3+OHGdmhdX7l2jYDir0njXMDPKIckiFLqPLOtNCZbKKS3kRkoDVwPREybsuab4PFmDzfW3iQSGg9/PuPjehmdbkMtwNZoQiY9ljcWZ3da7nZyW7BFrYc4Txf8QmyzzqcnUoZbmrumD+nhzEtR3B7J8cms7bdT9n0zgh7W+JG6Hm/JLKYY4d5Sg/oZNTlITZmrV/2oI2Egp93DxJiJdXvOWL9PnMTiJnURxK M0Otp6h/ 4sWxKydR+usmP9Ujds11lTJhNHBhzBAV1ZbYUkTbgRgLLNLhZRCsU/Y1qkTkKWoYb2ku/1ZuuyBb1K4LpAzLKYcna/8zS7Xh1iiDS+xFUcnf0gLocDoVEVSHYlvnIZEUKc21t1nN0QLz0LROeQz0cAJ5qSGXIBUgqUWwhnhWGw3tv8ou8S27xAaLPu83NgKpjnxyrS85n/+ZCa8tnZrad0WuMQP7xuB9YWoSjGbeYTrMUpMFi9rx4GaDsynnktDKJoiTTdleaAA37M4iz9GwS/C3WuKSKwroveDGF9TpgSCcKA2a4l7+0M97DttsaONPvIudZxCaJdDor40lWrGpg6oKwcUsyrpmRGfpJYRxCyZvmHN0rDlSVKVRm393psFIWwzniazV2lSnWMLIykEPtLtKkCwMVQoYXc4c1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 22 May 2023, Qi Zheng wrote: > On 2023/5/22 12:53, Hugh Dickins wrote: > > [...] > > > @@ -229,3 +231,57 @@ pmd_t pmdp_collapse_flush(struct vm_area_struct *vma, > > unsigned long address, > > } > > #endif > > #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ > > + > > +pte_t *__pte_offset_map(pmd_t *pmd, unsigned long addr, pmd_t *pmdvalp) > > +{ > > + pmd_t pmdval; > > + > > + /* rcu_read_lock() to be added later */ > > + pmdval = pmdp_get_lockless(pmd); > > + if (pmdvalp) > > + *pmdvalp = pmdval; > > + if (unlikely(pmd_none(pmdval) || is_pmd_migration_entry(pmdval))) > > + goto nomap; > > + if (unlikely(pmd_trans_huge(pmdval) || pmd_devmap(pmdval))) > > + goto nomap; > > Will the follow-up patch deal with the above situation specially? No, the follow-up patch will only insert the rcu_read_lock() and unlock(); and do something (something!) about the PAE mismatched halves case. > Otherwise, maybe it can be changed to the following check method? > > if (unlikely(pmd_none(pmdval) || pmd_leaf(pmdval))) > goto nomap; Maybe, but I'm not keen. Partly just because pmd_leaf() is quite a (good) new invention (I came across a few instances in updating to the current tree), whereas here I'm just following the old examples, from zap_pmd_range() etc. I'd have to spend a while getting to know pmd_leaf(), and its interaction with strange gotchas like pmd_present(). And partly because I do want as many corrupt cases as possible to reach the pmd_bad() check below, so generating a warning (and clear). I might be wrong, I haven't checked through the architectures and how pmd_leaf() is implemented in each, but my guess is that pmd_leaf() will tend to miss the pmd_bad() check. But if you can demonstrate a performance improvement from using pmd_leaf() there, I expect many people would prefer that improvement to badness catching: send a patch later to make that change if it's justified. Thanks a lot for all your attention to these. Hugh > > > + if (unlikely(pmd_bad(pmdval))) { > > + pmd_clear_bad(pmd); > > + goto nomap; > > + } > > + return __pte_map(&pmdval, addr); > > +nomap: > > + /* rcu_read_unlock() to be added later */ > > + return NULL; > > +}