From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.7 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C2A61C47080 for ; Tue, 1 Jun 2021 08:45:41 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 7265461370 for ; Tue, 1 Jun 2021 08:45:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7265461370 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D85986B009B; Tue, 1 Jun 2021 04:45:40 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5CDE6B009C; Tue, 1 Jun 2021 04:45:40 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFD196B009D; Tue, 1 Jun 2021 04:45:40 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0151.hostedemail.com [216.40.44.151]) by kanga.kvack.org (Postfix) with ESMTP id 8CE256B009B for ; Tue, 1 Jun 2021 04:45:40 -0400 (EDT) Received: from smtpin16.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0D80E5DE3 for ; Tue, 1 Jun 2021 08:45:40 +0000 (UTC) X-FDA: 78204521640.16.C416EFC Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf16.hostedemail.com (Postfix) with ESMTP id 13F85801935E for ; Tue, 1 Jun 2021 08:45:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622537139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Ei1+7YPTwhcGwSC6x5usnbU/cNlmjtRYkQNi6UDFTrc=; b=JMtWMkqOud89CFV1m9y15fGRCZZH0lMn1YovydtanVlNpVbWVJKTZoXE+R6lTqDVyWJyRI PEfjltyZo1K0T9xTGD4AwqJbDg0fx0SklY5UDStw5qSBvsh5D7W1Gc8y9focEPpGeuTjzH se8z7DkyzwCggGrz2+TMW5yCSa+Uee4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-509-ws69ySOXOdu6XxbaFY7XRA-1; Tue, 01 Jun 2021 04:45:37 -0400 X-MC-Unique: ws69ySOXOdu6XxbaFY7XRA-1 Received: by mail-wm1-f71.google.com with SMTP id x20-20020a1c7c140000b029018f49a7efb7so849131wmc.1 for ; Tue, 01 Jun 2021 01:45:37 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:cc:references:from:organization:subject :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=Ei1+7YPTwhcGwSC6x5usnbU/cNlmjtRYkQNi6UDFTrc=; b=kGoa0xB1IaD1nkpLaHbgtZ0Z6hLWd47wMgiqp8O1MO1FhE4rUT/1XMV53T/S+qROln VXL4zvK+xD4oqYtQnpz5rG0Iz4jRT+1rOtMfVwAp2VeFz7z5x5Ik3DYXkHC1vdmZU1wU g3JYTfDfSeAThgfLoI832orYAjH7s4tiOggwTFcjKO9avBwri9PKMASa9HM7Tettgr4I sV+0Ay1iwE4sRSvrJ0Z4gUfhAxQkUHeU9QIBACYeQaK9tZBbYsQuMJ8aWjMwwMFS39aJ fTj+uUMVAcURtTw3zobOQr9F9mEJ/SvS81JUOiVPKqWeLIX1dFHNDHBaeuurj7tjDdbs 3Exg== X-Gm-Message-State: AOAM533x7SaUi927p4kw+0tDG7+NHmfBQSdLcvh2gmYWwVXAnd0DTncj RcDIG8YXC1PkfXjHJKHiltxQWnmnHAHcsdjfuy3Y05U/mi5rX0oDP/WiyQLF+m8czDK5dbvbevx N/jAUcvj7ZgY= X-Received: by 2002:a05:600c:2256:: with SMTP id a22mr3376719wmm.138.1622537136544; Tue, 01 Jun 2021 01:45:36 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw71orUED6J0M5xRL2FPbrXf1zLtQk15md+bXCGp928W5f5vqEbcF2SNwRqRon22LUBP3L6NQ== X-Received: by 2002:a05:600c:2256:: with SMTP id a22mr3376705wmm.138.1622537136338; Tue, 01 Jun 2021 01:45:36 -0700 (PDT) Received: from [192.168.3.132] (p5b0c69ce.dip0.t-ipconnect.de. [91.12.105.206]) by smtp.gmail.com with ESMTPSA id e26sm16961562wmh.39.2021.06.01.01.45.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 01 Jun 2021 01:45:36 -0700 (PDT) To: Mike Rapoport , linux-kernel@vger.kernel.org Cc: Andrew Morton , Catalin Marinas , Christian Borntraeger , Heiko Carstens , Mike Rapoport , Russell King , Thomas Bogendoerfer , Vasily Gorbik , Will Deacon , linux-arm-kernel@lists.infradead.org, linux-mips@vger.kernel.org, linux-mm@kvack.org, linux-s390@vger.kernel.org References: <20210531122959.23499-1-rppt@kernel.org> <20210531122959.23499-2-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Subject: Re: [RFC/RFT PATCH 1/5] s390: make crashk_res resource a child of "System RAM" Message-ID: <1efc386c-2cb4-164f-7194-497f142f969f@redhat.com> Date: Tue, 1 Jun 2021 10:45:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210531122959.23499-2-rppt@kernel.org> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US X-Rspamd-Queue-Id: 13F85801935E Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=JMtWMkqO; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf16.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com X-Rspamd-Server: rspam03 X-Stat-Signature: sq45f6bxbt6iocb6qwnkse8hz5az6h8p X-HE-Tag: 1622537127-840007 Content-Transfer-Encoding: quoted-printable X-Bogosity: Ham, tests=bogofilter, spamicity=0.000002, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 31.05.21 14:29, Mike Rapoport wrote: > From: Mike Rapoport >=20 > Commit 4e042af463f8 ("s390/kexec: fix crash on resize of reserved memor= y") > added a comment that says "crash kernel resource should not be part of = the > System RAM resource" but never explained why. As it looks from the code= in > the kernel and in kexec there is no actual reason for that. Are you sure? Looking at kexec-tools: kexec/arch/s390/kexec-s390.c get_memory_ranges_s390() wants "System RAM" and Crash kernel only with=20 "with_crashk=3D1". Your patch would change that. "Crash kernel" would=20 always be included if you make it a child of "System RAM". Further, get_memory_ranges() and is_crashkernel_mem_reserved() look out=20 for "Crash kernel\n" via parse_iomem_single(). However, parse_iomem_single() does not care about ranges that start with=20 spaces IIRC via sscanf(line, "%llx-%llx : %n" ... So once you make "Crash kernel" a child of "System RAM", kexec-tools=20 would break if I'm not completely wrong. --=20 Thanks, David / dhildenb