From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EABE3C4320E for ; Thu, 2 Sep 2021 12:16:23 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id A26AE60F90 for ; Thu, 2 Sep 2021 12:16:23 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A26AE60F90 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 36D786B006C; Thu, 2 Sep 2021 08:16:23 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 31CBF8D0002; Thu, 2 Sep 2021 08:16:23 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1E46D8D0001; Thu, 2 Sep 2021 08:16:23 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0020.hostedemail.com [216.40.44.20]) by kanga.kvack.org (Postfix) with ESMTP id 10D876B006C for ; Thu, 2 Sep 2021 08:16:23 -0400 (EDT) Received: from smtpin11.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay05.hostedemail.com (Postfix) with ESMTP id BEFCF1814C6F1 for ; Thu, 2 Sep 2021 12:16:22 +0000 (UTC) X-FDA: 78542531004.11.22453A3 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf26.hostedemail.com (Postfix) with ESMTP id 5951E20019EE for ; Thu, 2 Sep 2021 12:16:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630584981; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=0KB5SyFwwSjd3I7RFdLEADuQgZugol7EKe1fCuJWPl0=; b=I2eR2v4ideoBZh/xIUGO0/0hijQ55oylQ6uDOrReyt5QS2u+alZzFrABMwicCR/wcCARr0 w/Piq6afsGlSc51LhlDTNMvl3x7uyEPFc6ZlrLlvIcUEnpjocbW6bMXxtgjn9aJuTCtwvX fxQ4nftn8px4tUp1Dfe3+MTltj09wkg= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-135-NvqLjJqwPyWnk_4_kBYLAg-1; Thu, 02 Sep 2021 08:16:18 -0400 X-MC-Unique: NvqLjJqwPyWnk_4_kBYLAg-1 Received: by mail-wr1-f72.google.com with SMTP id b8-20020a5d5508000000b001574e8e9237so468863wrv.16 for ; Thu, 02 Sep 2021 05:16:18 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=0KB5SyFwwSjd3I7RFdLEADuQgZugol7EKe1fCuJWPl0=; b=NITQHmDnKwoDZUgrQUhjfgYv9BlSKDQghq2RGa+wlLVYRIkJRJ/tjxYSMe3pW8dsfJ 0ApjTgEJUts4/PW7TumbGAnRsxQx39eiYDZ+4eEa+g27gzlxgxlr/B/q1db4Rp4ZNpkS /Fg1AbHRTAsdrr044rvEaAH/3udWRxEv9TTB9Y+krYp1da+KYKdLCqugUIRtKTG79wVT nNY6fpMIQfoesjKylhizisdSSUhGLketJbzkMoe4FKrWfV2QlNioOtwXvpfvdJ4221ox bMQk/p+hvMgXnZbYfhw+Ete/BFThAri5XuqxUQXkvy4Msx+jmx5cVdBOjQqnFkA/IYwo e0SA== X-Gm-Message-State: AOAM530mExFAlOXhGLRjDepZSVddtGquhces3Y4FfXdOFQhuC2tKAqnB iK9a58+eS2XMejy6PNBSTprPcYkklO3jHnJwmdPAo6O6H+Gx4CcdMrai1pNo7mSTfZNKoC6vn2m lmDU7QDnIsBQ= X-Received: by 2002:a5d:6781:: with SMTP id v1mr3393710wru.249.1630584977386; Thu, 02 Sep 2021 05:16:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyxLVdMLy9E2mqTLvOGLjmzD7yZiwY5dVGzMc0woHfMYLZKh3OehsTEMsYjvAj3cc5ucR6Ohg== X-Received: by 2002:a5d:6781:: with SMTP id v1mr3393681wru.249.1630584977132; Thu, 02 Sep 2021 05:16:17 -0700 (PDT) Received: from [192.168.3.132] (p5b0c60bd.dip0.t-ipconnect.de. [91.12.96.189]) by smtp.gmail.com with ESMTPSA id k16sm1722414wrx.87.2021.09.02.05.16.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Sep 2021 05:16:16 -0700 (PDT) Subject: Re: [PATCH v2 5/5] mm/page_alloc.c: avoid allocating highmem pages via alloc_pages_exact[_nid] To: Miaohe Lin , akpm@linux-foundation.org Cc: vbabka@suse.cz, sfr@canb.auug.org.au, peterz@infradead.org, mgorman@techsingularity.net, linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20210902121242.41607-1-linmiaohe@huawei.com> <20210902121242.41607-6-linmiaohe@huawei.com> From: David Hildenbrand Organization: Red Hat Message-ID: <1ef3dc5d-7eb9-90a5-afbf-f551afcf7d8b@redhat.com> Date: Thu, 2 Sep 2021 14:16:16 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210902121242.41607-6-linmiaohe@huawei.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=I2eR2v4i; spf=none (imf26.hostedemail.com: domain of david@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=none) header.from=redhat.com X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 5951E20019EE X-Stat-Signature: d63wcfh33rznazwqmurrmand8chpgo7w X-HE-Tag: 1630584982-573194 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 02.09.21 14:12, Miaohe Lin wrote: > Don't use with __GFP_HIGHMEM because page_address() cannot represent > highmem pages without kmap(). Newly allocated pages would leak as > page_address() will return NULL for highmem pages here. But It works > now because the callers do not specify __GFP_HIGHMEM now. > > Signed-off-by: Miaohe Lin > --- > mm/page_alloc.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/mm/page_alloc.c b/mm/page_alloc.c > index 9c09dcb24149..e1d0e27d005a 100644 > --- a/mm/page_alloc.c > +++ b/mm/page_alloc.c > @@ -5614,8 +5614,8 @@ void *alloc_pages_exact(size_t size, gfp_t gfp_mask) > unsigned int order = get_order(size); > unsigned long addr; > > - if (WARN_ON_ONCE(gfp_mask & __GFP_COMP)) > - gfp_mask &= ~__GFP_COMP; > + if (WARN_ON_ONCE(gfp_mask & (__GFP_COMP | __GFP_HIGHMEM))) > + gfp_mask &= ~(__GFP_COMP | __GFP_HIGHMEM); > > addr = __get_free_pages(gfp_mask, order); > return make_alloc_exact(addr, order, size); > @@ -5639,8 +5639,8 @@ void * __meminit alloc_pages_exact_nid(int nid, size_t size, gfp_t gfp_mask) > unsigned int order = get_order(size); > struct page *p; > > - if (WARN_ON_ONCE(gfp_mask & __GFP_COMP)) > - gfp_mask &= ~__GFP_COMP; > + if (WARN_ON_ONCE(gfp_mask & (__GFP_COMP | __GFP_HIGHMEM))) > + gfp_mask &= ~(__GFP_COMP | __GFP_HIGHMEM); > > p = alloc_pages_node(nid, gfp_mask, order); > if (!p) > Ideally we would convert this WARN_ON_ONCE() to pr_warn_once(), but I guess this really never ever happens on a production system and would get caught early while testing. Reviewed-by: David Hildenbrand -- Thanks, David / dhildenb