From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E76A1C02194 for ; Fri, 7 Feb 2025 20:25:59 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7B0386B008A; Fri, 7 Feb 2025 15:25:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 738C8280004; Fri, 7 Feb 2025 15:25:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5B21A280001; Fri, 7 Feb 2025 15:25:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 29B4C6B008A for ; Fri, 7 Feb 2025 15:25:59 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 97DB7C20C5 for ; Fri, 7 Feb 2025 20:25:58 +0000 (UTC) X-FDA: 83094279996.15.E798D95 Received: from shelob.surriel.com (shelob.surriel.com [96.67.55.147]) by imf06.hostedemail.com (Postfix) with ESMTP id E99A4180009 for ; Fri, 7 Feb 2025 20:25:55 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1738959956; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8H3oUI38gT0E/FmzHgQQz9q+YLFArPKEnJ+c6VZ2230=; b=ZH8XS73Ue5kIAvvOovfOX0mgqWXYrAXz02GbN287wn2kaHEFNy1Y5lO6e4BRJY6L2JYWUZ Idk0KOCm3E7bGhAbvoZE7E9QYxzxNeAptdTS68Q3Vb66e4G5x74Q02MPQGd1eJCGrkqni3 1P7Y5vQhibGRsyaIZBgecilk1gst+cg= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; spf=pass (imf06.hostedemail.com: domain of riel@shelob.surriel.com designates 96.67.55.147 as permitted sender) smtp.mailfrom=riel@shelob.surriel.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1738959956; a=rsa-sha256; cv=none; b=J57LEPL20VVgnZr26g449H6VFrxSY5LJ4Kh9sIL4WeAfjmIAMah3hqvC2Ln1evDEh1dPWB jZdTy2CORHuHNLiefZEiyJJyLr4Rv3zCkMpY3DqQ2/ZrI4gHW9BMdNDx7FWlCrcjFyBUiR U5IRI2l+B4jynYQdU7T9a33skYuFwgQ= Received: from fangorn.home.surriel.com ([10.0.13.7]) by shelob.surriel.com with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.97.1) (envelope-from ) id 1tgUsN-000000002mj-3qSR; Fri, 07 Feb 2025 15:22:59 -0500 Message-ID: <1edea8a714fd1df0734f7fe15bb690e4c3a556dc.camel@surriel.com> Subject: Re: [PATCH v9 03/12] x86/mm: consolidate full flush threshold decision From: Rik van Riel To: Brendan Jackman Cc: x86@kernel.org, linux-kernel@vger.kernel.org, bp@alien8.de, peterz@infradead.org, dave.hansen@linux.intel.com, zhengqi.arch@bytedance.com, nadav.amit@gmail.com, thomas.lendacky@amd.com, kernel-team@meta.com, linux-mm@kvack.org, akpm@linux-foundation.org, jannh@google.com, mhklinux@outlook.com, andrew.cooper3@citrix.com, Dave Hansen Date: Fri, 07 Feb 2025 15:22:59 -0500 In-Reply-To: References: <20250206044346.3810242-1-riel@surriel.com> <20250206044346.3810242-4-riel@surriel.com> Autocrypt: addr=riel@surriel.com; prefer-encrypt=mutual; keydata=mQENBFIt3aUBCADCK0LicyCYyMa0E1lodCDUBf6G+6C5UXKG1jEYwQu49cc/gUBTTk33A eo2hjn4JinVaPF3zfZprnKMEGGv4dHvEOCPWiNhlz5RtqH3SKJllq2dpeMS9RqbMvDA36rlJIIo47 Z/nl6IA8MDhSqyqdnTY8z7LnQHqq16jAqwo7Ll9qALXz4yG1ZdSCmo80VPetBZZPw7WMjo+1hByv/ lvdFnLfiQ52tayuuC1r9x2qZ/SYWd2M4p/f5CLmvG9UcnkbYFsKWz8bwOBWKg1PQcaYHLx06sHGdY dIDaeVvkIfMFwAprSo5EFU+aes2VB2ZjugOTbkkW2aPSWTRsBhPHhV6dABEBAAG0HlJpayB2YW4gU mllbCA8cmllbEByZWRoYXQuY29tPokBHwQwAQIACQUCW5LcVgIdIAAKCRDOed6ShMTeg05SB/986o gEgdq4byrtaBQKFg5LWfd8e+h+QzLOg/T8mSS3dJzFXe5JBOfvYg7Bj47xXi9I5sM+I9Lu9+1XVb/ r2rGJrU1DwA09TnmyFtK76bgMF0sBEh1ECILYNQTEIemzNFwOWLZZlEhZFRJsZyX+mtEp/WQIygHV WjwuP69VJw+fPQvLOGn4j8W9QXuvhha7u1QJ7mYx4dLGHrZlHdwDsqpvWsW+3rsIqs1BBe5/Itz9o 6y9gLNtQzwmSDioV8KhF85VmYInslhv5tUtMEppfdTLyX4SUKh8ftNIVmH9mXyRCZclSoa6IMd635 Jq1Pj2/Lp64tOzSvN5Y9zaiCc5FucXtB9SaWsgdmFuIFJpZWwgPHJpZWxAc3VycmllbC5jb20+iQE +BBMBAgAoBQJSLd2lAhsjBQkSzAMABgsJCAcDAgYVCAIJCgsEFgIDAQIeAQIXgAAKCRDOed6ShMTe g4PpB/0ZivKYFt0LaB22ssWUrBoeNWCP1NY/lkq2QbPhR3agLB7ZXI97PF2z/5QD9Fuy/FD/jddPx KRTvFCtHcEzTOcFjBmf52uqgt3U40H9GM++0IM0yHusd9EzlaWsbp09vsAV2DwdqS69x9RPbvE/Ne fO5subhocH76okcF/aQiQ+oj2j6LJZGBJBVigOHg+4zyzdDgKM+jp0bvDI51KQ4XfxV593OhvkS3z 3FPx0CE7l62WhWrieHyBblqvkTYgJ6dq4bsYpqxxGJOkQ47WpEUx6onH+rImWmPJbSYGhwBzTo0Mm G1Nb1qGPG+mTrSmJjDRxrwf1zjmYqQreWVSFEt26tBpSaWsgdmFuIFJpZWwgPHJpZWxAZmIuY29tP okBPgQTAQIAKAUCW5LbiAIbIwUJEswDAAYLCQgHAwIGFQgCCQoLBBYCAwECHgECF4AACgkQznneko TE3oOUEQgAsrGxjTC1bGtZyuvyQPcXclap11Ogib6rQywGYu6/Mnkbd6hbyY3wpdyQii/cas2S44N cQj8HkGv91JLVE24/Wt0gITPCH3rLVJJDGQxprHTVDs1t1RAbsbp0XTksZPCNWDGYIBo2aHDwErhI omYQ0Xluo1WBtH/UmHgirHvclsou1Ks9jyTxiPyUKRfae7GNOFiX99+ZlB27P3t8CjtSO831Ij0Ip QrfooZ21YVlUKw0Wy6Ll8EyefyrEYSh8KTm8dQj4O7xxvdg865TLeLpho5PwDRF+/mR3qi8CdGbkE c4pYZQO8UDXUN4S+pe0aTeTqlYw8rRHWF9TnvtpcNzZw== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.1 (3.54.1-1.fc41) MIME-Version: 1.0 X-Rspam-User: X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: E99A4180009 X-Stat-Signature: gar6ckjt37padnsdn3d47f8apwyd6iwt X-HE-Tag: 1738959955-789438 X-HE-Meta: U2FsdGVkX19oqceV1drnPfvYPI0wlp9kYZX7dcMzc/r4dXl/bz4yG24xPpTmFpGt/Tbgr8goaT2tjMPwW2c20qRSquyhP6oiZmaZEtEd/dJOX7W3SkwkaF61+UHMGB/GGMFku1K3GLeRCqg4iiow28bzI2RwOlF8DLbPcHOG9espgqtSeRJ8BNQgsimpWAfQY26AYxHpEQKgVej3/vJ+Hjx/rf8rsI9OnF4puYaKEkJ8STN3rWuKe2ysAuYjP73d6ofCHMK9306dDkfrAbOTsG+8vPxD9YD1O4Gdo9UH32eqT52GrBxgA3pNiELshFu7hdAfSs8HIqVDUhVkZL5q/gPZDVohz/VsW+wDK1o+W27Ac/2zFZZAmZijduQdhwnuuu5Bcm64zqWC4TLCN1b3jpAxamzQ+VpeL7x9S6pTXnmRZ1hI9aRu4Z4rkZvgVlDDn5z1MaEyCFZp+6yI0tW+AEiK7hJnFIZypbrMlfL4Om+Numlvn4Dwul+ETl5+VIt2NZ9anjsuu3rYVWDTikP7V7WJjinj32cn3dacs9m0pZAT13aM3P2nsnk8lPK2W9NIcXjTJDx/3ka3cBnVBGwWYPteK+jY2ol9Scv52BmHVHPVqpqfqX1dkNnzklU3X4tjmnMfxYvE9yh0YCnkyXXGVeBoEjnF+XMk93TXfot/2Oot27QXfyDOj8Wm+q9oUibqE8q9C8YP9wtVK3bEztR64N38Bzr8LGTGF16hDRoncMTV4a71q3mt8bw7fY8DU9qY/d/2TXqCBSIhFbaZUOHCFTFL0j4TKh4d89g/z6TyRq6ghk9OFmE7uFfw8qwdWkxBuidbsB1ZuWjxCoCIITl1+njIOW/mVwrLQgCW2uLNUXc4x7mi+7OAP+fXDs1QstmajnVe1YT3zTp2xP/NFi1XK6TxS8LwmRRnmoOGnQ8HH8JPL5l1PpjbDxvKh5YxypfSTOKFt9FVMejKiTdhWbw vrMIK3+H 5YHJyB1Ofkxv2xoBZORpFJE7hmYvC/cKZdYvp2fmIzvQaB7o5UGBPHG+6hsp41ABuNgVkGAlekfkagds470X/KM1uKMrfXNpQwluJLZ11zMTuL7L/Wr8LbJY2LR6q330fzpi4n4CCMncWgBlUJZ3Vp/DksBflfXzHY+897l+JwtxDsqMcHEjU8ALyOf3AvvdlUDZroQZxY2pmOIc3RpMQ6SET4PDLiBE4DvpJniRizSh/uo/tqFKu5n5N0o4lDbmORarjmyFVUt3NowS1QRhXtuUk3Ru2wyfIaHnoKGzDsDH3rRuSWPVNfx00Y51xt8HSD7T5+bZthqgSExWUQGEVZ6mpPjfkawyoowzTfkyg24Ie+lCjuPs9rRU1Y6Ly1JYkHRZ0D9+3IB6rWruRqK2n4b9RSI8cyxxQ/mCmX6Z8F7zbVPXVfgE7TcyZnpspzvqbUV9yBf6YS0YdeDGdAfXopsjrKKjNraWTFwJK X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 2025-02-07 at 15:50 +0100, Brendan Jackman wrote: > On Thu, 6 Feb 2025 at 05:45, Rik van Riel wrote: > > @@ -1276,7 +1282,7 @@ void arch_tlbbatch_flush(struct > > arch_tlbflush_unmap_batch *batch) > >=20 > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 int cpu =3D get_cpu(); > >=20 > > -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 info =3D get_flush_tlb_info(NULL,= 0, TLB_FLUSH_ALL, 0, false, > > +=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 info =3D get_flush_tlb_info(NULL,= 0, TLB_FLUSH_ALL, > > PAGE_SHIFT, false, > > =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2= =A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0= =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 TLB_GENERATION_INVAL= ID); >=20 > [Why] do we need this change? If it's necessary here, why isn't it > needed everywhere else that does TLB_FLUSH_ALL too, like > flush_tlb_mm()? >=20 flush_tlb_mm() calls flush_tlb_mm_range(), which does also use get_flush_tlb_info(). We pass in PAGE_SHIFT here to ensure that the stride shift is specified correctly to the INVLPGB instruction later on. --=20 All Rights Reversed.