From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E2D4C369AB for ; Fri, 18 Apr 2025 10:52:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C747B280183; Fri, 18 Apr 2025 06:52:11 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C20F9280005; Fri, 18 Apr 2025 06:52:11 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A4815280183; Fri, 18 Apr 2025 06:52:11 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 80923280005 for ; Fri, 18 Apr 2025 06:52:11 -0400 (EDT) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E88A0161A87 for ; Fri, 18 Apr 2025 10:52:12 +0000 (UTC) X-FDA: 83346850104.12.16AE835 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 910191C0008 for ; Fri, 18 Apr 2025 10:52:10 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Bceo/nnd"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744973530; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=VkQeTK0Osg/+gnKBUiLYBnAJGjHxbf8m0YFBFQjNQb4=; b=Vbez+tVjKt9S3pIOPMLqarmtfvCu/Ao/YI5P8FLOYxeOxT4mT67I20NVnxFRTBEDve7/+1 SPlQlO9a60yvFfmwWxBrarwtFxrMtexOjPdKIdqeYRdBgOqc4TLQo0ruMgf5r2PTC8RK/2 wMn9T7J8B6YeR1PYGnQ02VV4AFHTbmE= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b="Bceo/nnd"; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744973530; a=rsa-sha256; cv=none; b=i0b54PF1z93GoG+ECp2EUzSCCHeOs1t0BZ1sQ82/GCWtNgiFs14fNJXEN6uVd9zer2ZFuc lhO2fJkvx2XTvOEWhmQpSFtbMJoUT4wd7EXvtMx0TM8Oi3pozlmkSfMgII2j0xEODHmDBl 4Gc4xEWUxuKqN0oSsQlb1ESI9of1Tkk= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744973530; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=VkQeTK0Osg/+gnKBUiLYBnAJGjHxbf8m0YFBFQjNQb4=; b=Bceo/nndoQyAzIIYQfWuD35wf+IIMd9KrqpAeSgVqDegCacfhhLjknBITJ57fsOi5/OGsJ +m1D0cVkC6rmvWEfP7PYvMzQltjJBGENxhRvc3mzWma2F9ciq0RziPGzpXgYUYTwTxgA/z cSq8Hkn8kXYNbIu7fWngGCzHRCc3fqA= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-684-omyMR3UfMfKlTAD5j0bzKQ-1; Fri, 18 Apr 2025 06:52:08 -0400 X-MC-Unique: omyMR3UfMfKlTAD5j0bzKQ-1 X-Mimecast-MFC-AGG-ID: omyMR3UfMfKlTAD5j0bzKQ_1744973527 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43d0830c3f7so12304925e9.2 for ; Fri, 18 Apr 2025 03:52:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744973527; x=1745578327; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=VkQeTK0Osg/+gnKBUiLYBnAJGjHxbf8m0YFBFQjNQb4=; b=DA3DcmPz9081rbAwdJACmW+OdfEfFFCk4Q5PsoXHEzLKtpyzZsbtf7fHr67yJ0ZRY9 Sgoz/46ah1ZPcL+LeI1b6Q8+XgGaTlOF0M2iaXkbsiJImzUUrecHeCIaF23FIH+dVbtr KeqBu1qltYioRJZvoqeWqBWUpB1QtQOOxzSe9CP4leyH0Liapfo/tCzOgIsvtSv1ODfQ JdojSdjuSxA7lpUAlsF/TiGx+uN1EOFGEfn+9KG5bJNQKRzm6WjwwgAYeQK77Kl2CmEe qgvQFRJ3pMeZyewOsgcDSa2veNWVHir/mOlTVG5w8uS6BD0cavjaUTFoViy/rsAOsAzl W2cg== X-Gm-Message-State: AOJu0Yzk9F6hE74ak8UBYnnoAO6YX2EAFbJsZQJmmlmPTha54tsotbvn 9cn+w+BWxjPVuAhejdh1OgbnTED5iMJo6Z/16ONNSAzrgZUEb9JZNR4nhhPAiGY75JuWTret07H 1J6bVvXr50ETMoBzwcbrxRZEUMD8h4zUYZhN46+NbgX7eSXGm X-Gm-Gg: ASbGnctGfws6A7kRjUv/uQ0P2xzy49phiWK+E5F8s6PEtsDLz4xyXEeNue+OxF9zC2Y ViAvgSUvcPWHjbQPj8PLmtPoqAPBxb1MQ06ZRTjzAUT7UjczeVb/aQwClbZXEw2nOx6f5M1/m6A PyPogIjDjQm+z5yshPj1fFbbGguSsIL9/Le9KDuuMCs3II+6cdRZd2RLOBEFZydq/NnJl+5Xo1U 9iegnegR5Q9B240xrXryhP4bzYw/Mr9uHutDDubwPt/TzWEsIl/VzOT46Ss4Kfop3zWRE9sQ279 uyAKXQj4LNak9kArFS0u5Qi2IS+0vw9DBw3pjHJwzbez4hmLuAhAHbu0mHShA7lLWfOWc2NAnYk Eax/lOAGvJO/tnrxl4QXK6TxOgMCKDdA66mb/xKs= X-Received: by 2002:a05:6000:402b:b0:38b:d7d2:12f6 with SMTP id ffacd0b85a97d-39efba2c999mr1692890f8f.2.1744973527481; Fri, 18 Apr 2025 03:52:07 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGhcvLbsU9H37fV4GPewg1icxIKI6LTUrTHeLEmRYvRgt6g8jAb0T9lKbbro2n7huJC9W/kSQ== X-Received: by 2002:a05:6000:402b:b0:38b:d7d2:12f6 with SMTP id ffacd0b85a97d-39efba2c999mr1692875f8f.2.1744973527105; Fri, 18 Apr 2025 03:52:07 -0700 (PDT) Received: from ?IPV6:2003:cb:c70e:6700:cada:5396:a4f8:1434? (p200300cbc70e6700cada5396a4f81434.dip0.t-ipconnect.de. [2003:cb:c70e:6700:cada:5396:a4f8:1434]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39efa43c079sm2447037f8f.50.2025.04.18.03.52.06 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 18 Apr 2025 03:52:06 -0700 (PDT) Message-ID: <1ed925bd-897e-44b6-ad20-7d61c8c57aa8@redhat.com> Date: Fri, 18 Apr 2025 12:52:05 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v4] mm: add zblock allocator To: Johannes Weiner , Vitaly Wool Cc: linux-mm@kvack.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Nhat Pham , Shakeel Butt , Igor Belousov References: <20250412154207.2152667-1-vitaly.wool@konsulko.se> <20250416120912.GC741145@cmpxchg.org> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250416120912.GC741145@cmpxchg.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: c4sgS5-y6uKFGnyr0ow4iMVhexmjsiBgDEkeEKJSSls_1744973527 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Stat-Signature: 17dpkf8gst37iu6h1ndn1cqggmwjrbug X-Rspamd-Queue-Id: 910191C0008 X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1744973530-754667 X-HE-Meta: U2FsdGVkX1/Ul1DzRCyRXL7ZwMwKDrSrobfwsrVjpAlI8z3XOTI3lrQlfsY/tsjDxVdX1hW6+BwQxRm7x9pZaBhnarJvrBRbO10M6ES92zMc+YFWCL8sy9SUHbqTl0+9HXrpmmcYCFy4DkFHmE0pVWNDIbClEkws3q8C2Cz4RfFBYUtG4Msu8MBIs1ptqu6doeGobaebrSWudH5PYemHYkP1b83BP4nV75S6EYVQLYvgrJDGj5+kUb0SZGPq6nf5nUmZxbShI5mw/nxNlxSXIPE0J9+Rlke1oKdYqRxENF4fE4LK2W7AuCDqu7vsAM4ydfJdsT1y7QaGRjb5C9+7gZTGhIg3M5A0jmWCVHqYBtMBePkA0JLh2o10cUM5BWq5fA0b4T9q8Y7l+YqWsFKGMyeToiRhbm1dPB7LJBHbxFkB+BskBVd5P4uGJUu0/dIIWZXGWznsqGfJw5VRYfjXZH8ZcClbuzedHsaNrK1fZkTV9LD8xcUeYylwQG4/OiUUsSWa7vbxKHQYhOcklounCNBbXR+Zp+cWk5Rc5cThiTH1LSLHCCIcGQtZWO0pM7ZnODvmdVpzbc++nbcIjBuAXwpyALNZtjhBtyoytMv72+xwxh1ARXMsPJFeCr+m85TPHtHO1Le9rseH82rQpurx76vfbQWqe7LeqI/mfB5KZbtq2owTJHKm2dAbAUlS4ano/PDrQvIssG306vGchszxJVW6gFd1aMKWKYM3ig5UrsWjulGghIXcyYiURjYah5+rFXmF+VUoC/9X1wBqBB5uOtb8vAmiBce17/P8lQlIBO2aGuETT9DzT6TLpswsT/NpxVuchl64PlEXd6ffPr/VkjUTQKNanvjMGyjqb9E5Y4XBdrbjzcFqQd7bX2VwYJSqUaq9aQ+0HH/mnCsBhn9UwQyNFRsVLwhtGQZ04HRwIOo7I7Ms4uYuYXVZhZ46HlMmuBcUshNuc+mJ+clZLMV 0mKmisPg 3lWb0KMFzA7Ea+b+0fK0Kg2OWvoHSBCJ+R7bppq0z5I4tQgqwdvqrR7jQ90S0l8koJK/H3VZo0v5VIDQTRuS35vv8Zrvp24yWgFLWYRLH645tiAUw3vto+iLloIOWgvYaSOWaJmkPLVkHVGTIE763s1eWBDBhRXxXPw8zVcsnwPc6v2v0t/M2R0ObwIvOOJJg+VH0gCURnmMdZWtF6nWTkWLlWeOUQ7fYk2+18TQgdxZb3K+20ZSmzVuxO1ZBLWBiN6bvlpCbMKM27USQPzrfBMZh0siC/XmuynOraQ8LJmGebKFKVF4I1Jp340JZabYoWu/RCaoQui5WmH4/XwpklZkWLHPN9KQnX0nISU66Jz4MuEK1tnq/fZcA6aA0pvqZHfCC7C/6k1IEtl7ieoggO8mZHeqk84BCh3ZTGeadbijfy7mhVcIRnI1wdEc8PX8Dv88kJsvtL15PjVg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.04.25 14:09, Johannes Weiner wrote: > On Sat, Apr 12, 2025 at 05:42:07PM +0200, Vitaly Wool wrote: >> zblock is a special purpose allocator for storing compressed pages. >> It stores integer number of same size objects per its block. These >> blocks consist of several physical pages (2**n, i. e. 1/2/4/8). >> >> With zblock, it is possible to densely arrange objects of various sizes >> resulting in low internal fragmentation. Also this allocator tries to >> fill incomplete blocks instead of adding new ones, in many cases >> providing a compression ratio comparable to zmalloc's. >> >> zblock is also in most cases superior to zsmalloc with regard to >> average performance and worst execution times, thus allowing for better >> response time and real-time characteristics of the whole system. > > Is there a reason not to use this allocation scheme in zsmalloc then? > > I'm curious what others think, but I'm still not convinced a second > allocator makes sense. It's maintenance overhead, a permanent struggle > to match feature parity, and it fragments development and testing base. > > Not long ago several slab allocators were removed for those > reasons. Likewise, we just deleted zbud and z3fold because they didn't > get any attention and bitrotted, but not before years of inflicting > pain through the zpool interface, users accidentally making very > suboptimal choices, reporting the same bugs over and over again etc. > > If you discovered a better allocation scheme, that's excellent. But I > don't see why it warrants forking the entire allocator. Just curious, I see a review on v4 happening on something that was nacked by two people in v2 [1]. Do these nack's still apply or were something clarified and they no longer apply? [1] https://lore.kernel.org/linux-mm/CAKEwX=Ma9phmURz5nyJm0MQrWmXGFLFBPwr8-Cx=zbc473rx9A@mail.gmail.com/ -- Cheers, David / dhildenb