From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2B1E0C433DF for ; Tue, 30 Jun 2020 03:54:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id E432A206B6 for ; Tue, 30 Jun 2020 03:54:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E432A206B6 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5C34B6B0093; Mon, 29 Jun 2020 23:54:00 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 573AC6B0098; Mon, 29 Jun 2020 23:54:00 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4891B6B009B; Mon, 29 Jun 2020 23:54:00 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id 32BB06B0093 for ; Mon, 29 Jun 2020 23:54:00 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C041B180AD804 for ; Tue, 30 Jun 2020 03:53:59 +0000 (UTC) X-FDA: 76984509798.02.help82_3f14b0026e74 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin02.hostedemail.com (Postfix) with ESMTP id A9C0630001079A8C for ; Tue, 30 Jun 2020 03:53:59 +0000 (UTC) X-HE-Tag: help82_3f14b0026e74 X-Filterd-Recvd-Size: 4900 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf25.hostedemail.com (Postfix) with ESMTP for ; Tue, 30 Jun 2020 03:53:58 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 2739030E; Mon, 29 Jun 2020 20:53:58 -0700 (PDT) Received: from [10.163.84.101] (unknown [10.163.84.101]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 5EE3D3F73C; Mon, 29 Jun 2020 20:53:47 -0700 (PDT) Subject: Re: [PATCH V3 0/4] mm/debug_vm_pgtable: Add some more tests To: linux-mm@kvack.org Cc: christophe.leroy@c-s.fr, ziy@nvidia.com, gerald.schaefer@de.ibm.com, Jonathan Corbet , Andrew Morton , Mike Rapoport , Vineet Gupta , Catalin Marinas , Will Deacon , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , Heiko Carstens , Vasily Gorbik , Christian Borntraeger , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , "Kirill A . Shutemov" , Paul Walmsley , Palmer Dabbelt , linux-snps-arc@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-riscv@lists.infradead.org, x86@kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Christophe Leroy , Vineet Gupta , Vineet Gupta , Qian Cai References: <1592192277-8421-1-git-send-email-anshuman.khandual@arm.com> <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> From: Anshuman Khandual Message-ID: <1ed72a76-9f20-0169-4c16-c1d8808690eb@arm.com> Date: Tue, 30 Jun 2020 09:23:35 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <70ddc7dd-b688-b73e-642a-6363178c8cdd@arm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: A9C0630001079A8C X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 06/24/2020 08:43 AM, Anshuman Khandual wrote: > > > On 06/15/2020 09:07 AM, Anshuman Khandual wrote: >> This series adds some more arch page table helper validation tests which >> are related to core and advanced memory functions. This also creates a >> documentation, enlisting expected semantics for all page table helpers as >> suggested by Mike Rapoport previously (https://lkml.org/lkml/2020/1/30/40). >> >> There are many TRANSPARENT_HUGEPAGE and ARCH_HAS_TRANSPARENT_HUGEPAGE_PUD >> ifdefs scattered across the test. But consolidating all the fallback stubs >> is not very straight forward because ARCH_HAS_TRANSPARENT_HUGEPAGE_PUD is >> not explicitly dependent on ARCH_HAS_TRANSPARENT_HUGEPAGE. >> >> Tested on arm64, x86 platforms but only build tested on all other enabled >> platforms through ARCH_HAS_DEBUG_VM_PGTABLE i.e powerpc, arc, s390. The >> following failure on arm64 still exists which was mentioned previously. It >> will be fixed with the upcoming THP migration on arm64 enablement series. >> >> WARNING .... mm/debug_vm_pgtable.c:860 debug_vm_pgtable+0x940/0xa54 >> WARN_ON(!pmd_present(pmd_mkinvalid(pmd_mkhuge(pmd)))) >> >> This series is based on v5.8-rc1. >> >> Changes in V3: >> >> - Replaced HAVE_ARCH_SOFT_DIRTY with MEM_SOFT_DIRTY >> - Added HAVE_ARCH_HUGE_VMAP checks in pxx_huge_tests() per Gerald >> - Updated documentation for pmd_thp_tests() per Zi Yan >> - Replaced READ_ONCE() with huge_ptep_get() per Gerald >> - Added pte_mkhuge() and masking with PMD_MASK per Gerald >> - Replaced pte_same() with holding pfn check in pxx_swap_tests() >> - Added documentation for all (#ifdef #else #endif) per Gerald >> - Updated pmd_protnone_tests() per Gerald >> - Updated HugeTLB PTE creation in hugetlb_advanced_tests() per Gerald >> - Replaced [pmd|pud]_mknotpresent() with [pmd|pud]_mkinvalid() >> - Added has_transparent_hugepage() check for PMD and PUD tests >> - Added a patch which debug prints all individual tests being executed >> - Updated documentation for renamed [pmd|pud]_mkinvalid() helpers > > Hello Gerald/Christophe/Vineet, > > It would be really great if you could give this series a quick test > on s390/ppc/arc platforms respectively. Thank you. Thanks Alexander, Gerald and Christophe for testing this out on s390 and ppc32 platforms. Probably Vineet and Qian (any other volunteers) could help us with arc and ppc64 platforms, which I would appreciate.