From: "Maciej S. Szmigiero" <mail@maciej.szmigiero.name>
To: Vitaly Wool <vitalywool@gmail.com>
Cc: Linux-MM <linux-mm@kvack.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
"Agustín DallʼAlba" <agustin@dallalba.com.ar>,
"Dan Streetman" <ddstreet@ieee.org>,
"Vlastimil Babka" <vbabka@suse.cz>,
markus.linnala@gmail.com
Subject: Re: [PATCH] z3fold: fix retry mechanism in page reclaim
Date: Sun, 8 Sep 2019 15:56:45 +0200 [thread overview]
Message-ID: <1ed46a95-12bc-d8ee-0770-43057a09f0d9@maciej.szmigiero.name> (raw)
In-Reply-To: <20190908162919.830388dc7404d1e2c80f4095@gmail.com>
On 08.09.2019 15:29, Vitaly Wool wrote:
> z3fold_page_reclaim()'s retry mechanism is broken: on a second
> iteration it will have zhdr from the first one so that zhdr
> is no longer in line with struct page. That leads to crashes when
> the system is stressed.
>
> Fix that by moving zhdr assignment up.
>
> While at it, protect against using already freed handles by using
> own local slots structure in z3fold_page_reclaim().
>
> Reported-by: Markus Linnala <markus.linnala@gmail.com>
> Reported-by: Chris Murphy <bugzilla@colorremedies.com>
> Reported-by: Agustin Dall'Alba <agustin@dallalba.com.ar>
> Signed-off-by: Vitaly Wool <vitalywool@gmail.com>
> ---
Shouldn't this be CC'ed to stable@ ?
Maciej
next prev parent reply other threads:[~2019-09-08 13:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-08 13:29 Vitaly Wool
2019-09-08 13:56 ` Maciej S. Szmigiero [this message]
2019-09-08 20:44 ` Vitaly Wool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1ed46a95-12bc-d8ee-0770-43057a09f0d9@maciej.szmigiero.name \
--to=mail@maciej.szmigiero.name \
--cc=agustin@dallalba.com.ar \
--cc=akpm@linux-foundation.org \
--cc=ddstreet@ieee.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=markus.linnala@gmail.com \
--cc=vbabka@suse.cz \
--cc=vitalywool@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox