From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE07FC30658 for ; Tue, 2 Jul 2024 11:55:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 52A966B0083; Tue, 2 Jul 2024 07:55:38 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 4DA866B008C; Tue, 2 Jul 2024 07:55:38 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3C9C66B009B; Tue, 2 Jul 2024 07:55:38 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1CF866B0083 for ; Tue, 2 Jul 2024 07:55:38 -0400 (EDT) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id BC2231C34E6 for ; Tue, 2 Jul 2024 11:55:37 +0000 (UTC) X-FDA: 82294657914.27.794A2C3 Received: from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188]) by imf14.hostedemail.com (Postfix) with ESMTP id 670F3100018 for ; Tue, 2 Jul 2024 11:55:34 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1719921318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5OIwWgcrkSU9DckpCLhsEKknUS8qFCD3eoXRGwWfxiI=; b=g50gdnUSWBYcCTrZEO57UGjh3MHLv8nF4Wm91KN1EknaPM0bVAgNMbpujXTTcCaqIpyjuV 6E3mYbqriIw/APVlxpv7IpCXxQURJ1dz+dkg9BOciq52t4U7xsb+4yH4lAMfDepgMHUA6p s/TpcGzZJ47IdR4w7woB5U5GceWh6AU= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; spf=pass (imf14.hostedemail.com: domain of lihongbo22@huawei.com designates 45.249.212.188 as permitted sender) smtp.mailfrom=lihongbo22@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1719921318; a=rsa-sha256; cv=none; b=tf0ZdM5JySQdABvPoVQF8pHxCvKZoTP55VPwziefo0UsbAU5I7kTqw66FjW2upu2+aCeWb zJrhPg0eZ2R65A2yTbXjvqoUs3/FbEGu/SuymrftCSROSFCSh6/hULOY6w+pwjdtptKc2F DDw9WghQ11IJT3DXoG8rVZzpgCSXPRk= Received: from mail.maildlp.com (unknown [172.19.163.174]) by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4WD1Yt3YpmznX51; Tue, 2 Jul 2024 19:55:14 +0800 (CST) Received: from dggpeml500022.china.huawei.com (unknown [7.185.36.66]) by mail.maildlp.com (Postfix) with ESMTPS id E5277140414; Tue, 2 Jul 2024 19:55:29 +0800 (CST) Received: from [10.67.111.104] (10.67.111.104) by dggpeml500022.china.huawei.com (7.185.36.66) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2507.39; Tue, 2 Jul 2024 19:55:29 +0800 Message-ID: <1eca1fcd-5479-47b2-b7ba-eb4027135af2@huawei.com> Date: Tue, 2 Jul 2024 19:55:29 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/2] hugetlbfs: use tracepoints in hugetlbfs functions. To: Steven Rostedt CC: , , , , , References: <20240612011156.2891254-1-lihongbo22@huawei.com> <20240612011156.2891254-3-lihongbo22@huawei.com> <20240701194906.3a9b6765@gandalf.local.home> Content-Language: en-US From: Hongbo Li In-Reply-To: <20240701194906.3a9b6765@gandalf.local.home> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.111.104] X-ClientProxiedBy: dggems701-chm.china.huawei.com (10.3.19.178) To dggpeml500022.china.huawei.com (7.185.36.66) X-Stat-Signature: g4szjqio6n3kthm7bzgnnyu9gjs1ciey X-Rspam-User: X-Rspamd-Queue-Id: 670F3100018 X-Rspamd-Server: rspam02 X-HE-Tag: 1719921334-97958 X-HE-Meta: U2FsdGVkX1/6OKI68K6q+e3tc4uabcanmQV1RMbxbgZQyDnM8XoVZhjclAhkCQ+iV0CUJXgtcNb0jtQBSEhcjcC2V3fqeP+xs9Zp1jCH//BJdLPedKmdlX0NEJF142typnHBxCPe3QDdpfe9eXacySc9fcYKmM1FAI2yqpuB+4A1DsFiXWo6BYoAdrWqQ7c6ERC/T5ubjVoX8Y04t7rrk1/81IXT+Pjq4mos22k3zEhvMgZonhzxZ7mlSDmw5y/H8oFu8JVfSAOu3QEkUmvUIvyWtiYSrpEE7WgY6XoT/A5QCzdiwSD94k3ABo8KLMGR74JzVyT0rQpQ3vITIksvooGZQwh5h9YDOx5TcGYC9AYn5Yyy/HXmxWV3cXaqonHnpqKADpXtFCQlqXJRn3+IMSKsvpQWhdC5vkmZW0eSdsVQhA19ee2F5bGj6WcBvxiR4wLt6DUhuTJKFgPdN949SkT/y+gsk48XujEXbtthPHcdvbJHyZdFd5aO+zFTj/vk4gviW/1V8MIksisLmaLdeLTtZGyu2capkQCw6MN1PpQr2YXdtcUc9MZog/suNaxSKOvF4bQ1ZYVPXpVK/sDAOjwoJs+XReuyRM9/xHx7BV3D4C4u1tc+qBK71YauUYhe8Kp45tTId5S7YJ61HUpdCiOYoIBRqo+6aWCoZByxDlZlu/2DCkHAqxQEIdM/VpVsaDcOR3m1mFTWB6ZUQAF7JfRcmGjUTk2lxCn/OgD7pf/cn8f5+xSIN0TtLDAzejWVsQ6RMw8WxR6+ikA2Q06n5DLCj7a6gxwGt9dmIWU/7g79cpTxIkvLk+5iei/uY5oHsLIHQaMFQB4CeJ2Izhk1EU/mi16HAfOf/IAjZ9QmUQIm1xYicVJv9KPB+3h8b9X/97KuyP2IChe/P9c7W9SxemYFY3bpGlgf4u3gcnBDq2tJNAuhxAwKPds29yjL7RwpfK2qoQSRj2khTUjKADy HDFlomen ReFbwAuEfCSTOBgfRiWTqzZr1iX2KpUmQugG9f7GVOCXjnvmXKsuiDfhq8rFsuERSMAFfevgmvmJzRSSwaH9h//85BBmk0bY7WyJUh7J61dgTYcID8AQV4+oLdIrTHlxOaZ0tbXBAPoomlLv6M4WdZsA6npRvftz1mLtbn6uY7DGUHETvJakXriiUXMCI8YLCA4I1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/7/2 7:49, Steven Rostedt wrote: > On Wed, 12 Jun 2024 09:11:56 +0800 > Hongbo Li wrote: > >> @@ -934,6 +943,12 @@ static int hugetlbfs_setattr(struct mnt_idmap *idmap, >> if (error) >> return error; >> >> + trace_hugetlbfs_setattr(inode, dentry->d_name.len, dentry->d_name.name, >> + attr->ia_valid, attr->ia_mode, >> + from_kuid(&init_user_ns, attr->ia_uid), >> + from_kgid(&init_user_ns, attr->ia_gid), >> + inode->i_size, attr->ia_size); >> + > > That's a lot of parameters to pass to a tracepoint. Why not just pass the > dentry and attr and do the above in the TP_fast_assign() logic? That would > put less pressure on the icache for the code part. Thanks for reviewing! Some logic such as kuid_t --> uid_t might be reasonable obtained in filesystem layer. Passing the dentry and attr will let trace know the meaning of structure, perhaps tracepoint should not be aware of the members of these structures as much as possible. Thanks, Hongbo > > -- Steve >