From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3A636C5B543 for ; Tue, 10 Jun 2025 10:38:05 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C7B086B008C; Tue, 10 Jun 2025 06:38:04 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id C52766B0092; Tue, 10 Jun 2025 06:38:04 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B68AC6B0093; Tue, 10 Jun 2025 06:38:04 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 958096B008C for ; Tue, 10 Jun 2025 06:38:04 -0400 (EDT) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 417CEC0DB3 for ; Tue, 10 Jun 2025 10:38:04 +0000 (UTC) X-FDA: 83539140888.07.9B6203D Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by imf11.hostedemail.com (Postfix) with ESMTP id BEB9140002 for ; Tue, 10 Jun 2025 10:38:01 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VVDSCKHR; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1749551882; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=aI6UmbgwdlVAnCc78+kA++Zeb+kmoiPB+fmNOOceC0w=; b=Q3sTnebFOavhUMdcfZJVhz2SjFXu+pMJDqckygn6ebdppJTidpezviPvd/CzTCzlCwen4S y5yvlvoQ3hHhdyu6C+WXa19H2hstUMEm3D9Ofr4i4fWTMtnAkgDVCYy5QFQDZdZeswzQzf S7JeMA7ciCRjU6Htsfgu64t87q5dnY4= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=VVDSCKHR; spf=pass (imf11.hostedemail.com: domain of david@redhat.com designates 170.10.129.124 as permitted sender) smtp.mailfrom=david@redhat.com; dmarc=pass (policy=quarantine) header.from=redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1749551882; a=rsa-sha256; cv=none; b=JHGnn4A5PhrfsqygGtZcCg9KDOlltTIiyAkU+Q5w1wtfGf2rRInDs5cdlWJg7uMF91wFUa aWTO/8itrLwhC5anb32AYAGvQamkI70Ex0whsFGeocQ1S3pOGNzP6b2qmRGtXOmTbcrWvk DkIjoexdlppXxSRX7zZbho1VgXaH4OA= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1749551881; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=aI6UmbgwdlVAnCc78+kA++Zeb+kmoiPB+fmNOOceC0w=; b=VVDSCKHRpVkmLpLgFD1gfMlvDsMgTTeTeIBYsaN5PbC9QM/+V82eiEgE9T9cvr/Fcx09/z q+ngo8vYlmC9Iv8jbfIPBhdJaBxK0kWVcayhTt8s0gqBhwyijQ89zaGpKjTDP0O2MQKsvC IR1RcD+WSvxiVz0l5HG4rFSl32vUZsI= Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-193-v0wpBqclPo2hGuApO1F1Tw-1; Tue, 10 Jun 2025 06:37:59 -0400 X-MC-Unique: v0wpBqclPo2hGuApO1F1Tw-1 X-Mimecast-MFC-AGG-ID: v0wpBqclPo2hGuApO1F1Tw_1749551879 Received: by mail-wr1-f71.google.com with SMTP id ffacd0b85a97d-3a4f8fd1847so1879672f8f.1 for ; Tue, 10 Jun 2025 03:37:59 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1749551879; x=1750156679; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=aI6UmbgwdlVAnCc78+kA++Zeb+kmoiPB+fmNOOceC0w=; b=wqlaZPMMe+/592EAix36yM6BdDEWCOw4ep/ogYIDCposq69W762phw7iyBZPxwpRtW jPdhJc1XMbkhVQsH8gZ2FLdPDwsHkOstqwsMR0POW5wtQThy/zVnhQaZoC04sgTl8wD9 gGuXQxlkudxU45Vspkn9K7PDkdUfQGod9+gY1hj1C+wb8nV9P/igWGVHWfMnpTWLEgLA vj/NNFLmT16sLrekfF5KSafQHRGHIF+MkLpl4wU/gtaCPCN9fIretA1G+PHzrWXzQUUw H6TqZ3zrDWVYIbcKJLYO4KERr6JOBoTiY8kfBmTrMFDpwL/eOs+L6w4QSVqBNpfOzcq+ KI5Q== X-Forwarded-Encrypted: i=1; AJvYcCXyMIxsqo6b1mJXCIDCEMkzb9odRavhmIujB+T5jEidSQYOkxst1F+cSdH3mPrM5+PhhdjJMVcjew==@kvack.org X-Gm-Message-State: AOJu0YzkEOPB9M2K0Lcn2bur39FEKgUwRTQPanx6jgC9Eb933l0WItES rvrprIRCB8O6kFmVzH4tsKkRymZY1cpZgsBexL/2byjSvq+8F+cjayighTFsUocYFo8mY+O+2vj q+2v2zmF4JBKCiOdlgUPR3n4kPbACHdxRY64AEt57cuuIZe1JKZYH X-Gm-Gg: ASbGncsWKzkNGUWUlS27zV9qAixG3gcWivQDHAM8eNvYF3vTtC1Oc1k71zPegNpAUoW P1lfvSrV5uUaiJTOgtopZ6VPgTx+2IUt8ubj4w/FXLJYGJHHfAbsyfjSpyDwrgt2GMxfMBU8bNE r/tf19yU+gUs+MI3B/PNatLTZjzRCarsJs7jOHZa/LnaSbsMonc+Grc4s2jBe//0SlU9cy+eUiM laW4saxaq7jZqUncO6sNMH+nHfYV2pe0pnj6U6aI3ickqsBINLx3sum7okc2oK9vpdll7gIiMG6 eloEz9D4Nb3f0osC6eX14ZJj2pqE+yEoL6aNuasgbWOml0eofxRcg6c= X-Received: by 2002:a05:6000:26c5:b0:3a4:f7f3:2d02 with SMTP id ffacd0b85a97d-3a5522716a9mr1608115f8f.17.1749551878749; Tue, 10 Jun 2025 03:37:58 -0700 (PDT) X-Google-Smtp-Source: AGHT+IG6jkrSTQLJlhMrYdllOzIW6Ete/JGJLtTiYCIoUWXSkxb/sdVLs38Feted1QX/mOtzl90MWQ== X-Received: by 2002:a05:6000:26c5:b0:3a4:f7f3:2d02 with SMTP id ffacd0b85a97d-3a5522716a9mr1608088f8f.17.1749551878384; Tue, 10 Jun 2025 03:37:58 -0700 (PDT) Received: from ?IPV6:2a09:80c0:192:0:5dac:bf3d:c41:c3e7? ([2a09:80c0:192:0:5dac:bf3d:c41:c3e7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-45320b16657sm9031205e9.8.2025.06.10.03.37.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Jun 2025 03:37:57 -0700 (PDT) Message-ID: <1ec55f0b-991f-4ea0-869e-5fc0be719c8f@redhat.com> Date: Tue, 10 Jun 2025 12:37:56 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1] mm: Remove arch_flush_tlb_batched_pending() arch helper To: Ryan Roberts , Andrew Morton , Catalin Marinas , Will Deacon , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexandre Ghiti , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Lorenzo Stoakes , Rik van Riel , "Liam R. Howlett" , Vlastimil Babka , Harry Yoo Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, linux-mm@kvack.org References: <20250609103132.447370-1-ryan.roberts@arm.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250609103132.447370-1-ryan.roberts@arm.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: AWuL_lpSw9dD1Iy15aEVf_7aEnaj7sOawhV1QbLm_xs_1749551879 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: BEB9140002 X-Stat-Signature: qh5ztw9zdsy6bugkc3ad8djix8uya4rs X-Rspam-User: X-HE-Tag: 1749551881-545535 X-HE-Meta: U2FsdGVkX18R3margEqO60Q1zlvSUcsvsNPz+kwRig5KBv+autO1ht1wjdaAVLRVP50VadqmCLoi4TgwHILIr8/nBMO1vseFV9lNekNc9WncBSvdD39TjaogCc75xFjVKNEkm3qhRN1l14/O81oVqZUXhQgOHRoyOp5oCpdzlp4BdU/ahEu922mkZKm3h+/4/lQu4eRPJ4qeljKOgOFG5/7c+5vXUlAUOYrCikrt6VrwukfziUuISkvWP1vynsTURTc/FS6XYxpk4YCM1XViM4WiG3MVLIsWTmkc0narqzVBi6ykqLAjjqTu07X0vpWaKsg7NY1LuNluUQqJVeapn6sGaYUHze2wzp9qoQQ5mmEjgEDTKoAzckJDRocYfqMQTY7UXDS+RQH0KERpPhlFALk2s+KOWnSKEFIMcCcn3Tm6RntfqwvmFDUu3qukhsJcYt8uKJFAZN86M4+SXqXU9a4tOGspJd0aUgsWm09XQdPQFYaOgvM8LzXT3S+Km9w+mlXlThqk43YjjpKrt6hKlZ3SPaq9AN1/DRkU42KA98ETT79SgOSDMBTXCgOi5rTJB7jLCHab2f5xqRPep+NxcJIHp7ywI0+Pq/tf6kbbUj9cct6pW6o7vjVcrqfPIvrU5Kv++n7Q0cD0RzwmqGpd5n/TnrnQgS9qVmsEvvDeRvIV0ebX7Ksn04MnwlDQi6OebKkP4wxSadiWOLBk4OGoTD7b5yQah00+evdAHtpw7+jvq7l5xuKYrfsseUjEvazahjkIVc34nRyYypqif1wmwMfIQWCXrbFLVPt9BPqONyv1ifQB0dIN3poyuGAEti9zRnfb7plFL/iIguiIvCOp/Q+ncHkc7LQZvm6Vl1D1mI0lPzVYy8dvBYX36i8+wXKrAwHvIktCJCM/G/cIMqFbiTYSt21gwhCXjm6dZ7QhM43BpBdwcD8VnkqkijGlWgNJdVWk97Ktg++mt/CCb9/ w0iZywky VGUWLun5kGfb2BkOZHBGLHAbS6hYbsJTiUBynZcmtX4ZhmfJRJOFqPv3JkeWz24WU3KWVdmRvb1lcrAZALPWpXjsjsU9h5BJtPk7hiedHWqUTuFBSMEZqAjSUqCY3WsOtDqnKZiowsrry0iPPaMLPC+QZpcXRmO2RiVr5fIYXa1Mx5YJpe0siDaa7bovz89dkXpgeZiwjHR1s1bLdktjxmmS1dE5lMtnkMx/tjJogtlmVE72mxiRnaZlSWH2xGxpExWlQkzW4N4nOQbNxonCuqaqqj8arznWuKtLZuY4J6fx8gP6O1HnMPPLoDCeJOgVCr3xOAFm38crG+rTRCnw1Yl9iT0KxPF2+p//9pjo0VdZpnHtwajwbxiQ1W2w4sxAVOX5wWlXhN4YiTawbYTJn7StzfC/dSAav83d3L+tek+jG73ZygQM9HxL6LXLo35ZIVjs0UrHlElihsZMdT3Q2A88gemA95AeSADhiiIBII2zMO3KTaXwHvjlhXmOXqo77RsLiYP947D6CPyJLmzCyoSDdOg02R8nISObSHYlByM5eUrdsECGLEX/lDzorZLqKnRcBz8tX+5oyVaQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 09.06.25 12:31, Ryan Roberts wrote: > Since commit 4b634918384c ("arm64/mm: Close theoretical race where stale > TLB entry remains valid"), all arches that use tlbbatch for reclaim > (arm64, riscv, x86) implement arch_flush_tlb_batched_pending() with a > flush_tlb_mm(). > > So let's simplify by removing the unnecessary abstraction and doing the > flush_tlb_mm() directly in flush_tlb_batched_pending(). This effectively > reverts commit db6c1f6f236d ("mm/tlbbatch: introduce > arch_flush_tlb_batched_pending()"). > > Suggested-by: Will Deacon > Signed-off-by: Ryan Roberts > --- Acked-by: David Hildenbrand -- Cheers, David / dhildenb