From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22A83C001E0 for ; Thu, 27 Jul 2023 09:11:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A85D98D0001; Thu, 27 Jul 2023 05:11:15 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id A10356B0074; Thu, 27 Jul 2023 05:11:15 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B0698D0001; Thu, 27 Jul 2023 05:11:15 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 77CFC6B0072 for ; Thu, 27 Jul 2023 05:11:15 -0400 (EDT) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 29ECE16053F for ; Thu, 27 Jul 2023 09:11:15 +0000 (UTC) X-FDA: 81056822910.05.A3A7D20 Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by imf27.hostedemail.com (Postfix) with ESMTP id 3BAFD40008 for ; Thu, 27 Jul 2023 09:11:13 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=lKnOasFR; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1690449073; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=cACJ3NT7rSPHksG1CSCDv/QZVUluNTqq4KXvaW886oI=; b=1mSaGHa8wZBXguFJEDrW+GKoWykclh6de0Oo6tHrpJJG1SFipbo55jOHWD8+C9VX4QAH5q uDOzyUxeWPXO1ovoy4QfRFSkC7KXLv8AF4MPOEw24D3xClyrUd8hQEbc3IynuUU21tjtBe 9vh83paB1wPuvZfOxiGDRsz9bQH9nG4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=lKnOasFR; dmarc=pass (policy=quarantine) header.from=bytedance.com; spf=pass (imf27.hostedemail.com: domain of zhengqi.arch@bytedance.com designates 209.85.210.181 as permitted sender) smtp.mailfrom=zhengqi.arch@bytedance.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1690449073; a=rsa-sha256; cv=none; b=M7F8GSk9yyJa4RQZS4bRgqlhU29nhNCip+OC39v1Us4DPaLp6TgvyYbY5N+8i+4nxZMr7v CuRiruRUtzd1zoLDZ5RSZFijHabWqmpIdRh70s5rnPMTvvINLu8/O1A0RVWXD0hgPPQNKw eyt6lAFAlx9oDc4PwfnowPavaC/e0Xs= Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-66d6a9851f3so177063b3a.0 for ; Thu, 27 Jul 2023 02:11:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1690449072; x=1691053872; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=cACJ3NT7rSPHksG1CSCDv/QZVUluNTqq4KXvaW886oI=; b=lKnOasFRjAEbGh7P40XbzLKtOkahlmVFUDvqCWW3ZgaRuzNJSwp4sTaKgMwNwz+Jpc hA4nVDJPH5aqf4q8bVxcWLUkzXpK23oeAFnlJRwJaEUIleLrrgs7btXzJpx3+9HaPfQV hGIP/T6lERVA8hpdk6KZN9Q4J/+wilHe5ZItz/9QQ1qHO3gv2Y4k+BaS5cDcOKz/WLAL 6NaRvNv6KF2mZ19RDXY6rbQZ5sQKyx2Yj2LrfaBgxjqmYdHbumQCN0WmWtbB+gjDIGzm PXmUTQGLOY5T8H3PnVo3H27NG4eQhipuKvHt4yAhK97ujnI+IJGqA8lmlUO0fy4wYeay +oXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690449072; x=1691053872; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=cACJ3NT7rSPHksG1CSCDv/QZVUluNTqq4KXvaW886oI=; b=Tc4w387Vmh/JZjpyhiVikfeDmcyo20+/sBswn2Kz9bM/AQYKibH4XC8sNvDautcU8i /fWGAquqFAf8OmQD2pRj2XzhUcgaNC1CvPIhtuRsXW6kVtqKI+8V7kHkAXD3un3+nKdU SerPoUh0/CtU5VgI+21hzP+GnYQvLPh+6b069XqykaLsomkXT8kZBOZc0vF36DiXRf3k EBIViPeFfjXARJdCmmAegxT7unS6KdhkPgjk8nSlg79JsX2/0yXSFoPcAV9pN5Xi7VTf 5rd+3YYu3z0Yr1OKgFmHGu6Mf/q40Jm2omoFqWOXC6kJen2o+Vujf/Pmxts0gE/VJWsp CDgA== X-Gm-Message-State: ABy/qLYnwIC2kw9mNafdbK3ZjQ6zAVNIPPkGCqVLRdkhCU9WQyQBQCGa neINshZ5HftHZsPh+ZXaJ5dakg== X-Google-Smtp-Source: APBJJlFfFWIsc+pfSeu4dzuDSzimKXTbXaekoL0gFKsbHel8kB/qljY4u0PtyM2mUW/wDh3jQGEPVg== X-Received: by 2002:a05:6a00:2d82:b0:675:8627:a291 with SMTP id fb2-20020a056a002d8200b006758627a291mr4692915pfb.3.1690449072033; Thu, 27 Jul 2023 02:11:12 -0700 (PDT) Received: from [10.70.252.135] ([203.208.167.147]) by smtp.gmail.com with ESMTPSA id h4-20020aa786c4000000b00682a99b01basm1038080pfo.0.2023.07.27.02.11.00 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 Jul 2023 02:11:11 -0700 (PDT) Message-ID: <1eb30b9e-c43b-b81e-4d96-5d6fa4f2894a@bytedance.com> Date: Thu, 27 Jul 2023 17:10:57 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v3 22/49] sunrpc: dynamically allocate the sunrpc_cred shrinker Content-Language: en-US To: akpm@linux-foundation.org, david@fromorbit.com, tkhai@ya.ru, vbabka@suse.cz, roman.gushchin@linux.dev, djwong@kernel.org, brauner@kernel.org, paulmck@kernel.org, tytso@mit.edu, steven.price@arm.com, cel@kernel.org, senozhatsky@chromium.org, yujie.liu@intel.com, gregkh@linuxfoundation.org, muchun.song@linux.dev Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, Muchun Song References: <20230727080502.77895-1-zhengqi.arch@bytedance.com> <20230727080502.77895-23-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: <20230727080502.77895-23-zhengqi.arch@bytedance.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 3BAFD40008 X-Rspam-User: X-Rspamd-Server: rspam04 X-Stat-Signature: gxjwqtxj7tsiya74kuminpnwzux39ogy X-HE-Tag: 1690449073-759883 X-HE-Meta: U2FsdGVkX1/KH3BsqouPK/8uH780nGo9I6fDonqmXl6iP402so8+J8Q6K9zihN1J9QNjptg6K8mGLC8P3Vru91SAHaGMiT4qXXOVgL+EcVadll8gv7eqUPOASe8jkPTS6u8qGcbs2eeMAhsWT2/Uc/9R82nxqPOcM9EjlEkfz2wFGvNtUyoRej8+IloGZAC6RBvV2MT9sN4s2eUafiNGbsEePnyp9GCbgL5YhbAamuGnXvVePrP+mB6dRQe6vhHADoFnS9Vxbt6a851ek2btspGi405ipRzkGk6e8eJnW6Bafk/CR8/mbcN7NzB3UBJDc1iZNhb/fGPTNYK6uD7Ub3kqDvDyDvHbOonvPL6ECl87UzWHLOrv3tzezUZLocJli5+iHk32vBje16YFq8ij3+GCMZSa8K+8ibSM3c/fA0FT6p81Rb+yMygKTR7s5GpyWls5/riAyJm+i5ktsh5Hvev5hP/xBBVj8IhFNJvPTVaWGBOMTCB1s+JCYuOiy1hI5rRihOnSEqzugIo1C8GiTGNcQFdqHZ/RijknjNqHDdT4ZFNy6lGU/2Mw0AEtaJFpa8burToXTDWWNpGvzCaG/ZEwHxdhE4vdAIj0OgakuFZvtYx2h+r8Bgc88Mx1WzbecNRKZ/KkNBApVYvQEcL+CxcxD0wb8KkkQPMdCa6S+m2boGGYR//xmS7E/Qsu/HomrXjcfcLlczmcbsfonNOMCUlFAmrC8DqUfZWj9XhxbiQbkxY0dKi/M84Y9cN1ukc2W2tSv7zEw7/kWduUArrhcU7Z3OfshGvcw9q4HmhpZMuIQPN6EIr0svoXSmnp8ZTuqINUcvi5w/HtuOGu3z3ZjEuX5tQI82nTX507ndPIMDMtXLteH43Lirqi77dUnZbDMUUVxx9ZEJH5ZomNq+FKX8oP9ljypYBkKFzhMfcyv476l+SVM/INq5xgEfR7YL8xjhSlFF/B817+csowOWP bjEqsd39 K4xxlA+JnDFKLQu57M8Y72B18KDCn1jwpUi4aQX8aIrutV4TbJ+JyyALHZYTVa8SIWJ99rImNvBINZkkYd54cU4s75eU9G2j8evjG1cnK0xCtQMv2hlKqkktkOmZVr5qMpRdmCwiN2FJbyLz7yf7PQhzk/A94kO5W2ZX57PAT61dtJKdEPBnoniHKPQKuWR3a30O7Sb3PAS/a5FbsPK6HP3Fx+x9zWp3oET5+NGLDDfiK0QYHYDC1IaPzg6SU+kWKQzs9oxLhbZEvunzMtnQKcCTHymEG40Jz1vUTFUqodP/SvM8gDa3CQzwxkuU1dGdAi7dKaw65/cTVKMmKCEZ6YI6njz0DLFVOghhLlaEYcid3+OfX+vsXU3kdYFnXZtx58urzFMzIrnKieAdLM5+U1XIq9jT4fKqq4gbldPDqgAxaYx20ktg2JMjMjYY7Iz7IZJwjdDnqHKmfzwgkfAnHDuTTBr12PX6oarxy X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On 2023/7/27 16:04, Qi Zheng wrote: > Use new APIs to dynamically allocate the sunrpc_cred shrinker. > > Signed-off-by: Qi Zheng > Reviewed-by: Muchun Song > --- > net/sunrpc/auth.c | 19 +++++++++++-------- > 1 file changed, 11 insertions(+), 8 deletions(-) > > diff --git a/net/sunrpc/auth.c b/net/sunrpc/auth.c > index 2f16f9d17966..6b898b1be6f5 100644 > --- a/net/sunrpc/auth.c > +++ b/net/sunrpc/auth.c > @@ -861,11 +861,7 @@ rpcauth_uptodatecred(struct rpc_task *task) > test_bit(RPCAUTH_CRED_UPTODATE, &cred->cr_flags) != 0; > } > > -static struct shrinker rpc_cred_shrinker = { > - .count_objects = rpcauth_cache_shrink_count, > - .scan_objects = rpcauth_cache_shrink_scan, > - .seeks = DEFAULT_SEEKS, > -}; > +static struct shrinker *rpc_cred_shrinker; > > int __init rpcauth_init_module(void) > { > @@ -874,9 +870,16 @@ int __init rpcauth_init_module(void) > err = rpc_init_authunix(); > if (err < 0) > goto out1; > - err = register_shrinker(&rpc_cred_shrinker, "sunrpc_cred"); > - if (err < 0) > + rpc_cred_shrinker = shrinker_alloc(0, "sunrpc_cred"); > + if (!rpc_cred_shrinker) Here should set err to -ENOMEM, will fix. > goto out2; > + > + rpc_cred_shrinker->count_objects = rpcauth_cache_shrink_count; > + rpc_cred_shrinker->scan_objects = rpcauth_cache_shrink_scan; > + rpc_cred_shrinker->seeks = DEFAULT_SEEKS; > + > + shrinker_register(rpc_cred_shrinker); > + > return 0; > out2: > rpc_destroy_authunix(); > @@ -887,5 +890,5 @@ int __init rpcauth_init_module(void) > void rpcauth_remove_module(void) > { > rpc_destroy_authunix(); > - unregister_shrinker(&rpc_cred_shrinker); > + shrinker_free(rpc_cred_shrinker); > }