From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1C34C369B2 for ; Thu, 17 Apr 2025 07:12:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 56E03280070; Thu, 17 Apr 2025 03:12:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 51BD3280066; Thu, 17 Apr 2025 03:12:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3BC09280070; Thu, 17 Apr 2025 03:12:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 1DE8C280066 for ; Thu, 17 Apr 2025 03:12:26 -0400 (EDT) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 00E2B1CAE99 for ; Thu, 17 Apr 2025 07:12:25 +0000 (UTC) X-FDA: 83342667450.09.75C5850 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by imf21.hostedemail.com (Postfix) with ESMTP id 6953E1C0008 for ; Thu, 17 Apr 2025 07:12:23 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cVu7Qa0l; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1744873943; a=rsa-sha256; cv=none; b=GInaLyEJGTL6KsUnr+DazujK67u5Sy8hja+Y7RsfejHzukyWHQl/hqsAQHnoSGTUoPIw08 SsbhpGtY1lWMjgS+/k8umWZ6PgW7eSNSRz40gZSNhRVoxLiP3JOTcNvBrqMH+Ud/ymCp32 1vsxpO3aX+LY6RLuiW+fFs3UVN6NNGk= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=cVu7Qa0l; dmarc=pass (policy=quarantine) header.from=redhat.com; spf=pass (imf21.hostedemail.com: domain of david@redhat.com designates 170.10.133.124 as permitted sender) smtp.mailfrom=david@redhat.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1744873943; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RS87iO4jmfjt13fRTdwJjBQzE4yIkbYOnPPbfZ4bwRA=; b=vez1luMJA2o+WhLxKcadIuN1i16KYyFQfo+11yi6fb+ZMFKcX0RY10XVo8pKPaHsfL+xe9 DJv1cBcMuFa5MXrqyySjRF48XTGw50FFp/vAB6e2xoaJ7c2MtnlXplbhoyTSmOIJQmr28r 5tafNtgohIHJsmNi8/sBDwks74rg21I= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1744873942; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=RS87iO4jmfjt13fRTdwJjBQzE4yIkbYOnPPbfZ4bwRA=; b=cVu7Qa0l1AAehz0y6kvx77YTeyoE3phGF7tjK0galdkG3qZ6CJ6u4a1aIFCSUSn/v5/KPb F3QD5WreUHxi5PXIYcKGY+kLgZbK36cndNMudEwEjcFHh32FOtICY1JBBMW10jZ7LEQ+Hx DRLj78FxAXBmgYN97gEq/PJdVUXeokY= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-692-gXFCek6tMsSDmS7gGKfMCg-1; Thu, 17 Apr 2025 03:12:21 -0400 X-MC-Unique: gXFCek6tMsSDmS7gGKfMCg-1 X-Mimecast-MFC-AGG-ID: gXFCek6tMsSDmS7gGKfMCg_1744873940 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-43cec217977so2097885e9.0 for ; Thu, 17 Apr 2025 00:12:21 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744873940; x=1745478740; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:user-agent :mime-version:date:message-id:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to; bh=RS87iO4jmfjt13fRTdwJjBQzE4yIkbYOnPPbfZ4bwRA=; b=YUr/xKPMPxBNY4ipg0WRkq4rr5C8GH9/qO1JyDs5LGAH4GBwF9ZTqa9ZVHhHvP5Ugr oSOnEGpuEg4M7jxNpz2KHBVQgNC8em9hAlpCViw3pcFoD5N+wZmKPaEJRe0ibYSJ6B1C OKS4bjV+ODenb4wagWvtD41T3matw4qlCsSGnSVNNU1LT0ygnXHmfqh+85+cxZntlJMj Qrq3deH01P4o9AW1TojhVCYdCJUs1NjnZcsNviDIk6IY4oe6evneQXWFGnqDzvJMyOr8 Sz3gaO14eMd0nCL9N/cbZWGQUpBHuujPbVI+n6Yg3sZCfvfRuwYNjkdklKIjM9tc3j1b iR5A== X-Forwarded-Encrypted: i=1; AJvYcCUie3Q/ShttJZo22Nxs0sfVSuGF491Oczm+IWZNHU2hURpUE7+4IeKwrLVXz8KjMi4EtSB8x9aSbA==@kvack.org X-Gm-Message-State: AOJu0Yxzut9YFxedCgTLMvkGRmXAOjRD29jI0E1aHdxUH78tO7oPF/OG haGtBJSQWlLHL8GqymuHmukW8u/dIw7QO993Fd+QWKDW65sUBsVhpPUiEo+I6iQPs+GnLb2epSI jhUODkAq+5O9XbsAok3OwXl1S6inaSkzTVB2xycxUORVuBbCM X-Gm-Gg: ASbGncsmXZO4wMtaFOQMIlBpZEAPPW4zGzA2uziXYKNtNmdHQCU97LunLe4ms1dp/Eu HmCVOA1wj5oCl4ld+9G3KsHUr99LqIDnfRhabPBcLyyB/4Y6QFuiJrUfpwwRp636vJAaWXpJM1l tldw4Q/OoFv/E3C8xNm/jufPYKSKoAy3RrkIh2MYmBKhUsPX71dfcVp3aX4QzSFZPOQtoy0X5Uu Ofc1G6ziCE0WExQzK4ghzUF3xkyaKamHxCvHLE8TsC+4V7ql9G6W3RUMDtJLiMLX+p1JxLDhdnx AQ9M4bVk1iTsMZuX2zhzpzvLjF1UY+AHfnK3lYZcqFwlqF+yuVcDuZjSD5IVp5EC0XLUsr20npV PA4RTlBGgnlveRmqlIzalsitMxge5EJElAze7Q9c= X-Received: by 2002:a5d:64ef:0:b0:39c:30d8:f104 with SMTP id ffacd0b85a97d-39ee5b132f7mr3851740f8f.6.1744873940045; Thu, 17 Apr 2025 00:12:20 -0700 (PDT) X-Google-Smtp-Source: AGHT+IEkzP25I+9dronHGl5AxgAxlFz8k24329bxCBjViqDkpRbnKh4svhpFKfbn/WpzKU6KDTAyFA== X-Received: by 2002:a5d:64ef:0:b0:39c:30d8:f104 with SMTP id ffacd0b85a97d-39ee5b132f7mr3851719f8f.6.1744873939699; Thu, 17 Apr 2025 00:12:19 -0700 (PDT) Received: from ?IPV6:2003:cb:c706:2700:abf9:4eac:588c:adab? (p200300cbc7062700abf94eac588cadab.dip0.t-ipconnect.de. [2003:cb:c706:2700:abf9:4eac:588c:adab]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39eae963f62sm18853738f8f.5.2025.04.17.00.12.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 17 Apr 2025 00:12:19 -0700 (PDT) Message-ID: <1eb021d5-3472-4a47-8a3f-d5bae83b8391@redhat.com> Date: Thu, 17 Apr 2025 09:12:18 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH stable 6.1] mm: Fix is_zero_page() usage in try_grab_page() To: Alex Williamson Cc: Salvatore Bonaccorso , Milan Broz , stable@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, Sasha Levin References: <20250416202441.3911142-1-alex.williamson@redhat.com> From: David Hildenbrand Autocrypt: addr=david@redhat.com; keydata= xsFNBFXLn5EBEAC+zYvAFJxCBY9Tr1xZgcESmxVNI/0ffzE/ZQOiHJl6mGkmA1R7/uUpiCjJ dBrn+lhhOYjjNefFQou6478faXE6o2AhmebqT4KiQoUQFV4R7y1KMEKoSyy8hQaK1umALTdL QZLQMzNE74ap+GDK0wnacPQFpcG1AE9RMq3aeErY5tujekBS32jfC/7AnH7I0v1v1TbbK3Gp XNeiN4QroO+5qaSr0ID2sz5jtBLRb15RMre27E1ImpaIv2Jw8NJgW0k/D1RyKCwaTsgRdwuK Kx/Y91XuSBdz0uOyU/S8kM1+ag0wvsGlpBVxRR/xw/E8M7TEwuCZQArqqTCmkG6HGcXFT0V9 PXFNNgV5jXMQRwU0O/ztJIQqsE5LsUomE//bLwzj9IVsaQpKDqW6TAPjcdBDPLHvriq7kGjt WhVhdl0qEYB8lkBEU7V2Yb+SYhmhpDrti9Fq1EsmhiHSkxJcGREoMK/63r9WLZYI3+4W2rAc UucZa4OT27U5ZISjNg3Ev0rxU5UH2/pT4wJCfxwocmqaRr6UYmrtZmND89X0KigoFD/XSeVv jwBRNjPAubK9/k5NoRrYqztM9W6sJqrH8+UWZ1Idd/DdmogJh0gNC0+N42Za9yBRURfIdKSb B3JfpUqcWwE7vUaYrHG1nw54pLUoPG6sAA7Mehl3nd4pZUALHwARAQABzSREYXZpZCBIaWxk ZW5icmFuZCA8ZGF2aWRAcmVkaGF0LmNvbT7CwZgEEwEIAEICGwMGCwkIBwMCBhUIAgkKCwQW AgMBAh4BAheAAhkBFiEEG9nKrXNcTDpGDfzKTd4Q9wD/g1oFAl8Ox4kFCRKpKXgACgkQTd4Q 9wD/g1oHcA//a6Tj7SBNjFNM1iNhWUo1lxAja0lpSodSnB2g4FCZ4R61SBR4l/psBL73xktp rDHrx4aSpwkRP6Epu6mLvhlfjmkRG4OynJ5HG1gfv7RJJfnUdUM1z5kdS8JBrOhMJS2c/gPf wv1TGRq2XdMPnfY2o0CxRqpcLkx4vBODvJGl2mQyJF/gPepdDfcT8/PY9BJ7FL6Hrq1gnAo4 3Iv9qV0JiT2wmZciNyYQhmA1V6dyTRiQ4YAc31zOo2IM+xisPzeSHgw3ONY/XhYvfZ9r7W1l pNQdc2G+o4Di9NPFHQQhDw3YTRR1opJaTlRDzxYxzU6ZnUUBghxt9cwUWTpfCktkMZiPSDGd KgQBjnweV2jw9UOTxjb4LXqDjmSNkjDdQUOU69jGMUXgihvo4zhYcMX8F5gWdRtMR7DzW/YE BgVcyxNkMIXoY1aYj6npHYiNQesQlqjU6azjbH70/SXKM5tNRplgW8TNprMDuntdvV9wNkFs 9TyM02V5aWxFfI42+aivc4KEw69SE9KXwC7FSf5wXzuTot97N9Phj/Z3+jx443jo2NR34XgF 89cct7wJMjOF7bBefo0fPPZQuIma0Zym71cP61OP/i11ahNye6HGKfxGCOcs5wW9kRQEk8P9 M/k2wt3mt/fCQnuP/mWutNPt95w9wSsUyATLmtNrwccz63XOwU0EVcufkQEQAOfX3n0g0fZz Bgm/S2zF/kxQKCEKP8ID+Vz8sy2GpDvveBq4H2Y34XWsT1zLJdvqPI4af4ZSMxuerWjXbVWb T6d4odQIG0fKx4F8NccDqbgHeZRNajXeeJ3R7gAzvWvQNLz4piHrO/B4tf8svmRBL0ZB5P5A 2uhdwLU3NZuK22zpNn4is87BPWF8HhY0L5fafgDMOqnf4guJVJPYNPhUFzXUbPqOKOkL8ojk CXxkOFHAbjstSK5Ca3fKquY3rdX3DNo+EL7FvAiw1mUtS+5GeYE+RMnDCsVFm/C7kY8c2d0G NWkB9pJM5+mnIoFNxy7YBcldYATVeOHoY4LyaUWNnAvFYWp08dHWfZo9WCiJMuTfgtH9tc75 7QanMVdPt6fDK8UUXIBLQ2TWr/sQKE9xtFuEmoQGlE1l6bGaDnnMLcYu+Asp3kDT0w4zYGsx 5r6XQVRH4+5N6eHZiaeYtFOujp5n+pjBaQK7wUUjDilPQ5QMzIuCL4YjVoylWiBNknvQWBXS lQCWmavOT9sttGQXdPCC5ynI+1ymZC1ORZKANLnRAb0NH/UCzcsstw2TAkFnMEbo9Zu9w7Kv AxBQXWeXhJI9XQssfrf4Gusdqx8nPEpfOqCtbbwJMATbHyqLt7/oz/5deGuwxgb65pWIzufa N7eop7uh+6bezi+rugUI+w6DABEBAAHCwXwEGAEIACYCGwwWIQQb2cqtc1xMOkYN/MpN3hD3 AP+DWgUCXw7HsgUJEqkpoQAKCRBN3hD3AP+DWrrpD/4qS3dyVRxDcDHIlmguXjC1Q5tZTwNB boaBTPHSy/Nksu0eY7x6HfQJ3xajVH32Ms6t1trDQmPx2iP5+7iDsb7OKAb5eOS8h+BEBDeq 3ecsQDv0fFJOA9ag5O3LLNk+3x3q7e0uo06XMaY7UHS341ozXUUI7wC7iKfoUTv03iO9El5f XpNMx/YrIMduZ2+nd9Di7o5+KIwlb2mAB9sTNHdMrXesX8eBL6T9b+MZJk+mZuPxKNVfEQMQ a5SxUEADIPQTPNvBewdeI80yeOCrN+Zzwy/Mrx9EPeu59Y5vSJOx/z6OUImD/GhX7Xvkt3kq Er5KTrJz3++B6SH9pum9PuoE/k+nntJkNMmQpR4MCBaV/J9gIOPGodDKnjdng+mXliF3Ptu6 3oxc2RCyGzTlxyMwuc2U5Q7KtUNTdDe8T0uE+9b8BLMVQDDfJjqY0VVqSUwImzTDLX9S4g/8 kC4HRcclk8hpyhY2jKGluZO0awwTIMgVEzmTyBphDg/Gx7dZU1Xf8HFuE+UZ5UDHDTnwgv7E th6RC9+WrhDNspZ9fJjKWRbveQgUFCpe1sa77LAw+XFrKmBHXp9ZVIe90RMe2tRL06BGiRZr jPrnvUsUUsjRoRNJjKKA/REq+sAnhkNPPZ/NNMjaZ5b8Tovi8C0tmxiCHaQYqj7G2rgnT0kt WNyWQQ== Organization: Red Hat In-Reply-To: <20250416202441.3911142-1-alex.williamson@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: PRQVbiF2YEyejNspHI9shrhQqLFp867sjjwpKB_MGAY_1744873940 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam11 X-Rspamd-Queue-Id: 6953E1C0008 X-Stat-Signature: koph8kx4ihfr4htq8yq8amgzc7t1qgg7 X-Rspam-User: X-HE-Tag: 1744873943-678855 X-HE-Meta: U2FsdGVkX18PSUZuIGJhdjFSEYc1iPaa49ZGWNu/2EQ2FyKKs/RdH2W7DD+Jjz5Srl2NkCvO3FvKZt29aX1M4Es8/u0pFeD+a7umwyHFJgDS/oZeJrODF1d8Iem7z3a8n5Un8nR/p2MGTttz+WwGcGtAItHWtOPopKektXKZOtNSDWiX4LXEfcwdynatfUxcK06uGoQjiLRqBNjGQaySyyRqywgbfVaOrkWbUTQkSTlIrVz0IEFxfubNdn7bFHi+I66Qg2yCo/Bb5aX7LVYqKR5jDHFLFx4KT/2K4rHnUfAO2CynGNG+VUFiyc6/vVMmlyACUSxVe817+2WT4B9SGJBtezMzXKhXq6P/snropjClnUtD0ihCpGeqszXkj02qmOZe4fkFwpsKP95irclytoDO1iqWU1DoVu9Ii08Vt22RsGTN9XUKKXt28MvWLuAEyKhyrbjGp7bn1EeOIaizIgHAtidn40YLpKsvjXC4W/KkVUk0c1I6Ic2LP1UM9EJit1DkkjnXRI0tiqN5tE8yJW0+GxGa6a9n5WEqyW+zQHgezfxj+s2AjhtR0ZAxIUZ9TvoV4u9GucOe2pEpLQiQH6IBE5sGY7FJMmEL5SUsLTlWzFymuTw01KVd9TztFTASnU+sIPs4oDbBKv4CyYIiyazNo1OM6RmvtQLFbqUHs8zEG87aIiTNOg3olMnc9tRxqfIgMQ8g0W4rckWWZVXK11rV4baQZWHRmBWCrbQCDajYNn4jfjIp5meL5I3u0moWhmkHZT96VIiGQ6Oh3/5bTzotfFqkPI+fPgI0kIEBfr832P56QNnDXxbCPZvZbq2dFfLjrnfOhFMP27OmGyKZ/Dz1cP9G7WiI4M9kX5ZPCcSjADkStAX5dFOQm9M+VKgbWIfI0Ex2qMPBLisg9RVmmgsWEkzO0ENrfjM1zsKiYCysQEG+AMthFXHu7kfyHp/R3HMdPYVbt5K5FKO/K9X C0e3MQAC oNIAKGxvNPh2vy9OSsWULNbYVBVpk+VSldgG6Wdk6WpIj+SxtS+YBrdiogzjm3rwYsNz1ckHzg2adAb/PtEfSH9PbxC75BDY1p7cutvllwmAyIklvcyGg6+Gg53I0qDySxhCxKO/6/pdH6tiR0jK92GQkSetu1nwyI2+Hy5r9+zXhngAr+3mvtvTtHTN8sn5v63Mm6B7v3m1g0Mv4TmPfg2YvhsM9vF4VCoLol7N0vCysNEgTnpOFsAvvp+rN8hk2dyBJgU3l1yENB6cv3qPcxXEsgHIwXOij0M5aJ7M0BaKAfxb3qNZ1GLCpWItvCLqVYmTUewh+42Xz9gDN3v9x2sOOA30e15triSa++VNuafWqzxPAzE3GwTMCqhsjEYkInoE1/lBXjIitHWmAO7ZuE/v6Nzh6XGJ/ypzb5KtD1MOrEGnv+doxWQagzgbBmF8ae46uEvuTzeuFLmK+gj+3MfB3KiH2Xgpv/P/GtLsMnnkOKzW2So2fljPhqpK4SYlQIfqNaC55wwKt2+bygOtBVyNEiPK87mUKOfWa+j0y4+s2+nV42BlCuJtl0pcdpFksY+j1NQ+qf671Q4x95hG8Fohp/qeO0eQUKeyc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 16.04.25 22:24, Alex Williamson wrote: > The backport of upstream commit c8070b787519 ("mm: Don't pin ZERO_PAGE > in pin_user_pages()") into v6.1.130 noted below in Fixes does not > account for commit 0f0892356fa1 ("mm: allow multiple error returns in > try_grab_page()"), which changed the return value of try_grab_page() > from bool to int. Therefore returning 0, success in the upstream > version, becomes an error here. Fix the return value. > > Fixes: 476c1dfefab8 ("mm: Don't pin ZERO_PAGE in pin_user_pages()") > Link: https://lore.kernel.org/all/Z_6uhLQjJ7SSzI13@eldamar.lan > Reported-by: Salvatore Bonaccorso > Reported-by: Milan Broz > Cc: stable@vger.kernel.org > Cc: linux-kernel@vger.kernel.org > Cc: linux-mm@kvack.org > Cc: Sasha Levin > Signed-off-by: Alex Williamson > --- > mm/gup.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/gup.c b/mm/gup.c > index b1daaa9d89aa..76a2b0943e2d 100644 > --- a/mm/gup.c > +++ b/mm/gup.c > @@ -232,7 +232,7 @@ bool __must_check try_grab_page(struct page *page, unsigned int flags) > * and it is used in a *lot* of places. > */ > if (is_zero_page(page)) > - return 0; > + return true; > > /* > * Similar to try_grab_folio(): be sure to *also* Reviewed-by: David Hildenbrand -- Cheers, David / dhildenb