From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BEA2FC47DA9 for ; Tue, 30 Jan 2024 03:40:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 503076B00D5; Mon, 29 Jan 2024 22:40:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4AFB06B00D6; Mon, 29 Jan 2024 22:40:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3519A6B00D7; Mon, 29 Jan 2024 22:40:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 1EB2D6B00D5 for ; Mon, 29 Jan 2024 22:40:00 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id E4BBC16043C for ; Tue, 30 Jan 2024 03:39:59 +0000 (UTC) X-FDA: 81734573718.12.1EF0E21 Received: from mail-oo1-f46.google.com (mail-oo1-f46.google.com [209.85.161.46]) by imf26.hostedemail.com (Postfix) with ESMTP id 063BB140004 for ; Tue, 30 Jan 2024 03:39:57 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=AYlRHS2C; spf=pass (imf26.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.161.46 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1706585998; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OAvFPVh6nfNVf1UYTTCYgzPrdH003MiVnVgbfyX/N3o=; b=h8ppMUv7F+cOnO6bu50FLF0H6K7Furedcb6iSbc6zMcB2Bln/dXJFjGpEXvLhIIegwPF4c LTPoXP0GiexHcs/EoyYsTFFfX/qPvY13tysP+0cQp+NH3Otz/Bmp51zeAqt4A2wj1ZqiPx 54dlAdKMHblP4FhDHBj+eOvawD3TA7U= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1706585998; a=rsa-sha256; cv=none; b=XX/TBX2oNpXJ5c7OyYHWGluESMqDGigrQZxegyY13D5m66TYfuAsLkoEuUvx09DfP2zS08 cLMfCGARxwC9qDG5QekmUx6FdksnOZf/rRzxkzIOCm6vJIJ/ZKEPh5JMfsUMYRe3hVbOPM tPCh7YAH7evxRJTLyc/yW/QmTWxiHq4= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=bytedance.com header.s=google header.b=AYlRHS2C; spf=pass (imf26.hostedemail.com: domain of zhouchengming@bytedance.com designates 209.85.161.46 as permitted sender) smtp.mailfrom=zhouchengming@bytedance.com; dmarc=pass (policy=quarantine) header.from=bytedance.com Received: by mail-oo1-f46.google.com with SMTP id 006d021491bc7-59a33cc946dso891137eaf.1 for ; Mon, 29 Jan 2024 19:39:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1706585997; x=1707190797; darn=kvack.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=OAvFPVh6nfNVf1UYTTCYgzPrdH003MiVnVgbfyX/N3o=; b=AYlRHS2CTwgrStzhAn6Yu9EcLRaT5/I/I6jriQr86Z9mX4bSv4/j41AXuDlJ0DjHUz 27CQSoBmWI75CSf+r/5Kj28C5Uqsj228OhPe9Q6AtoU1QvPw82hvQqCm7hG+6c8fANI9 p7qHOYQ1vyWYYs1F8vwJgKyLWJbhfaKhzjtG65PXkM8pfZtKYqeatisQgkOufle0FglW 8xkWJhxcVsfe14hiPAM892h9oBTrMZePaygIluN/rBeSq0hF2dD/I1n5inIfblQkmRmc Ox5xl4Kf+KlXS/XgyAlH0kUxYqjL6sISuzAFh4WF7gZsamI9U0AvRuYLSLQjsYWC/Jj2 vCEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706585997; x=1707190797; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OAvFPVh6nfNVf1UYTTCYgzPrdH003MiVnVgbfyX/N3o=; b=er1+hm8gTQA0/GUx8pjdPzemAQX/3b5PkEI5ZkZbTSwXpX15Pf88Nx3/17oWbDx1FL WAemxFefwbt0K+YlqJH2BY7E6t380wkAcqzvATouQ6C+5NUL7bVHbGVYSOy1YaAmnf27 msd5mphdq7ZDVnsjNEsdGuvMSL7n1QOUhl/ei4xCoNr9ob5m2H7+TIDXPA1rJJQPv5M3 MPfWN3q+oijiCBand4lsYrWFnFJ6tLqRn4M2dlQdeRWtvBU3YTTAcgoCNvL1vuYE0uBt fW+AjyuqRgufxnh3L3MGpyUOmvAgUKhV9syAIyixJeBdPC2C2r+Ikw55Fbm/7KVHjAkA WS/w== X-Gm-Message-State: AOJu0YzDOkGcFo547upW42NWJuvUHS9434YzzkoYPH1jQygXqZcDlVbt GbMTwEAq3gzibNURGKxdQLndt9BRYgFfeZWm88WXYGN/RAElfEXoRxiCoGqzS7g= X-Google-Smtp-Source: AGHT+IGfJ8xTHLEOmB9kZ3CLuaBn2PeBoooqOTYuXKJOOgfm4fhIOAzoNNbUUvkLZjEtUZIRBDQG2w== X-Received: by 2002:a05:6358:8a9:b0:176:8263:9a71 with SMTP id m41-20020a05635808a900b0017682639a71mr4424336rwj.13.1706585997173; Mon, 29 Jan 2024 19:39:57 -0800 (PST) Received: from [10.4.207.234] ([139.177.225.234]) by smtp.gmail.com with ESMTPSA id y17-20020a63b511000000b005d8b481c4d3sm5561909pge.87.2024.01.29.19.39.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jan 2024 19:39:56 -0800 (PST) Message-ID: <1eaf2a35-3b8b-4f40-96ab-3eb499a2aede@bytedance.com> Date: Tue, 30 Jan 2024 11:39:54 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 05/20] mm: zswap: clean up zswap_entry_put() Content-Language: en-US To: Johannes Weiner , Andrew Morton Cc: Nhat Pham , Yosry Ahmed , linux-mm@kvack.org, linux-kernel@vger.kernel.org References: <20240130014208.565554-1-hannes@cmpxchg.org> <20240130014208.565554-6-hannes@cmpxchg.org> From: Chengming Zhou In-Reply-To: <20240130014208.565554-6-hannes@cmpxchg.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Stat-Signature: u6m43nspoyank8ofqp55aue8yth8ryac X-Rspamd-Server: rspam10 X-Rspamd-Queue-Id: 063BB140004 X-Rspam-User: X-HE-Tag: 1706585997-302037 X-HE-Meta: U2FsdGVkX18rfGqIWUZaCnU4Rov4QGaBL/Zj0rL5ABX3AkMAPtEZ+qTO08ILDtCnm/6S2OgMxTfAvsuKiM/0diNS4VZU8RqqEOnlhhIPfrQCg5yfMXIuWEP67C9oF1/zSkwINzn+irx4xiYCfppFiYqbaCuGzTMfrzcGWmVOTE+FAvV11s1jQ8BIYCRUwAsnmfRhw4IJWS7ZxFejTsQm/6tSBWfV+a5WyBZhDPdmONjdcxOv8TzNV687HSV/Vg19Q31mtmCbA4clvDTcHBu5XkRjxrC2ZlGAb2n2Q7Hsuf6ObuBDvrYHazXO5JuJvSYFFfPxhbUOtkysqna61sGk071kdUzaPuHfeb98QH9sF55PER9TmLDGcZ821Z6Jp+L+9Vp6BMJnwl2FJ2NUPdbBkKnOgWySTOUYynvAH6V9ce7M7qnqhMgUVteGbMStFhSLyos9XjwkXq4JE7/zRHnWht/YsncS6tYqkJFoOJt8rzEi2V0zSh8zK4hqKmSisfRamZN58V2UdZH/dwu9wFuO3eD9YDQ0L9XmtvMlv223sK4qULMuuUUn5xJE5PEaxAFO2+bL0vTLFT7B5rhFmRNyNhtotnIwANLz/SThTEhgh2mVAfe56sTLxCwI6atLbz3U48oavUYCf5o/fes2hz4cbH0YUh7XdhINDA++O8457dQzaKRi1DLKoNOGgBq1OJFtw8SRjwhtUPcdNqJEPFK8zrsyWT7B/m2rQS/mhEIxG02w49+/wZCXdvfVOaV3SIF4BkSSnV51DFSjaxnfirx5nNkhWcrJSc3Bh0bWmFyoPx/Z9FY8uCPudGcPqRCbXL+LaODjRKgErTmlOY89X9NMiMKDz1CKZWsnzlR4cY460tWWd+7bhVmP34y4JfpnVbl3Uzkc+6hA0bdvTfOUrb7k4mb7w6wsTZtUhhklq5GopSfnNiVKGtkM/+ED8al93lx/WWDWVPMseJsI2PCnmX+ yNf1Po3F C19bndZ5bTyblghUuEwghz/ClB3075Qmo6yvBbceBZdAfDgfSS5ra5oGwLGzvHkS15BQ8Elx0s+oMetFI7crFGXLQ8Afz4GkYjkHTxfBQZXYc3jsgYGN2JDFNc/1jE8SD+HabyrTs2axrZAlBs+UEaBpDMQQ+6ysqMMosxVHkV2uA9YBG6y64AQ/4PDyVA5vSi6zmmzmvvqtOvUn1rp9KrQb3sZmyNJwQ874VP5QhLhyk9KoF5uvm+kZOQSemn1JVNl3siu4Sw5Q4td7gwkPKAz/wkFaPs8dBHUvNU6EaEl3VXB/7Y9NiSP+hDj5UfClR8y10pHP4z6h6kmJ2lYYriT+L/8Mst2j8/Ix7PuqK7y7++oEUzMfQjPg+0+ahYIgKLHBoQRYull+KfSmp4KQKcT4OXkdzz0PNUaQw4hzvNXqhiTtgRbNRFEj2IiMwjvR/iGMGOTzwUWqmOfy8iItY7yMMkLX7wXdC+t8Cfgnxbl9WXHu3I2NZVhGw66haPkkFIBFZ51FY3phGM/n9M+Rm5hCoCnpCxMlROqNAKHg+5TwvHu+j7LSbGdNDGJHUmTg2L/tD X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 2024/1/30 09:36, Johannes Weiner wrote: > Remove stale comment and unnecessary local variable. > > Signed-off-by: Johannes Weiner Reviewed-by: Chengming Zhou > --- > mm/zswap.c | 10 +++------- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/mm/zswap.c b/mm/zswap.c > index 0c6adaf2fdb6..7a7e8da2b4f8 100644 > --- a/mm/zswap.c > +++ b/mm/zswap.c > @@ -546,15 +546,11 @@ static void zswap_entry_get(struct zswap_entry *entry) > entry->refcount++; > } > > -/* caller must hold the tree lock > -* remove from the tree and free it, if nobody reference the entry > -*/ > +/* caller must hold the tree lock */ > static void zswap_entry_put(struct zswap_entry *entry) > { > - int refcount = --entry->refcount; > - > - WARN_ON_ONCE(refcount < 0); > - if (refcount == 0) { > + WARN_ON_ONCE(!entry->refcount); > + if (--entry->refcount == 0) { > WARN_ON_ONCE(!RB_EMPTY_NODE(&entry->rbnode)); > zswap_entry_free(entry); > }