From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 79846CD11DD for ; Thu, 28 Mar 2024 17:46:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0D8866B0095; Thu, 28 Mar 2024 13:46:57 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 087AE6B0099; Thu, 28 Mar 2024 13:46:57 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E915D6B009A; Thu, 28 Mar 2024 13:46:56 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id CC08C6B0095 for ; Thu, 28 Mar 2024 13:46:56 -0400 (EDT) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 8DC0C40373 for ; Thu, 28 Mar 2024 17:46:56 +0000 (UTC) X-FDA: 81947178432.17.0363EC4 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id C2F7B180016 for ; Thu, 28 Mar 2024 17:46:53 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f0dgZsew; spf=pass (imf06.hostedemail.com: domain of vgupta@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=vgupta@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1711648013; a=rsa-sha256; cv=none; b=L0lc7IxhqrlxlH6ACToI0cdS8QiJese+5dkQL05aZNf/MWvfnuKRfemtXzDd9T0nb0ktDF QzQyY7OcKu/Kuy7jUY3thi60Nh2oIPenfz0wlHS4Qy2+8OSESmgU33naMKMpHXXP5UZlhA ExuUD49zOkg8S9SXWQ4KcxsaKr/Uy18= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=f0dgZsew; spf=pass (imf06.hostedemail.com: domain of vgupta@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=vgupta@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1711648013; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=wlzsI+uXb8CdECX3uBXdOPv2Zh52tOEYrPnOkwlecfM=; b=mJMYm7Mh9a1FgFGrXfOYDZiSzkoy/21PbW5NUwNeEuyc2GMaHOdKuJEPJBteWpkAlhBSQC jIh5jdXRkQqkKNv9c7U0MkUY/v/fg6KsQSlj+C3rMe9JQSNNtDvxNAxCIDSjkjJWE2BTDv 8ID+/cUXjlqDjCe2fM2w7WiTP/mTFgY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 9B613617D7; Thu, 28 Mar 2024 17:46:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 65F2CC433C7; Thu, 28 Mar 2024 17:46:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1711648012; bh=YNR7A+kRgAjMXDjHr2JB1yywFqUpQ/6e+8DUHAu4Nlg=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=f0dgZsewbfCG8PiA45FJQw1TL/EasYUMhLz2/QhlXeqqfXOMfSFzRv9IkgTHijlFV FhqTfFXUmCq641ywYGBQNJBov/tcSVKyclO43CvFgYl4vG0jR5PyLIGzGCMyZLU3uq upLsVvNze+XfKUgkqPNlhtRQ4CV0x+8HigCh3u2WrcBvzfPqQuTABnjeZ6Hvb3VE8w 6ZvOi3ANgqwkkwdMuKgaXo07dtclbN/G0YdTFjA+6G2vfiNmaVW0Ibuf2jgixdXOzz yzc01GzZXuDW31OzbOufYEa/h1z/NE2Qj9VquGG7bkMy752oMrsKA8KOWYY6NXnc2q ClRqTQBAOutLg== Message-ID: <1ea303d0-b5c6-4185-b6ae-8836c5ac0469@kernel.org> Date: Thu, 28 Mar 2024 10:46:50 -0700 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH RFC 0/3] mm/gup: consistently call it GUP-fast To: Mike Rapoport , Arnd Bergmann Cc: Vineet Gupta , David Hildenbrand , peterx , linux-kernel@vger.kernel.org, Andrew Morton , Jason Gunthorpe , John Hubbard , linux-arm-kernel@lists.infradead.org, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-s390@vger.kernel.org, linux-sh@vger.kernel.org, linux-mm@kvack.org, linux-perf-users@vger.kernel.org, linux-fsdevel@vger.kernel.org, x86@kernel.org, Ryan Roberts , Alexander Viro , Matt Turner , Alexey Brodkin References: <20240327130538.680256-1-david@redhat.com> <3922460a-4d01-4ecb-b8c5-7c57fd46f3fd@redhat.com> <3360dba8-0fac-4126-b72b-abc036957d6a@kernel.org> <10da3ced-9a79-4ebb-a77d-1aa49cc61952@app.fastmail.com> Content-Language: en-US From: Vineet Gupta In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam08 X-Rspamd-Queue-Id: C2F7B180016 X-Stat-Signature: pfq3ek9rbiyi3z89brgfxthg438g441z X-Rspam-User: X-HE-Tag: 1711648013-122448 X-HE-Meta: U2FsdGVkX18xs3pAIB3Rv9kHS4xahBmYltTHO55FHNdzkzDX+LxuFAN2AjoqYC+FvGXjo0yXde9BWPmZT9OD2sPQJN39ILikBR8SCgKEwrVtnQg17AP+kuaSV5kpimmqMNgF0R0MnaR7JEs5szT7xbthXMW/QxMKG/gJDsDHIxDjVJE+QwFn6GQldQyMj49Qc0tNCVpKgViBN/vAiQlSzCDiO6xqUJXJ0/6gaYHXbna8NJrTT0pkvKP3oN6rsMkHlLm8JtBcNDyXJvkcn1LKA5Ey6lX5JnL1Y7NNJEkPbdcuWoZy2wYwg6PIH57jUhLDgKS08AWVV1e++LNEC0snfG4zO+yqKpDi4MXQaAAuEpu0idgMbQE+soW7vtSoK1ouHuDGDKNDEw5yoNDTsragVIpQKtju+bhfkqE1k5ogNnwG4Lq/30Js8naUo8VIpgYPVWICAf4z3SmQJTnSJ51EcSQCdAB4pdg43NRgJHiNyzAJOsjYvtYY8sIWnDpUcJizKW6a/ht92GnjCYLcp9sDNebqfZ2/RZEPxcTH7NyOpL19Rp90jodZWbxq8V77vBpNRaHjWaK9OaAf3WYnJeF8m40EU68h5A0CcZECFBynesIzcOeSwkSi+dWv/ND9omBlM8s1e7LkUeXxdsZDn2gt04TNLYIXKbsDdb9ZXcLBCbsEgLKDjRHuZn9Ey8EgED01/DL1qWtoEjj9Nv2uKNwN5KulOku3sVeVnazQdVa1uP6FOsUMJ9LphbPatwgjEV25FFdPatsM2Uw98NB2UHuSre/POCLdcfqjYguaT0WkBuUUo9lRSTmm3hikaokBBiJLSI+mA1TbVIAVshVaDfzeN7uIRSwxdrsFLAQwiIBYtLF2CZtbfj63p7m9eiDxI/muV20U2EqHa2aWmJAbEETUANRYobvcrcZBgJu/rL56mZO5t9GS90Ri+wrgSkESFc0qQBCNzukN5cNySeEPs0O N8tcGyzp 7Mq6dukyaj+eVsSn9e15gZ08F2W67VtCTcpFtcjHtt2T/wB9rcz/6Ev5FqOSYu2/ggGvw3pH985p1gcXb6OxY+tiEAZmIFBS+urNJhCUGgEzl1SkTLTAADdYlqInip7M0GQjx50drAJatxzsmDLNlDihrY8CjQp3px99HpbFKgYpdQSRo/X3ESqxtlH/PhgRNaqvE7UHKLw0BXBrCe7cLlQ2gfMWHMdETHc45mSgIpFWXE6aCfgbzzXI7bY85W6N8FUz4+HH285OO5hYpEOTE3+o6SOvncaWq/cxL2QVxVUdP1KSWUbKvQAFX/CbdDtPgXb8CVEzUH8HSrve9b4sN6n9kfn3e5EgiJY2Io4OyFwgVXvwvYpKkvDpJNKyCIyZuUftmbJjnHe7bXcrnw+1c00RiLD5ULK2AMAX8O7Z4ezod25MlIalLTLXFQoAeVmkmE6p5WNkXurrEzX1H7u7e8EW4gbh64kO43EK+liQ4pnQ0KUpdFBDKMY2jZw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On 3/28/24 00:15, Mike Rapoport wrote: > On Thu, Mar 28, 2024 at 07:09:13AM +0100, Arnd Bergmann wrote: >> On Thu, Mar 28, 2024, at 06:51, Vineet Gupta wrote: >>> On 3/27/24 09:22, Arnd Bergmann wrote: >>>> On Wed, Mar 27, 2024, at 16:39, David Hildenbrand wrote: >>>>> On 27.03.24 16:21, Peter Xu wrote: >>>>>> On Wed, Mar 27, 2024 at 02:05:35PM +0100, David Hildenbrand wrote: >>>>>> >>>>>> I'm not sure what config you tried there; as I am doing some build tests >>>>>> recently, I found turning off CONFIG_SAMPLES + CONFIG_GCC_PLUGINS could >>>>>> avoid a lot of issues, I think it's due to libc missing. But maybe not the >>>>>> case there. >>>>> CCin Arnd; I use some of his compiler chains, others from Fedora directly. For >>>>> example for alpha and arc, the Fedora gcc is "13.2.1". >>>>> But there is other stuff like (arc): >>>>> >>>>> ./arch/arc/include/asm/mmu-arcv2.h: In function 'mmu_setup_asid': >>>>> ./arch/arc/include/asm/mmu-arcv2.h:82:9: error: implicit declaration of >>>>> function 'write_aux_reg' [-Werro >>>>> r=implicit-function-declaration] >>>>> 82 | write_aux_reg(ARC_REG_PID, asid | MMU_ENABLE); >>>>> | ^~~~~~~~~~~~~ >>>> Seems to be missing an #include of soc/arc/aux.h, but I can't >>>> tell when this first broke without bisecting. >>> Weird I don't see this one but I only have gcc 12 handy ATM. >>> >>>     gcc version 12.2.1 20230306 (ARC HS GNU/Linux glibc toolchain - >>> build 1360) >>> >>> I even tried W=1 (which according to scripts/Makefile.extrawarn) should >>> include -Werror=implicit-function-declaration but don't see this still. >>> >>> Tomorrow I'll try building a gcc 13.2.1 for ARC. >> David reported them with the toolchains I built at >> https://mirrors.edge.kernel.org/pub/tools/crosstool/ >> I'm fairly sure the problem is specific to the .config >> and tree, not the toolchain though. > This happens with defconfig and both gcc 12.2.0 and gcc 13.2.0 from your > crosstools. I also see these on the current Linus' tree: > > arc/kernel/ptrace.c:342:16: warning: no previous prototype for 'syscall_trace_enter' [-Wmissing-prototypes] > arch/arc/kernel/kprobes.c:193:15: warning: no previous prototype for 'arc_kprobe_handler' [-Wmissing-prototypes] Yep these two I could trigger and fix posted [1] > This fixed the warning about write_aux_reg for me, probably Vineet would > want this include somewhere else... > > diff --git a/arch/arc/include/asm/mmu-arcv2.h b/arch/arc/include/asm/mmu-arcv2.h > index ed9036d4ede3..0fca342d7b79 100644 > --- a/arch/arc/include/asm/mmu-arcv2.h > +++ b/arch/arc/include/asm/mmu-arcv2.h > @@ -69,6 +69,8 @@ > > #ifndef __ASSEMBLY__ > > +#include > + > struct mm_struct; > extern int pae40_exist_but_not_enab(void); Thx Mike. Indeed the fix is trivial but on tip of tree I still can't trigger the warning to even test anything. I'm at following with my other fixes.     2024-03-27 962490525cff Merge tag 'probes-fixes-v6.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace   I tried defconfig build as well as the exact config from Linaro report [2], and/or various toolchains: from snps github, Arnd's crosstool toolchain. Granted all of these are linux toolchains - I vaguely remember at some time, baremetal elf32 toolchain behaved differently due to different defaults etc. I have a feeling this was something transient which got fixed up due to order of header includes etc. Anyone in the followup email David only reported 2 warnings which have been tended to as mentioned above - will be sent to Linus soon. [1] http://lists.infradead.org/pipermail/linux-snps-arc/2024-March/007916.html [2] https://storage.tuxsuite.com/public/linaro/lkft/builds/2eA2VSZdDsL0DMBBhjoauN9IVoK/ Thx, -Vineet